docker-compose exec web make jsbut to no avail...
/isbn/1234.json3 API that's the start of import codepath being discussed?
if not works: works = some_rpc_to_find_match(doc)
make_recordis never called?
make_recordis always called. so actually - seems it's this line that defines1
self.docsthat should just already have the right data perhaps ... but from
query_keys2 documentation, i'm guessing (however it's implemented) it's not intended to be a general search but just a 1:1 lookup.
thanks @mekarpeles -- if i'm understanding the Book API correctly then it's also just a check if the ISBN already exists right? (eg
https://openlibrary.org/api/books?bibkeys=ISBN:9781410490834 returns but that's only because openlibrary now actually knows about this ISBN - just before import i describe in that bug, it was probably returning an empty object?)
So if we wanted to fix this import bug it'd be a two part problem?
is the API i'm thinking of ((1) above) available? (from the api page you linked to, the
bibkeys= API ((4) on that page) doesn't seem quite generic enough - it only takes OLID, or LCCN, or OCLC, or ISBN, right?
(i see you linked to the data dumps - i might be missing something - not sure how to make use of that for this bug)
.jsonto see the output... https://openlibrary.org/books/OL26835764M.json This is not just a boolean.
qq: should folks generally work off anything other than master branch as a default?
i'm asking because Development practices uses the term "hotfix" which I think implies there's a "stable" and a "dev" preference in branches (eg: feature branches should be based off of dev... i do i see a
dev branch but also a