openlibrary/Lobby

Mek

@mekarpeles

@proghead00 please do ask questions!

And welcome :)

Jonathan Zacsh

@jzacsh

naive (total-noob-to-this-codebase) question:

context: https://github.com/internetarchive/openlibrary/issues/3473#issuecomment-748543803 - i'm assuming it's this /isbn/1234.json3 API that's the start of import codepath being discussed?
if i wanted to search for possible workid matches based on existing data, do it here1? eg:
```
if not works:
works = some_rpc_to_find_match(doc)
```
or just modify this branch in the caller2 so that make_record is never called?

Jonathan Zacsh

@jzacsh

oh nvm, i misread that caller's code. looks like make_record is always called. so actually - seems it's this line that defines1 self.docs that should just already have the right data perhaps ... but from query_keys2 documentation, i'm guessing (however it's implemented) it's not intended to be a general search but just a 1:1 lookup.

Mek

@mekarpeles

@jzacsh the /isbn path will resolve to the correct Open Library record if it exists or attempt to import it from other sources. The import route is currently disabled (until Tuesday this upcoming week) because we just redesigned how our imports work (and had to temporarily pause this import path)

@cclauss regarding this -- since our new system submits a book initially (and likely won't get a response the first attempt) if a book is not in the system, we should probably try submitting a few times to the lookup-server (to give one a chance to succeed)

Correct @jzacsh just a 1-off search or import. If you need to do a bulk search by ISBN, you may wish to either consider our data dump https://openlibrary.org/developers/dumps or one of our search/book APIs:

https://openlibrary.org/dev/docs/api/books

Jonathan Zacsh

@jzacsh

thanks @mekarpeles -- if i'm understanding the Book API correctly then it's also just a check if the ISBN already exists right? (eg https://openlibrary.org/api/books?bibkeys=ISBN:9781410490834 returns but that's only because openlibrary now actually knows about this ISBN - just before import i describe in that bug, it was probably returning an empty object?)

So if we wanted to fix this import bug it'd be a two part problem?

identify the right API to let you search more generally (eg: by Title, Author - eg: whatever backs this page: https://openlibrary.org/search?q=Lily+and+the+octopus&mode=everything)
build new UX during import to let users say "yes, that work seems like a correct match, even though you (openlibrary) haven't seen this ISBN/edition yet"

is the API i'm thinking of ((1) above) available? (from the api page you linked to, the bibkeys= API ((4) on that page) doesn't seem quite generic enough - it only takes OLID, or LCCN, or OCLC, or ISBN, right?

(i see you linked to the data dumps - i might be missing something - not sure how to make use of that for this bug)

Christian Clauss

@cclauss

Add .json to see the output... https://openlibrary.org/books/OL26835764M.json This is not just a boolean.

https://openlibrary.org/isbn/1501126229.json

Jonathan Zacsh

@jzacsh

wrt books/..json i'm not sure i follow - that's the output of a query against a particular edition ID right?

wrt /search?...json it doesn't render the JSON for me (i still see the same UI)

1 reply

ah - sent before your message-edit. yeah so that isbn json output is what i'm guessing would have returned empty at the time of the import (because that ISBN didn't exist yet in openlibrary)

Christian Clauss

@cclauss

/isbn is against an isbn, books is against an OLid

https://github.com/internetarchive/openlibrary/wiki/Endpoints#list-of-all-routes can help sometimes.

Jonathan Zacsh

@jzacsh

(i could be missing something) what i'm saying is I don't think we can do by-id lookups of any sort, we need to do a general search on (title, author, ...other metadata...)

thanks for that - yeah i was looking at that wiki - i didn't see anything about searching for works (i see there's a create/delete work API though)

though i could be lacking context on that "list of all routes" dump at the bottom - maybe there's something there for me to grok, but i think that's just a kind of codebase-exploration-helper right?

Jonathan Zacsh

@jzacsh

okay left a comment on the bug and i'll stop investigating now (i suspect i'm too new to OL to add value here, so i'll sit back). thanks for the links both of you!

i'll keep watching the project and watching the starter-bugs as I start using OL personally :thumbsup:

Romi-776

@Romi-776

I have done the setup of openlibrary.
I am a beginner in open source contribution so can anyone tell me that how can I start the contribution in this project?

Christian Clauss

@cclauss

@Romi-776 Please go thru the menu at the right-hand side of https://github.com/internetarchive/openlibrary/wiki especially the developer resources. Also look at the Good First Issues https://github.com/internetarchive/openlibrary/issues?q=is%3Aissue+is%3Aopen+label%3A%22Good+First+Issue%22

box5525

@box5525

hi All, I wish to contribute as a Backend Engineer (Python), Could someone please connect me to the concerned Team Lead for the Backend Engineering ?

Brenfrow01

@Brenfrow01

Hi 👋, I'm new. I don't really know how to code as I never went to a school for it. Wondering if I can be of some help in another way. I'm great at research and finding information. Please advise. The.

Roshan Zameer

@roshanzameer201_twitter

Guys, is there a community call today?

Romi-776

@Romi-776

Thanks @cclauss .
But I have a question that in order to do some work on any issue do we need to ask for permission and if given then we can work on that issue?
Or we can just solve the problem listed in an issue in our own remote repo and then ask for a pull request if everything seems well?

3 replies

Christian Clauss

@cclauss

@Romi-776 I am not a believer in waiting... So go for it... If you see something that needs fixing then give it a try and then open a pull request. If multiple people create pull requests to fix the same issue, it is almost always a learning experience.

Jonathan Zacsh

@jzacsh

qq: should folks generally work off anything other than master branch as a default?

i'm asking because Development practices uses the term "hotfix" which I think implies there's a "stable" and a "dev" preference in branches (eg: feature branches should be based off of dev... i do i see a dev branch but also a master-dev branch)?

Christian Clauss

@cclauss

I always start from an up-to-date master and then do git checkout -b my-new-idea and then make modifications. Please do not focus on hotfixs because they are rare.

Christian Clauss

@cclauss

scripts/copydocs allows you to bring in books, etc. on legacy Python but not on Py3 internetarchive/openlibrary#4285

Saeed Moqadam

@smoqadam

Hi everyone, I started to develop a mobile app for openlibrary, but it seems the API is not completed yet

for example, I sent a request to get the data for a specific book:
https://openlibrary.org/api/books?bibkeys=OLID:OL7062714M&jscmd=data&format=json

but it doesn't contain ratins, reviews, want to read, currently reading, etc.

also ISBN is missing from the result

Romi-776

@Romi-776

I have a question.
After setting up the openlibrary locally, we have a limited set of books and data on it then how can we solve that issue which deals with a specific book or other data which is present online on the site but not on our local server?
Let's take an example of solving this issue locally :-
Book cover missing #4047
How can I access the specified book locally?

Christian Clauss

@cclauss

scripts/copydocs.py

Mek

@mekarpeles

I think we should have docs for this process on our wiki

https://github.com/internetarchive/openlibrary/wiki/Getting-Started#importing-test-data

Aditya Prakash

@prakashaditya369

Hi
I am Aditya. I am interested in participating in the GSOC'21. I have a good experience in Python and Javascript including ReactJS. I am also skilled in backend services like NodeJS, flask. In view of that, I am willing to contribute to this project. I need some suggestions on how to start contributing.

Christian Clauss

@cclauss

Hi Aditya, Thanks for your interest! Our entire wiki should be of interest but https://github.com/internetarchive/openlibrary/wiki/Google-Summer-of-Code focuses on GSOC. The getting started and getting setup pages should help.

Aditya Prakash

@prakashaditya369

@cclauss Thanks!

aryanag1971

@aryanag1971

hello

aryanag1971

@aryanag1971

I am Aryan Agarwal. I am interested in participating in GSOC'21, and I have good knowledge of Javascript, Python NodeJS. And I also have good grasp on DS Algo, I want to contribute to this project, so can anyone please give suggestions about how to start contributing.

Christian Clauss

@cclauss

Hi Aryan, Thanks for your interest! Our entire wiki should be of interest but https://github.com/internetarchive/openlibrary/wiki/Google-Summer-of-Code focuses on GSOC. The getting started and getting setup pages should help.

aryanag1971

@aryanag1971

Thanks, @cclauss

Shivam Sundram

@RATED-R-SUNDRAM

hello team, I am Shivam Sundram currently in my 2nd year undergrads .I would like to contribute to the community to the best i can with my knowledge in python and js. I am also looking for contributing in gsoc'21 so any guidance for beginners like me is highly appreciated.

Aditya Prakash

@prakashaditya369

I wanted to work on #3630. But got no confirmation. Is it open to work?

Christian Clauss

@cclauss

The issue is in an open state so if you know how to fix it then please submit a pull request. Waiting is not required.

Manav1

@Manav1

Hi, I cloned openlibrary project and followed all the steps mentioned. After running docker-compose up command, I'm getting the following error. Please help me with this.

Yash Saravgi

@Yashs911

@Manav1 According to me this is a CR LF trouble.

Where communities thrive

People

Repo info

Activity