hello! Does the API have an OpenAPI schema, and if not, would you welcome a PR?
I think the api doesn't have an OpenAPI schema so by all means open a PR. Note the api is active development though
@bennypowers:matrix.org we'd probably want to have a conversation about the direction of our APIs prior to committing to a swagger spec. We've also considered graphql as a near-term offering. Our Tuesday community calls or a github "Question" type issue are likely the best avenues for this conversation :)
but i think it would be good to base it off an open api schema and rest api
is there a POST endpoint, or do I have to use the web form at https://openlibrary.org/books/add? the online docs appear to be incomplete
and is there a way to add a custom title for a contributor e.g.
Senior Content Editor or Executive Editor?
Hello friends. Did anything come of the GraphQL discussion? I have a little time available and I'm eager to start contributing. My neighbourhood is lacking a good English library and I want to write some software to make it easier for neighbours to open up their private bookshelves as lending libraries.
My idea is to use openlibrary as the database, via ISBN ids, and to have some PWA web UI for scanning then registering the book as part of the private library, or POSTing book metadata to openlibrary in case it's missing.
but fyi there is https://github.com/gramps-graphql/data-source-openlibrary
So my thoughts are
- implement POST and PUT (if they're not implemented yet)
- implement OpenAPI v3 schema
- generate GraphQL server from schema
- work on UI
- profit!
nice
that looks perfect
data-source is specific to apollo server. I had thought to use https://www.graphql-mesh.com/, but if the data source is under active development, all the better
well it might be worth investing in OpenAPI schema then
because then we get graphql for free via graphql-mesh
which can consume and open api schema and output graphql resolvers, that we can then plug in to any graphql server e.g. apollo-server
we could also geneerate docs site from openapi. I think the current docs are out of date? (no post docs)
ok cool. I saw that but skipped over it since I'm developing in node
beware : the api might change as said by @mekarpeles
yeah so that's why I'm keen to help write the OpenAPI schema first
until then I can work on my UI a little
oh i meant the server code that receives the requests
I opened internetarchive/openlibrary#5590 to track discussion on openapi/graphql
:point_up: Edit: Benny Powers: seems like the maintainers will appreciate a small Proof of Concept for an OpenAPI spec
but let's start with one or two hard coded properties
btw do you prefer json or yaml ?