Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    jimman2003
    @jimman2003:matrix.org
    [m]
    good idea
    Benny Powers
    @bennypowers:matrix.org
    [m]
    So my thoughts are
    1. implement POST and PUT (if they're not implemented yet)
    2. implement OpenAPI v3 schema
    3. generate GraphQL server from schema
    4. work on UI
    5. profit!
    nice
    that looks perfect
    jimman2003
    @jimman2003:matrix.org
    [m]
    post is supported already
    Benny Powers
    @bennypowers:matrix.org
    [m]
    data-source is specific to apollo server. I had thought to use https://www.graphql-mesh.com/, but if the data source is under active development, all the better
    jimman2003
    @jimman2003:matrix.org
    [m]
    that repo is old though :(
    Benny Powers
    @bennypowers:matrix.org
    [m]
    I see
    well it might be worth investing in OpenAPI schema then
    because then we get graphql for free via graphql-mesh
    which can consume and open api schema and output graphql resolvers, that we can then plug in to any graphql server e.g. apollo-server
    we could also geneerate docs site from openapi. I think the current docs are out of date? (no post docs)
    jimman2003
    @jimman2003:matrix.org
    [m]
    you can read https://github.com/internetarchive/openlibrary-client as a short term solution
    Benny Powers
    @bennypowers:matrix.org
    [m]
    does that just implement the REST apis?
    jimman2003
    @jimman2003:matrix.org
    [m]
    yes
    Benny Powers
    @bennypowers:matrix.org
    [m]
    ok cool. I saw that but skipped over it since I'm developing in node
    Benny Powers
    @bennypowers:matrix.org
    [m]
    nice
    beware : the api might change as said by @mekarpeles
    Benny Powers
    @bennypowers:matrix.org
    [m]
    yeah so that's why I'm keen to help write the OpenAPI schema first
    until then I can work on my UI a little
    Benny Powers
    @bennypowers:matrix.org
    [m]
    can I read the code to to the actual API endpoints?
    Benny Powers
    @bennypowers:matrix.org
    [m]
    nice
    oh i meant the server code that receives the requests
    jimman2003
    @jimman2003:matrix.org
    [m]
    I am a relative new contributor.. let me search that
    Benny Powers
    @bennypowers:matrix.org
    [m]
    ty
    jimman2003
    @jimman2003:matrix.org
    [m]
    Benny Powers
    @bennypowers:matrix.org
    [m]
    wonderful
    I opened internetarchive/openlibrary#5590 to track discussion on openapi/graphql
    sadn1ck.
    @sadn1ck:matrix.org
    [m]
    hello 👋
    jimman2003
    @jimman2003:matrix.org
    [m]
    Benny Powers: seems like the maintainers will appreciate a small PoC for an OpenAPI spec
    jimman2003
    @jimman2003:matrix.org
    [m]
    I am also curious about the bc I have never written/seen one
    :point_up: Edit: Benny Powers: seems like the maintainers will appreciate a small Proof of Concept for an OpenAPI spec
    Benny Powers
    @bennypowers:matrix.org
    [m]
    it really gets flying when you codegen it
    but let's start with one or two hard coded properties
    jimman2003
    @jimman2003:matrix.org
    [m]
    be sure to post it somewhere afterwards
    btw do you prefer json or yaml ?
    Benny Powers
    @bennypowers:matrix.org
    [m]
    yaml for this use
    sadn1ck.
    @sadn1ck:matrix.org
    [m]

    So I was working on this issue since it wasn't being worked on, internetarchive/openlibrary#5238, should I send a PR for review or wait for some more discussion?

    Trying to getting started with contributions to this, thanks for your time!

    jimman2003
    @jimman2003:matrix.org
    [m]
    send a PR.. seems an small and easy change
    sadn1ck.
    @sadn1ck:matrix.org
    [m]
    it is, yeah. ill send one, thank you :)
    p0p
    @p0p:matrix.org
    [m]
    Mek
    @mekarpeles
    hi @p0p:matrix.org some titles are encumbered by policies which limit their access to special audiences, such as those with print disabilities. This appears to be such an example
    p.s. thank you @bennypowers:matrix.org + @jimman2003:matrix.org :) efforts greatly appreciated. Getting a very small and scoped implementation that the community can play around with and evaluate on e.g. a Tuesday community call would be a great step. As is such, I wouldn't want anyone to sink too much time into something banking on it being permanent. Hopefully it can be! But for something like API contracts it's good to involve the community early and get feedback from those who will need to rely on these systems. ty!
    p0p
    @p0p:matrix.org
    [m]
    Huh I read it not too long ago and now I can't thouh
    jimman2003
    @jimman2003:matrix.org
    [m]
    hey Benny Powers working on a dgraph PoC for openlibrary. It uses an GraphQL type schema , so I made an elementary one: