Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    iFire
    @ifire:mozilla.org
    [m]
    I missed some messages. Notify me if they still are current.
    iFire
    @ifire:mozilla.org
    [m]
    Does anyone know if there's a way to query colors and replace them in thorvg?
    if color or gradient matches list of colors replace with a new color
    Hermet Park
    @hermet
    @ifire:mozilla.org hi,
    @ifire:mozilla.org Samsung/thorvg#693
    I'm considering to support the customization method.
    @ifire:mozilla.org I'm wondering if you can replace the svgs to "tvg" to use that feature.
    @ifire:mozilla.org let me think further the common interface
    Hermet Park
    @hermet
    @ifire:mozilla.org added interface suggestion in the link Samsung/thorvg#693
    @ifire:mozilla.org please have a look, and leave your opinions.
    Hermet Park
    @hermet
    @mmaciola Could you please put a checkbox for compression option of the tvg_exporter in viewer?
    2 replies
    @mmaciola what do you think?
    Hermet Park
    @hermet
    @mmaciola great, thanks for your contribution!
    iFire
    @ifire:mozilla.org
    [m]
    @hermet: Thank for you working on this task. You must be busy!
    We've starting advertising for godot 4 alpha so I don't want to delay too much. It's ok to be after alpha 1.
    Michal Szczecinski
    @mihashco
    @hermet hello
    @hermet I have a question about mathUpdateOutlineBBox.
    @hermet when the render region is calculated max value is moved
        renderRegion.min.x = xMin >> 6;
        renderRegion.max.x = (xMax + 63) >> 6;
        renderRegion.min.y = yMin >> 6;
        renderRegion.max.y = (yMax + 63) >> 6;
    @hermet this is connected with issue Samsung/thorvg#916
    @hermet could we consider to change mentioned part of the code to
        renderRegion.min.x =  xMin >> 6;
        renderRegion.max.x = xMax  >> 6;
        renderRegion.min.y =  yMin >> 6;
        renderRegion.max.y = yMax >> 6;
    Michal Szczecinski
    @mihashco
    @hermet I tested this change on all resources in src/examples/images/ and it looks ok.
    Hermet Park
    @hermet
    @mihashco Hi, I will double-check it and let you know the result. :)
    Michal Szczecinski
    @mihashco
    @hermet sure, thanks
    Hermet Park
    @hermet
    @mihashco I traced the history of the code... no clear reason. Could you please submit the change?
    Michal Szczecinski
    @mihashco
    @hermet sure, thanks
    Hermet Park
    @hermet
    @mmaciola ping
    @mmaciola I'm wondering if you are available or not for the static jpg loader.
    4 replies
    @mmaciola like this: Samsung/thorvg#920
    @mmaciola im asking you because you already prototyped jpg loader before. Thus if you'd like to contribute it, I'm gonna leave it to you.
    @projectitis fyi, static png loader has been prepared.
    1 reply
    Hermet Park
    @hermet
    @mmaciola please have a look at my comment. Samsung/thorvg#838
    Hermet Park
    @hermet
    @ifire:mozilla.org Samsung/thorvg#932
    The feature is prepared. Please have a look.
    Mira Grudzinska
    @mgrudzinska
    @hermet @JSUYA we had this conversation a few times already... I sent prs, that depend on each other (#816 depends on #812). We have a few prs regarding gradients and I tried to split them to be as small as possible. I know that this doesn't have the highest priority, so you may review them in some time, so I wanted to send all of them now to be able to concentrate on something else. Returning to all of these calculations after a break and deciding what change should be sent as the next one is very time consuming.
    Hermet Park
    @hermet
    @mgrudzinska neat and clean. #812 has been applied. please update the radial case as well. thanks.
    1 reply
    Mira Grudzinska
    @mgrudzinska
    @hermet for now in capi we have 'tvg_paint_transform' + 'tvg_paint_get_transform'
    and 'tvg_gradient_get_transform' + ''tvg_gradient_set_transform''
    Can we change 'tvg_paint_transform' -> 'tvg_paint_set_transform' ?
    Hermet Park
    @hermet
    @mgrudzinska Yes, it seems has to be. Go Go change please.
    Hermet Park
    @hermet
    @ifire:mozilla.org @projectitis please have a look at this Samsung/thorvg#594, static loader for png/jpg modules has been submitted. thanks.
    Mira Grudzinska
    @mgrudzinska
    @hermet please check #967
    1 reply
    Hermet Park
    @hermet
    @mgrudzinska Samsung/thorvg#37 wonderful Mira, you really did good job!
    1 reply
    Mira Grudzinska
    @mgrudzinska
    @hermet as @mihashco noticed, the explicit conversion is needed in the case when the bitwise or is used on engine types.
    since we release capi today, I sent pr in which I've changed the args type. please take a look and decide how we want to deal with it.
    Hermet Park
    @hermet
    @mmaciola this is the our official guidance for thorvg viewer update. https://github.com/Samsung/thorvg/wiki/ThorVG-Viewer-Development-Guide
    @mmaciola every release, i update it based on the guide. recently you updated thorvg viewer, if you think it needs more prerequisite or steps, please let me know.
    6 replies
    Karim Ahmed
    @kariem2k
    I just came across the repo! I was in search for vg renderer for months now (was using nanovg but it was slow for my purposes). Thank you very much. I will try to make a backend for it on bgfx. But I have a question, is performance suitable for games for maybe 100-200 basic dynamic objects on screen, dynamic in terms of movement and shape changes so tesselation caching will not be very efficient?