Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    iFire
    @ifire:mozilla.org
    [m]
    looking
    some log messages to draw() //113 line, tvgCanvasImpl.h. can you write more
    describe more
    Hermet Park
    @hermet
    Result draw()
    {
        if (drawing || paints.count == 0 || !renderer || !renderer->preRender()) return Result::InsufficientCondition;
    
        bool rendered = false;
        for (auto paint = paints.data; paint < (paints.data + paints.count); ++paint) {
            if ((*paint)->pImpl->render(*renderer)) rendered = true;
        }
    
        if (!rendered || !renderer->postRender()) return Result::InsufficientCondition;
    
        drawing = true;
    
        return Result::Success;
    }
    @ifire:mozilla.org so it fails here.
    iFire
    @ifire:mozilla.org
    [m]
    renderer is 0 I think
    Hermet Park
    @hermet
    Im wondering which condition brings the Result::InsufficientCondition
    iFire
    @ifire:mozilla.org
    [m]
    !renderer
    Hermet Park
    @hermet
    oh
    than it's not initialized.
    ImageLoaderSVG::ImageLoaderSVG() {
    tvg::CanvasEngine tvgEngine = tvg::CanvasEngine::Sw;
    uint32_t threads = std::thread::hardware_concurrency();
    if (threads > 0) {
    --threads;
    }
    if (tvg::Initializer::init(tvgEngine, threads) != tvg::Result::Success) {
    return;
    }
    }
    can you double check "if (tvg::Initializer::init(tvgEngine, threads) != tvg::Result::Success) {" ??
    it's successful or not
    iFire
    @ifire:mozilla.org
    [m]
    checking
    Hermet Park
    @hermet
    maybe thread count is not allowed
    or something else...
    or...,
    one possibility. "THORVG_SW_RASTER_SUPPORT" define is missed,
    iFire
    @ifire:mozilla.org
    [m]
    wait a second
    code in godot engine has THORVG_SW_RASTER_SUPPORT undef but THORVG_SW_RASTER_SUPPORT in thorvg is defined
    let me check
    iFire
    @ifire:mozilla.org
    [m]
    Huh
    It's late. I'll look at it in the morning.
    Will update git.
    iFire
    @ifire:mozilla.org
    [m]
    is this correct? if (!drawing) return Result::InsufficientCondition;
    Hermet Park
    @hermet
    @ifire:mozilla.org no, where that code come from?
    Result sync()
    {
        if (!drawing) return Result::InsufficientCondition;
    
        if (renderer->sync()) {
            drawing = false;
            return Result::Success;
        }
    
        return Result::InsufficientCondition;
    }
    if canvas->draw() is failed, sync() will get the situation.
    Hermet Park
    @hermet
    Hermet Park
    @hermet
    @JSUYA ping
    Hermet Park
    @hermet
    iFire
    @ifire:mozilla.org
    [m]
    @hermet: Are you around to assist? I was able to thorvg working again in Godot Engine. At a second review I was able to discover that the version string can't be "master" and needs to be "0.6.0" for example
    So I posted a prototype of the https://github.com/godotengine/godot/compare/master...fire:thorvg here, but the blocker is that I need to pass a mapping of old colors to new colors through the new api. Can you see if there's anything obvious I can do?
    if
        // std::unique_ptr<tvg::IteratorAccessor>
        //         accessor = tvg::IteratorAccessor::gen();
        // picture = accessor->access(move(picture), convert_tvg_color_func);
    }
    in modules/svg/image_loader_svg.cpp
    Need to pass: struct ReplaceColors { List<uint32_t> old_colors; List<uint32_t> new_colors; };
    iFire
    @ifire:mozilla.org
    [m]
    I will also discuss with the godot developer if a string replace on SVG color constants will work
    Like EDITOR_COLOR_LIGHT become #000000
    iFire
    @ifire:mozilla.org
    [m]
    I got it working.
    Hermet Park
    @hermet
    @ifire:mozilla.org hi @ifire:mozilla.org, so you made it successfully?
    Still are you in trouble with Samsung/thorvg#693 ?
    @ifire:mozilla.org could you please add yourself here? https://github.com/Samsung/thorvg/blob/master/AUTHORS
    1 reply
    JunsuChoi
    @JSUYA
    Merry christmas everyone :)
    Hermet Park
    @hermet
    @/all Merry Christmas!
    Michal Szczecinski
    @mihashco
    @/all Merry Christmas :)
    Mira Grudzinska
    @mgrudzinska
    I'm a bit late, but from me as well for all of us :D
    Merry Christmas !!
    Mira Grudzinska
    @mgrudzinska
    and a happy new year ! :)
    Hermet Park
    @hermet
    @/all happy new year! :)