Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    iFire
    @ifire:mozilla.org
    [m]
    It's late. I'll look at it in the morning.
    Will update git.
    iFire
    @ifire:mozilla.org
    [m]
    is this correct? if (!drawing) return Result::InsufficientCondition;
    Hermet Park
    @hermet
    @ifire:mozilla.org no, where that code come from?
    Result sync()
    {
        if (!drawing) return Result::InsufficientCondition;
    
        if (renderer->sync()) {
            drawing = false;
            return Result::Success;
        }
    
        return Result::InsufficientCondition;
    }
    if canvas->draw() is failed, sync() will get the situation.
    Hermet Park
    @hermet
    Hermet Park
    @hermet
    @JSUYA ping
    Hermet Park
    @hermet
    iFire
    @ifire:mozilla.org
    [m]
    @hermet: Are you around to assist? I was able to thorvg working again in Godot Engine. At a second review I was able to discover that the version string can't be "master" and needs to be "0.6.0" for example
    So I posted a prototype of the https://github.com/godotengine/godot/compare/master...fire:thorvg here, but the blocker is that I need to pass a mapping of old colors to new colors through the new api. Can you see if there's anything obvious I can do?
    if
        // std::unique_ptr<tvg::IteratorAccessor>
        //         accessor = tvg::IteratorAccessor::gen();
        // picture = accessor->access(move(picture), convert_tvg_color_func);
    }
    in modules/svg/image_loader_svg.cpp
    Need to pass: struct ReplaceColors { List<uint32_t> old_colors; List<uint32_t> new_colors; };
    iFire
    @ifire:mozilla.org
    [m]
    I will also discuss with the godot developer if a string replace on SVG color constants will work
    Like EDITOR_COLOR_LIGHT become #000000
    iFire
    @ifire:mozilla.org
    [m]
    I got it working.
    Hermet Park
    @hermet
    @ifire:mozilla.org hi @ifire:mozilla.org, so you made it successfully?
    Still are you in trouble with Samsung/thorvg#693 ?
    @ifire:mozilla.org could you please add yourself here? https://github.com/Samsung/thorvg/blob/master/AUTHORS
    1 reply
    JunsuChoi
    @JSUYA
    Merry christmas everyone :)
    Hermet Park
    @hermet
    @/all Merry Christmas!
    Michal Szczecinski
    @mihashco
    @/all Merry Christmas :)
    Mira Grudzinska
    @mgrudzinska
    I'm a bit late, but from me as well for all of us :D
    Merry Christmas !!
    Mira Grudzinska
    @mgrudzinska
    and a happy new year ! :)
    Hermet Park
    @hermet
    @/all happy new year! :)
    Hermet Park
    @hermet
    @mgrudzinska enjoy holiday!
    Mira Grudzinska
    @mgrudzinska
    Oh, I am enjoying them more than ever :D
    Hermet Park
    @hermet
    @mgrudzinska :D
    rey
    @rlaguilarc:matrix.org
    [m]
    Hi @hermet
    Have you guys had any time to look at supporting lottie files on thorvg?
    Hermet Park
    @hermet
    On considering, just lack of time!
    iFire
    @ifire:mozilla.org
    [m]
    Good news. thorvg is merged into Godot Engine
    Expect to see a steady stream of bug reports as Godot Engine and Thorvg gets more robust
    We'll merge stable releases
    I'm hyped about thorvg.
    Mira Grudzinska
    @mgrudzinska
    @ifire:mozilla.org that's great!
    Hermet Park
    @hermet
    @ifire:mozilla.org cool, thanks!
    iFire
    @ifire:mozilla.org
    [m]
    Thoughts about making a monthly release? There has been some improvements and a month is a good cadence. Also I wanted to use some of the recent bugfixes.
    Hermet Park
    @hermet
    @ifire:mozilla.org agree. I will release the minor version up in this month.
    JunsuChoi
    @JSUYA
    @ifire:mozilla.org WOW Thanks :)
    Hermet Park
    @hermet
    :)
    Mira Grudzinska
    @mgrudzinska
    Since it's Valentines day - I ❤️ tvg
    Hermet Park
    @hermet
    :-)
    give me a chocolate :)
    Mira Grudzinska
    @mgrudzinska
    come to get them xd
    Mira Grudzinska
    @mgrudzinska

    @hermet regarding symbol element - the most important thing is fixed - it works for aspectRatio != none. I still see some issues with resizing - I need to investigate it, but hopefully it's not so important. #1183 - this is a small problem - I need to mark whether the viewBox was set or not. didn;t manage to do this today. I'll do it tmr

    despite that, I think we should include symbol implementation as the enhancement into v0.8.