Result sync()
{
if (!drawing) return Result::InsufficientCondition;
if (renderer->sync()) {
drawing = false;
return Result::Success;
}
return Result::InsufficientCondition;
}
if canvas->draw() is failed, sync() will get the situation.
2 replies
@hermet: Are you around to assist? I was able to thorvg working again in Godot Engine. At a second review I was able to discover that the version string can't be "master" and needs to be "0.6.0" for example
So I posted a prototype of the https://github.com/godotengine/godot/compare/master...fire:thorvg here, but the blocker is that I need to pass a mapping of old colors to new colors through the new api. Can you see if there's anything obvious I can do?
if
// std::unique_ptr<tvg::IteratorAccessor>
// accessor = tvg::IteratorAccessor::gen();
// picture = accessor->access(move(picture), convert_tvg_color_func);
}
in modules/svg/image_loader_svg.cpp
Need to pass:
struct ReplaceColors {
List<uint32_t> old_colors;
List<uint32_t> new_colors;
};
I will also discuss with the godot developer if a string replace on SVG color constants will work
Like EDITOR_COLOR_LIGHT become #000000
Still are you in trouble with Samsung/thorvg#693 ?
@ifire:mozilla.org could you please add yourself here? https://github.com/Samsung/thorvg/blob/master/AUTHORS
1 reply
Hi @hermet
Have you guys had any time to look at supporting lottie files on thorvg?
Have you guys had any time to look at supporting lottie files on thorvg?
Expect to see a steady stream of bug reports as Godot Engine and Thorvg gets more robust
We'll merge stable releases
I'm hyped about thorvg.
Thoughts about making a monthly release? There has been some improvements and a month is a good cadence. Also I wanted to use some of the recent bugfixes.
:)
give me a chocolate :)
@hermet regarding symbol element - the most important thing is fixed - it works for aspectRatio != none. I still see some issues with resizing - I need to investigate it, but hopefully it's not so important. #1183 - this is a small problem - I need to mark whether the viewBox was set or not. didn;t manage to do this today. I'll do it tmr
despite that, I think we should include symbol implementation as the enhancement into v0.8.