@ifire:mozilla.org I think I can refer your code here https://github.com/fire/godot/blob/8d686aeadf0d24ee83cab98ea834790831c589cf/modules/svg/image_loader_svg.cpp
@ifire:mozilla.org could you please double-check the return value of this? sw_canvas->push(move(picture));
@ifire:mozilla.org also, I'm wondering if you do not push the picture but just push the background shape, in that case draw() call is successful or not.
@ifire:mozilla.org could you please double check the above?
@ifire:mozilla.org +more question, does this problem only happened when you introduce the accessor customization calls?
and all the svg resources?
to make it sure the fail is only happened at the specific svg resources or all cases 100%.
and I used 0.6.0
@ifire:mozilla.org could you please check this request? => put some log messages to draw() //113 line, tvgCanvasImpl.h to figure out which condition fails.
some log messages to draw() //113 line, tvgCanvasImpl.h. can you write more
describe more
Result draw()
{
if (drawing || paints.count == 0 || !renderer || !renderer->preRender()) return Result::InsufficientCondition;
bool rendered = false;
for (auto paint = paints.data; paint < (paints.data + paints.count); ++paint) {
if ((*paint)->pImpl->render(*renderer)) rendered = true;
}
if (!rendered || !renderer->postRender()) return Result::InsufficientCondition;
drawing = true;
return Result::Success;
}
@ifire:mozilla.org so it fails here.
than it's not initialized.
ImageLoaderSVG::ImageLoaderSVG() {
tvg::CanvasEngine tvgEngine = tvg::CanvasEngine::Sw;
uint32_t threads = std::thread::hardware_concurrency();
if (threads > 0) {
--threads;
}
if (tvg::Initializer::init(tvgEngine, threads) != tvg::Result::Success) {
return;
}
}
tvg::CanvasEngine tvgEngine = tvg::CanvasEngine::Sw;
uint32_t threads = std::thread::hardware_concurrency();
if (threads > 0) {
--threads;
}
if (tvg::Initializer::init(tvgEngine, threads) != tvg::Result::Success) {
return;
}
}
can you double check "if (tvg::Initializer::init(tvgEngine, threads) != tvg::Result::Success) {" ??
it's successful or not
or something else...
or...,
one possibility. "THORVG_SW_RASTER_SUPPORT" define is missed,
code in godot engine has THORVG_SW_RASTER_SUPPORT undef but THORVG_SW_RASTER_SUPPORT in thorvg is defined
let me check
It's late. I'll look at it in the morning.
Will update git.
Result sync()
{
if (!drawing) return Result::InsufficientCondition;
if (renderer->sync()) {
drawing = false;
return Result::Success;
}
return Result::InsufficientCondition;
}
if canvas->draw() is failed, sync() will get the situation.
2 replies