Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Joel Oliveira
    @jayroh
    Thredded doesn’t handle any of the user management stuff - so I imagine that’s in one of your views that that is creating the error?
    if you do rake routes it should list all of the routes out and you should be able to see something like destroy_user_session or destroy_session on the left
    Andrew Brown
    @drusepth
    Might also need the main_app from https://github.com/thredded/thredded#reference-your-paths-so-that-thredded-can-find-them for the destroy_user_session_path call
    Tim Diggins
    @timdiggins
    @glebm @jayroh Hi :wave: I was just going through issues (as I'm about to add to them...) and was going to see if I could answer a few oldish ones. Would it be ok if I closed some of the ones that seem like no further action is required (e.g. thredded/thredded#727 because it's done, but probably not thredded/thredded#583 because although there's a workaround documented, it still represents an requested unimplemented feature).
    Gleb Mazovetskiy
    @glebm
    @timdiggins Hi! Thanks for all the work! I've reviewed all the PRs (all except one approved)
    thredded/thredded#583 has actually been implemented but I forgot to update the issue
    Tim Diggins
    @timdiggins
    Great. I'm assuming some of the question issues are just open "because they haven't been closed yet" -- I might go ahead and close as I see it (and then you can always reopen if I've called them wrong).
    Gleb Mazovetskiy
    @glebm
    Yes please!
    Tim Diggins
    @timdiggins
    Just looking at thredded/thredded#746.
    why .order(case_insensitive.column_for_order(:asc)) and not .order(case_insensitive.column_for_order => :asc) -- do :asc and :desc influence column choice?
    Gleb Mazovetskiy
    @glebm
    I think the latter might not work with Arel
    if we return an Arel object from that method, then it could be: .order(case_insensitive.column_for_order.asc)
    Tim Diggins
    @timdiggins
    oh, I think you do order(COLUMN_NAME => :asc) -- in active record queries (but not arel)
    but I only brought in arel, to do the .lower fudge
    Gleb Mazovetskiy
    @glebm
    For some databases case_insensitive.column_for_order won't simply be a column name (e.g. for sqlite it'll be something like Arel.sql('name COLLATE NOCASE'))
    Tim Diggins
    @timdiggins
    ah ok -- fine.
    I could have a go at doing that in db_text_search but I must say I've avoided every fully learning the word "collation" in sql
    :grin:
    Gleb Mazovetskiy
    @glebm
    All the ways to do this case-insensitive stuff are already implemented:
    https://github.com/thredded/db_text_search/tree/master/lib/db_text_search/case_insensitive
    It's just a question of exposing a new method
    Tim Diggins
    @timdiggins
    ok great
    super thanks as ever for your swift reviews and responses.
    Gleb Mazovetskiy
    @glebm
    np, i should really go outside though as it's 23 and sunny here in London :D
    Tim Diggins
    @timdiggins
    indeed -- enjoy the sun while it lasts (also in London)
    Gleb Mazovetskiy
    @glebm
    we should have a beer someday!
    free beers in my office every friday (Google @ Kings Cross)
    Tim Diggins
    @timdiggins
    :+1: :beers:
    Works for me!
    Free as in beer
    enjoy sun. give me a shout one friday
    Gleb Mazovetskiy
    @glebm
    You too!
    Tim Diggins
    @timdiggins
    @glebm can you release db_text_search at some point (I don't have perms)
    Gleb Mazovetskiy
    @glebm
    @timdiggins Will do later tonight
    Gleb Mazovetskiy
    @glebm
    @timdiggins Released v0.3.0 and added you and Joel to owners
    Tim Diggins
    @timdiggins
    thanks Gleb!
    Joel Oliveira
    @jayroh
    you two are incredible.
    I’ve been missing but this all warms the cockles of my heart to see thredded thrive
    Andrew Brown
    @drusepth
    Glad to see I wasn't the only one who missed all the action :)
    +1 for thredded joy
    Joel Oliveira
    @jayroh
    @drusepth hear, hear!
    Andrew Brown
    @drusepth
    Question -- I have tons of users clamoring for some kind of block/ignore/kick functionality for threads. I haven't thought through how it'd all work yet, but 1) this isn't something currently supported, right?; and 2) is this something that would be wanted if I were to implement & PR upstream?
    I was just thinking something along the lines of just one user blocking another to 1) hide posts (or threads if they're the OP) from either user when viewed by the other user, and 2) prevent PMs between the two users
    Gleb Mazovetskiy
    @glebm

    @drusepth For ignoring topics, there is an issue but noone is working on it: thredded/thredded#224.
    However, that issue is about manual ignoring of topics only, and not user-level mute/block like you're suggesting

    We'll be happy to accept a PR but please start with a design doc (an issue with a detailed description of this will work)

    Joel Oliveira
    @jayroh
    A detailed and specific set of user stories would be very helpful
    Andrew Brown
    @drusepth
    Awesome, will open an issue for discussion tonight to hammer out what things should look like
    Joel Oliveira
    @jayroh
    👍
    Robert Fraktar
    @fraktar
    Hello. Is this chat still active? I see the repo is being maintained.
    Joel Oliveira
    @jayroh
    It’s alive, yeah - just we’re not in here all the time )
    :)
    Robert Fraktar
    @fraktar
    @jayroh of course not, good to hear it!