These are chat archives for thunder-project/thunder

1st
Feb 2015
Jeremy Freeman
@freeman-lab
Feb 01 2015 00:40
will likely strip the detailed code examples from that site except for the bare minimum, opting to emphasize the primary thunder tutorials instead, and the example notebooks now in https://github.com/thunder-project/thunder-example-notebooks
Ben Shababo
@shababo
Feb 01 2015 00:55
@freeman-lab it might be useful to refactor out fitReference and other reference related methods as you did with transformations... i can see many methods reusing the same method (mean, max projections)
Ben Shababo
@shababo
Feb 01 2015 01:28
along those same lines, one might want to try a particular registration method but with different types of ref images
Jeremy Freeman
@freeman-lab
Feb 01 2015 10:09
@shababo great points, in the version we just pushed, the reference calculations are now wrapped into a prepare and isPrepared method, which will be specific to each subclasses (the particular registration methods). At least for CrossCorr, the abstraction allows the reference to be set directly during prepare (to, for example, use one reference for many models).
We could further abstract away the Reference operation itself, so more methods could share the same reference getting behavior, but I'd like to first understand the range of references different algorithms would need (according to Ben, some don't need it at all, which is why it's not explicitly anywhere in the base class.
Ben Shababo
@shababo
Feb 01 2015 18:04
fair enough. i tried to pull the changes you guys made yesterday but nothing is coming through? did you commit to the refactored-registration branch?
i'll see if it addresses the points i brought up before. then i can comment further.
push, not commit, sorry
Jeremy Freeman
@freeman-lab
Feb 01 2015 18:06
ah, we finished the PR and merged into master, here's the commit thunder-project/thunder@51046f2
Ben Shababo
@shababo
Feb 01 2015 19:09
oh, duh, i never setup the main repo as remote... got it... thanks.