These are chat archives for thunder-project/thunder

25th
Mar 2016
Jason Wittenbach
@jwittenbach
Mar 25 2016 21:59
@freeman-lab I’m working on moving the labels up to Data
and it strikes me that, if we define baseaxes on all subclasses of Data
then we can actually write a single very of functions like filter up on the Data class and then we don’t even need to implement them at all Series or Images
any reason not to do this?
Jeremy Freeman
@freeman-lab
Mar 25 2016 22:00
does baseaxes make sense for images?
Jason Wittenbach
@jwittenbach
Mar 25 2016 22:00
yeah, totally
it’s just (0,) for now
Jeremy Freeman
@freeman-lab
Mar 25 2016 22:00
i guess so yeah
right
Jason Wittenbach
@jwittenbach
Mar 25 2016 22:01
later, if we want to add, say, the option to have color channels or something
then it might be different for different Images objects
but for now it’s just always (0,)
do we need a wrapper of filter down on Images and Series for the documentation though?
or do you think it’s ok to just let them inheiret it form Data and have it be documented there
Jeremy Freeman
@freeman-lab
Mar 25 2016 22:02
yeah i think that's fine, if you can write the doc string for it in a general way
Jason Wittenbach
@jwittenbach
Mar 25 2016 22:02
cool
I’ll just do this for filter for now
but I think there might be a couple of other cases where we can do something similar
but I’ll leave that for a later PR =)
Jeremy Freeman
@freeman-lab
Mar 25 2016 22:03
ok cool that sounds great!
so you'll do it as part of the PR you opened with the labels stuff?
Jason Wittenbach
@jwittenbach
Mar 25 2016 22:04
yeah, just for filter
as I need to get that working with labels on both Images and Series for the label PR anyway