Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 00:36

    agnivade on master

    [TravisCI] uploaded assets afte… (compare)

  • 00:35

    ivanhercaz on master

    atom: wait for git commit edito… (compare)

  • 00:35
    ivanhercaz closed #3785
  • 00:35
    ivanhercaz commented #3785
  • 00:34
    ivanhercaz commented #3785
  • 00:33
    ivanhercaz commented #3789
  • 00:33
    ivanhercaz synchronize #3789
  • 00:32
    ivanhercaz synchronize #3789
  • 00:32
    ivanhercaz synchronize #3789
  • Jan 23 22:34
    wbollock review_requested #3793
  • Jan 23 21:14
    wbollock synchronize #3793
  • Jan 23 21:14
    wbollock synchronize #3793
  • Jan 23 20:59
    wbollock synchronize #3793
  • Jan 23 20:58
    tldr-bot commented #3793
  • Jan 23 20:57
    claassistantio commented #3793
  • Jan 23 20:57
    claassistantio commented #3793
  • Jan 23 20:56
    wbollock edited #3793
  • Jan 23 20:56
    wbollock edited #3793
  • Jan 23 20:56
    wbollock edited #3793
  • Jan 23 20:56
    wbollock opened #3793
Owen Voke
@pxgamer
Ah, always forget about FF Send
Starbeamrainbowlabs
@sbrl
Got it - thanks!
Looks like 2 of them do config, and the other one is the app itself
Owen Voke
@pxgamer
:+1: Not sure what the config stuff is. But hopefully the app installs ok.
Starbeamrainbowlabs
@sbrl
yeah!
"There was a problem while parsing the package" for the config ones
and "app not installed" for the base
worth a try at least
Owen Voke
@pxgamer
Eh; Sorry about that. Worth a try indeed.
Starbeamrainbowlabs
@sbrl
np!
Agniva De Sarker
@agnivade
Thanks for jumping in on #3755 @mebeim. I was on vacation and just got back.
Agniva De Sarker
@agnivade
I think your initial PR review was absolutely fine. It's just that our review process is indeed tiring to a lot of people. Mostly because it's just a bunch of text, and not code per-se. So folks don't take stuff that seriously. But IMO, things like "reordering" and "adding an example" are very important things, and what makes tldr pages stand out from the crowd.
Marco Bonelli
@mebeim
@agnivade 👍
Starbeamrainbowlabs
@sbrl
:+1:
Marco Bonelli
@mebeim
Guys please pay attention when reviewing. I'm noticing very poorly reviewed PRs lately: see tldr-pages/tldr#3770 and tldr-pages/tldr#3771 for example.
Both add phrases that are barely correct English and have very awkward wording. On top of that, #3770 transforms on example into another, which shouldn't be done like that, and it doesn't seem to have been noticed... :\
Please pay more attention when reviewing. You should take your time, there's no hurry, and if you don't have time don't rush a review, you can look at it later.
Also, @sbrl did you ping @zdroid on GitHub about getting here on Gitter? I don't remember.
Starbeamrainbowlabs
@sbrl
Hey, @mebeim! I don't think I've reviewed those PRs yet.
No I didn't I'll do it now.
Marco Bonelli
@mebeim
#3771 is probaly ok as is, I did the last review. #3770 needs to be clarified though, we should make sure why was the example removed and also correct the english on the added examples
Starbeamrainbowlabs
@sbrl
Marco Bonelli
@mebeim
:+1:
Zlatan Vasović
@zdroid

@zdroid is gaining on me in my notifications list lol

what did you mean by this?

@sbrl
Marco Bonelli
@mebeim
Not much, just that @sbrl had a significant number of notifications from you on GH :)
Zlatan Vasović
@zdroid
It's two-sided, @sbrl spams my notifications as well :p
Marco Bonelli
@mebeim
By the way, haven't had a chance to say it, but thanks for all the PRs/Issues you took time to open/review/comment on lately. Nice job @zdroid :)
Lucas Gabriel Schneider
@schneiderl

@zdroid Hi,
About #3773, I'm unsure I understood the problem here.
As far as I understood, Serbian is a language used by Serbs, while Croatian is used in Croatia, Bosnia and Herzegovina, etc.
Serbo-Croatian is the language that they derive from.

Are Serbian and Croatian that different from Serbo-Croatian? and from each other?

Also, ISO639-2 does not seem to include anything like Serbo-Croatian, which lead me to think we should label as Serbian and Croatian.
Starbeamrainbowlabs
@sbrl
Hey there, @zdroid! I just meant that I had a lot of GH notifications from you - and since I like to sit down and deal with all my notifications at once, when we are on GH at the same time I end up not getting to the end of the list :P
Zlatan Vasović
@zdroid
@sbrl Same problem here, whenever I refresh the page another one appears :D @mebeim thanks
Starbeamrainbowlabs
@sbrl
Lol :P
Zlatan Vasović
@zdroid
@schneiderl It's more of a political issue
Starbeamrainbowlabs
@sbrl
Also, just a quick note: Since I hang out in here regularly @zdroid I won't always have seen / reviewed PRs recently-ish
If there's something urgent you're welcome to bring it to my attention here
Zlatan Vasović
@zdroid
Standard varieties of Serbian/Croatian/Bosnian have been united throughout Yugoslavia's existence, but they were split in 90s and 00s
Starbeamrainbowlabs
@sbrl
But right now I've had a busy and I'm just chilling for a it - I'll prob. get to GH some time tomorrow
Iván Hernández Cazorla
@ivanhercaz
@mebeim Excuse me a lot! Fast reviews. I will be more cautious before to review and approve them.
Marco Bonelli
@mebeim
@ivanhercaz it's ok, it can happen :) and thank you
Iván Hernández Cazorla
@ivanhercaz
@mebeim Then I read the another reviews and note my fault of appreciation. I must think more before to review. I try to do it in my free time, but sometimes in the bus or waiting for something, I rush erroneously.
Marco Bonelli
@mebeim
Yeah there's no rush, you can always get back at it later :)
Agniva De Sarker
@agnivade
Hello @zdroid - regarding https://github.com/tldr-pages/tldr/issues/3782#issuecomment-577440868, we had decided not to immediately close issues by ourselves and let the contributor come back and close it by themselves. If they don't respond by a week or so, it is okay to close it by ourselves.
Zlatan Vasović
@zdroid
I understood that, but it was a quite simple request after all
dpkg page already exists
Starbeamrainbowlabs
@sbrl
True, but it's about the contributor's experience I think is what @agnivade is trying to get at @zdroid - even if it's obvious to us at the time that it needs to be closed
Agniva De Sarker
@agnivade
Yes, correct. Even if it's dead simple and should absolutely be closed. For example client related bugs. Even then, we should let the author close it rather than closing it ourselves. This is just to be extra polite and be welcoming as a community.
FWIW, it was @waldyrious who came up with this idea. Not me :)
Starbeamrainbowlabs
@sbrl
:+1:
Zlatan Vasović
@zdroid
Alright. Btw, @sbrl check tldr-pages/tldr#3773 again