Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 10:12
    navarroaxel edited #5164
  • 10:07
    navarroaxel labeled #5165
  • 04:20
    opoet777 edited #5165
  • 04:20
    opoet777 edited #5165
  • 04:20
    opoet777 edited #5165
  • 04:20
    opoet777 edited #5165
  • 04:20
    opoet777 edited #5165
  • 04:20
    opoet777 opened #5165
  • 03:52
    ysl2 closed #152
  • 03:01
    CLAassistant commented #5164
  • 03:01
    yangvw opened #5164
  • 02:57
    GingkathFox opened #5163
  • Jan 19 21:42
    bl-ue commented #3953
  • Jan 19 21:12
    navarroaxel review_requested #5148
  • Jan 19 20:56
    schneiderl commented #5148
  • Jan 19 20:51

    schneiderl on schneiderl-style_guide_technical_syntax

    remove keyboard shortcuts from … (compare)

  • Jan 19 20:51
    schneiderl synchronize #5128
  • Jan 19 20:49
    schneiderl ready_for_review #5119
  • Jan 19 20:49
    schneiderl commented #5119
  • Jan 19 20:47
    schneiderl synchronize #5119
Starbeamrainbowlabs
@sbrl
...including mass changes
Waldir Pimenta
@waldyrious
@bl-ue btw that's why I sometimes take longer to address issues/PRs where I'm pinged — often it's because I expect it may take me a long time to do a thorough review and add my input properly.
I understand (and appreciate!) your eagerness, but please bear with those of us who can't always keep up with your rhythm ;)
bl-ue
@bl-ue
@sbrl you must see #5128
@waldyrious okay, I will! :)
waldyrious
@waldyrious:matrix.org
[m]
:)
Owen Voke
@owenvoke:matrix.org
[m]
Yeah, I think it's better to review things correctly and take your time, rather than rushing. But I do appreciate the eagerness, it's definitely nice to have people thoroughly onboard with this project!
Starbeamrainbowlabs
@sbrl
Thanks for that, @bl-ue. I hadn't got to that one yet. Left a comment.
waldyrious
@waldyrious:matrix.org
[m]
*comment 😄
Starbeamrainbowlabs
@sbrl
Yep, *comment lol
edited my comment there, but it looks like that didn't transfer to matrix.
waldyrious
@waldyrious:matrix.org
[m]
It did, maybe not fast enough :) when I wrote my previous message it was still displaying as "command" (which is a hilariously appropriate typo btw!)
Starbeamrainbowlabs
@sbrl
lol
:P
navarroaxel
@navarroaxel:matrix.org
[m]
What should we do with non-standard arguments for tldr command?
tldr-pages/tldr#5148
Starbeamrainbowlabs
@sbrl
I'm not sure we can accept edits to tldr that don't conform with the client spec
Starbeamrainbowlabs
@sbrl
Uhhhh @owenvoke, I think the GitHub action broke in tldr-pages/tldr#5153
Owen Voke
@owenvoke:matrix.org
[m]
Oh, looks like it's not under an OS directory.
So the GH action was trying to cd into the page I think.
Starbeamrainbowlabs
@sbrl
Oh, did I put the file in the wrong place? oops
I thought I put it under linux, but I guess not
Fixed!
thanks :D
navarroaxel
@navarroaxel:matrix.org
[m]
I think we can add arguments not listed in the tldr specs.
Why not add --render as optional in the specs only to have the same name in all CLI clients?
Starbeamrainbowlabs
@sbrl
Clients can certainly support such arguments, but I really don't think including them in the official tldr tldr page is wise, as everyone will expect them to work, regardless of the client they are using
and we'll get endless bug reports claiming it doesn't work for them
navarroaxel
@navarroaxel:matrix.org
[m]
But not all the clients support cache and the tldr page said that. Is not the same scenario?
Starbeamrainbowlabs
@sbrl
That's different. The cache is in the client spec
bl-ue
@bl-ue
It must have been satisfying to approve and merge 4 PRs, @navarroaxel! :)
1 reply
itldr
@itldr
If there is Chinese in MD file, there will be garbled code. How to deal with it?
Marco Bonelli
@mebeim
Hi, @itldr not sure I follow you, what is the issue exactly?
Are you trying to display Chinese pages in your terminal and they do not show appropriately?
itldr
@itldr
yes
Marco Bonelli
@mebeim
Which client are you using?
If you are able to display Chinese text in your terminal and only tldr pages show incorrectly, then it's probably an issue of the client.
itldr
@itldr
Local pull a copy of the code, local testing found, using tldr-pages
Marco Bonelli
@mebeim
Or did you just clone tldr-pages/tldr?
itldr
@itldr
Is when there is Chinese in the md file, tldr-pages input specific command return the result will be garbled
clone tldr-pages/tldr tldr.jsx
Marco Bonelli
@mebeim
Yes, I understood that. What I'm trying to understand is how exactly you are displaying the pages. Which command are you using?
itldr
@itldr
I displayed it on my GitHub Pages, Touch. md. I typed it in Chinese, and then the page typed in Touch and the Chinese was scrambled
Marco Bonelli
@mebeim
Oh I see. So you forked this client https://github.com/ostera/tldr.jsx
itldr
@itldr
yes yes
Marco Bonelli
@mebeim
So if the Chinese pages are not correctly displayed using that client you should open an Issue there: https://github.com/ostera/tldr.jsx/issues
itldr
@itldr
thanks very very much
Marco Bonelli
@mebeim
You're welcome :)
Anton Karmanov
@bergentroll
@sbrl, continuing the conversation with @bl-ue , may I say the convention to pass closing slash in directory paths seems unreasonable (/etc/ vs /etc)? I believe it is good practice to put keep slash because it reveals that a path is a directory, not a file and also it prevents errors on concatenation, because multiple slashes is not an error (/foo///bar// is a valid system path). Also I see no what can become broken if convention will be changed.
Waldir Pimenta
@waldyrious
Those are good points, @bergentroll. I have no objection to adopt the convention you propose, unless further arguments come up. :+1: