Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    sssjjjnnn
    @sssjjjnnn
    Makes sense
    Curt J. Sampson
    @0cjs
    Some people may find it confusing that you put a whole bunch of "WIP" commits on master; normally WIP means "this commit should never go on master branch".
    sssjjjnnn
    @sssjjjnnn
    Ah, forgot about those
    Curt J. Sampson
    @0cjs
    Generally I do a quick read-through of all the commits I'm about to put on master before I do it, just to make sure they make sense, squash the "make mistake - do something else -fix previous mistake" commits, make sure the commits have explanations useful to others, and the like.
    sssjjjnnn
    @sssjjjnnn
    Do you want me to squash those?
    Curt J. Sampson
    @0cjs
    Yeah, I'd say go do a cleanup-pass and force-push it. Nobody's likely to have the new version for a while yet.
    Ah, and if you also find a minor typo or something in the compiled site that could be fixed in the new version, that will also force a new commit to be built for the release branch, so the ID in that commit message will match a commit that still exists after the current one is not on any branches any more.
    Curt J. Sampson
    @0cjs
    There are also commits where the message makes it appear as if the change does nothing, but in fact the site is broken in a major but non-obvious way without it, such as d790d918d407c9fe2a. (The details of that are in the netlify-test repo.) I think it would be worth tweaking the message on any of those you notice, so we don't get someone a year from now saying "I disagree with that obvious aesthetic decision" and breaking the site.
    Or hm, does that commit still leave the site broken, or maybe even break it? I don't even remember now! My guess is that the site is broken both before and after that commit?
    sssjjjnnn
    @sssjjjnnn
    According to the info in netlify-test, it should be uppercase, but the last commit in the tlug.jp repo was lowercase
    Curt J. Sampson
    @0cjs
    Sounds like it's wrong in tlug.jp, then. It can be confirmed by testing with curl; I think I explained how to do that in netlify-test. It looks like there may be enough stuff to be fixed on this branch that it might be worth just rolling it back to the previously released commit, re-releasing that, and then doing a pass to go through and fix things.
    If you just grabbed all of Ed's commits, you definitely got a bunch of comits that were simply experiments on his part.
    sssjjjnnn
    @sssjjjnnn
    I just fixed the tlug.jp to be uppercase as per netlify-test. But the current site, which is what I deployed before with lowercase doesn't seem to be sending me two headers
    I also updated master, see if that looks better
    Curt J. Sampson
    @0cjs
    It could be that Netlify has already fixed the case bug that was causing the multiple headers. I put in a bug report for it, though I don't know if it's publicly available. (I don't recall if I also posted it to https://community.netlify.com.) You could find out by deploying the netlify-test site (it may already be deployed in the TLUG account) and checking the three URLs there to see if any of them are still returning duplicate headers. (EDIT: Ah, yes, I think it should be up now on https://tlug-netlify-test.netlify.com/ .)
    sssjjjnnn
    @sssjjjnnn
    Wiki pages are returning two headers
    CSS and index.html are okay
    I see, that header is only for wiki/*
    Well, let's try uppercase
    Curt J. Sampson
    @0cjs
    Yeah, that's the bug. master branch looks good now, and the Content-Type fix has a good explanation. Is that not actually working? What about the headers from https://tlug-netlify-test.netlify.com/content-type/{lower,mixed,upper}?
    sssjjjnnn
    @sssjjjnnn
    Haven't deployed it yet
    Just did it
    Curt J. Sampson
    @0cjs
    Well, if Netlify hasn't fixed the bug (which they didn't seem they were going to get around to doing quickly) we'd expect the deployment from the previous commit to be broken.
    sssjjjnnn
    @sssjjjnnn
    It was, wiki pages had two content-types. The new deploy fixes it
    Curt J. Sampson
    @0cjs
    Great! So yeah, that new branch is a massive improvement in terms of commit messages, etc.
    Thanks for doing all that heavy lifting. I'm still more or less incapacitated with headaches and lethargy.
    BTW, I don't know if you saw the message, but we can get that TLUG netlify account turned into a free "Pro" account if we're willing to put a "hosted by Netlify" thing on our pages somewhere. I will post to tlug-admin@tlug.jp about this on the weekend or early next week.
    sssjjjnnn
    @sssjjjnnn
    That's what we did with Asahi.net, so seems reasonable
    sssjjjnnn
    @sssjjjnnn
    A _cache directory just appeared in my tlug.jp workspace, generating the site seems to produce it. Do you know what that could be for? Does it need to be deployed with _site?
    sssjjjnnn
    @sssjjjnnn
    Hakyll says it's only used internally, so I guess I'll gitignore it
    Already ignored...
    Curt J. Sampson
    @0cjs
    Something's wrong if it's not already ignored.
    sssjjjnnn
    @sssjjjnnn
    I ran build int he wrong dir, and it created a _cache there
    Curt J. Sampson
    @0cjs
    Broken build script! Fire the developer!
    sssjjjnnn
    @sssjjjnnn
    Before I get fired, I'm going to push some code to handle wiki redirects and put something in the current meeting links
    Curt J. Sampson
    @0cjs
    That's probably my code, actually. I guess that somewhere in Test~ between thecd "$basedir"and runningstack` it changes the directory again. But I don't see how....
    sssjjjnnn
    @sssjjjnnn
    I was running the site-compiler manually
    Test script is probably fine
    Curt J. Sampson
    @0cjs
    Oh, yeah, then that's your problem.
    sssjjjnnn
    @sssjjjnnn
    I think a lot of that Haskell code could be written in a better way, but I'm not sure how. Maybe we can go over it a bit when you're feeling better
    It took me forever to turn the >>= into a do block
    Curt J. Sampson
    @0cjs
    Yes, I'd like to do that.
    sssjjjnnn
    @sssjjjnnn
    Should we turn on https now that the domain is pointing to Netlify?
    Curt J. Sampson
    @0cjs
    Getting started with that would probably be a good idea. I don't think it's as simple as just flipping a switch in the Netlify control panel.
    sssjjjnnn
    @sssjjjnnn
    Should I flip the switch and see what happens?
    The button is right there staring at me tempting me to push it
    Curt J. Sampson
    @0cjs
    Have you read the docs?
    If not, well, what could go wrong? Do it! :-)
    sssjjjnnn
    @sssjjjnnn
    I'm reading something that says "We’re ready to provision a TLS certificate from Let’s Encrypt and install it on our CDN."