Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Ryan Levick
    @rylev
    Totally cool to merge it like it is
    Jon Gjengset
    @jonhoo
    Oh, you're thinking of moving Reading into its own struct, and then make ReadExact(Option<Reading>)
    yeah, that'd work too
    Ali Shirvani
    @alishir
    sorry for interruption, tokio-minihttp is using tokio-service and tokio-proto and both of these repositories are archived. Are tokio-service and tokio-proto out dated?
    Jon Gjengset
    @jonhoo
    would introduce an extra type, but that might not matter.
    Toby Lawrence
    @tobz
    @alishir tokio-minihttp is just an example repo, not a project
    so it's effectively deprecated/archived
    Carl Lerche
    @carllerche
    @alishir it could be interesting to rebuild tokio-minihttp using @jonhoo’s tokio-tower
    but, tokio-minihttp is just a demo / example
    hyper is the way to do HTTP w/ Tokio
    Jon Gjengset
    @jonhoo
    Ali Shirvani
    @alishir
    I want to implement sip server with tokio and I'm looking for an example, I read in tokio-minihttp readme that it is an example to implement network protocol with tokio so I decided to start from reading it's source but it is deprecated, also hyper seem too complex for start
    It would be appreciated if you guide me how should I start implementing sip protocol with tokio, sip is very similar to http
    Carl Lerche
    @carllerche
    @alishir there is also the tiny http example :) https://github.com/tokio-rs/tokio/blob/master/examples/tinyhttp.rs
    Ali Shirvani
    @alishir
    @carllerche thanks a lot, and what about scalability? How should I handle large number of requests?
    Carl Lerche
    @carllerche
    just run it with tokio::run should be enough
    that spreads the load across many cores
    Ali Shirvani
    @alishir
    image.png
    Hi there does search box works? I try it multiple times, it seems it doesn't work.
    Eliza Weisman
    @hawkw
    anyone @here interested in giving the tokio-trace docs a quick proofreading? feel free to leave any feedback on the PR: tokio-rs/tokio#827
    Stjepan Glavina
    @stjepang
    @hawkw Sure, reading the docs now...
    Jon Gjengset
    @jonhoo
    not sure if someone already posted this here, but https://jsdw.me/posts/rust-asyncawait-preview/ seems like a great thing to include somewhere in the tokio docs!
    Lucio Franco
    @LucioFranco
    I was actually thinking of writing some docs on async/await akin to that but more update since there have been a few changes to futures-preview etc
    Eliza Weisman
    @hawkw
    @stjepang thanks so much for your tokio-trace review btw!
    Stjepan Glavina
    @stjepang
    @hawkw You're welcome, and thanks for answering all my questions :)
    Eliza Weisman
    @hawkw
    it was a very thoughtful review!
    (this is not docs-blitz-related but: thank you so much for noticing that Span::close behavior was incorrect, too)
    Stjepan Glavina
    @stjepang
    Glad it helps, let me know if there's anything else I should take a look at!
    Eliza Weisman
    @hawkw
    :thumbsup: well, if there’s anything else that stands out to you I’d love to hear your thoughts, but hopefully nothing else like that slipped past me. :)
    Yannick Heinrich
    @yageek
    I just discovered the blog post about how to improve the documentation. It is improving compared to the first day but some details are still missing. I just read the « Tasks » session in the « Going deeper » part. At the end, two strategies are described to handle incoming sockets. May be some more details about the runtime behaviors could be provided, like exposing pros and cons. Moreover, it could be great to precise the runtime differences between spawning futures and conposing futures.
    mziter
    @mziter
    Hi, all! New to rust and figured I could assist with documentation. Just found an issue with Hello, World example and added to an existing issue: tokio-rs/doc-push#73 wondering if: 1) someone can confirm same issue 2) Can I update docs myself
    mziter
    @mziter
    Went ahead and created pull request with proposed change: tokio-rs/website#283
    mziter
    @mziter
    Hmm... looked more into my issue. Seems I had an old GNU version of netcat, which has different options.
    uninstalled and installed ncat version with nmap package on Arch Linux. That worked with current docs, but is different command name ncat not nc
    Lucio Franco
    @LucioFranco
    👍👍 yeah I’ve seen others run into the same issue
    mziter
    @mziter
    maybe i should propose a warning box or something similiar to that section?
    Updated finding on issue: tokio-rs/doc-push#73 would like to hear others thoughts. My issue was that that I was getting connection refused, which would potentially put users off. Maybe a warning or info about potential error and/or version conflicts
    Lucio Franco
    @LucioFranco
    Sure I think as a note that is fine
    mziter
    @mziter
    @LucioFranco , just for future reference, for something like this is, is it OK to make change immediately and discuss in PR or should I create/update an issue first?
    Lucio Franco
    @LucioFranco
    go for a PR! no need for an issue unless its a more controversial issue
    mziter
    @mziter
    Had to step away for a while. Submitted PR for new change: tokio-rs/website#284
    Bhargav
    @bIgBV
    I'm going through the documentation and was wondering if there is a reason why the examples don't use the 2018 edition.
    And if it is okay to open PRs with the examples changed to use the 2018 edition :)
    Carl Lerche
    @carllerche
    @bIgBV that is fine. I think some were updated
    Jon Gjengset
    @jonhoo
    I think it's a great idea!
    Carl Lerche
    @carllerche
    would appreciate PRs to convert the rest :+1:
    jonhoo @jonhoo would love PRs to convert the rest :heart:
    Jon Gjengset
    @jonhoo
    :joy:
    Lucio Franco
    @LucioFranco
    PRs welcome
    Mihail Malo
    @qm3ster
    :potato: