Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Lucio Franco
    @LucioFranco
    @hawkw so the second thing you may know is that when I use vector[source] to filter all logs that are in the source span I get logs for tokio_threadpool etc
    Eliza Weisman
    @hawkw
    yeah, that’s the current behavior for that kind of filter
    it enables everything in a span called source that has target vector
    Lucio Franco
    @LucioFranco
    but
    Eliza Weisman
    @hawkw
    we might want to change that to enable everything that has target vector and is in a span called soruce
    Lucio Franco
    @LucioFranco
    tokio_threadpool isnt vector?
    yeah
    well the other thing
    image.png
    none of them have the span...
    Eliza Weisman
    @hawkw
    right, it matches the span with name source and target vector
    yeah, that’s what’s weird to me
    Bhargav
    @bIgBV
    @hawkw no problem
    Eliza Weisman
    @hawkw
    @LucioFranco if you change that filter to just vector rather than vector[source] you don’t see the threadpool events, right?
    oh what happens if you don’t have the rate-limit layer?
    Lucio Franco
    @LucioFranco
    yeah
    @hawkw still seeing threadpool logs
    Eliza Weisman
    @hawkw
    huh. weird. there should have been a fix for this in subscriber 0.1.2?
    Lucio Franco
    @LucioFranco
    what was teh fix?
    Eliza Weisman
    @hawkw
    @LucioFranco https://github.com/tokio-rs/tracing/commit/520e4eba4ee56fd549fe0a239cd66d1ac6eda555#diff-e620c0045da1f9b6caf8af35e9ae2974
    Lucio Franco
    @LucioFranco
    @hawkw ok since I assume you're in meetings today, ill pull that locally and debug
    Eliza Weisman
    @hawkw
    that should be in the release?
    you should already have this
    Lucio Franco
    @LucioFranco
    right
    just verified im on the lastest
    so not sure why this isnt working?
    Eliza Weisman
    @hawkw
    it’s…probably something else
    Lucio Franco
    @LucioFranco
    if you point me to what you think I can debug/etc
    Eliza Weisman
    @hawkw
    add dbg!s to the filters after they’re parsed
    add printlns/debugs to register_callsite and enabled in the Layer impl for `filter
    Lucio Franco
    @LucioFranco
    This message was deleted
    Lucio Franco
    @LucioFranco
    yeah, running into patching issues, im gonna move on.
    but happy to look into it more when you have sometime @hawkw
    so prob after denver
    Eliza Weisman
    @hawkw
    okay, i’ll look at it when i have a chance
    i would recommend using .cargo/config overrides for that kind of thing
    rather than patching
    Lucio Franco
    @LucioFranco
    I always forget how to use that
    yeah, I can try that a bit later
    Lucio Franco
    @LucioFranco
    @hawkw @jonhoo if any of you have a moment to review tower-rs/tower#348 we could use it in vector
    I wanted to get yalls opinion since you have a more concrete idea on what tracing should look like in tower
    Eliza Weisman
    @hawkw
    seems fine to me
    could be good to know how long it’ll sleep but /shrug
    Lucio Franco
    @LucioFranco
    cool @hawkw I just wanna make sure this doesn't affect any of the changes you might be planning
    if this is alright we may go ahead and add some more tracing statements
    and release a patch
    Eliza Weisman
    @hawkw
    please do
    Lucio Franco
    @LucioFranco
    :+1: cool
    Eliza Weisman
    @hawkw
    we can always change ‘em later
    Lucio Franco
    @LucioFranco
    awesome