maroider on master
Fix possible panic on Windows f… (compare)
furiouzzEvery cross-platform project are kind of plumbing haha
UndeadLeech on FreenodeIt seems like
Noneis equal to
est31 on Freenodegood point
est31 on Freenodebut even then you can have an LTS that you accept bugfixes for and some experimental but proper releases with removed support
UndeadLeech on FreenodeI've considered this myself before and I don't think it would be acceptable to make any official release that removes support for a platform that was previously working just fine.
UndeadLeech on FreenodeThat's a massive red flag imho, while pre-releases are just fine.
heeen on Freenodecan someone help me with the two fixmes here https://gist.github.com/heeen/9e36b28f4251a84c5f1a1411044231a2
heeen on Freenodethis is adapted from ash's example code
UndeadLeech on FreenodeThe
borrow_mut()looks problematic. Have you tried without that?
heeen on Freenodeuhm
heeen on Freenodeevent_loop is of type RefCell<EventLoop>
heeen on Freenodeit doe snot have run
heeen on Freenodeno?
UndeadLeech on FreenodeOh, sorry. I expected the event loop to be owned.
UndeadLeech on FreenodeWhich raises the question, why is it not?
heeen on Freenodemaybe it could be owned
UndeadLeech on FreenodeI'd assume that would fix the error.
heeen on FreenodeI don't know. I'm a rust beginner, really, coming from c++
UndeadLeech on FreenodeTry removing the
RefCellin the event_loop struct type and then the
UndeadLeech on FreenodeThen it should work.
heeen on Freenodebecause at older winit was just not delivering window events in time or at all
UndeadLeech on FreenodeI'm not sure who ash is.
UndeadLeech on FreenodeUnless you're talking about pokemon that is.
heeen on Freenodeok, that seems to work so far. not sure if the full example will still work though.
heeen on Freenodethanks.
heeen on Freenodethe second fixme is about the F parameter not living long enough
heeen on Freenodeshould it be +'static?
UndeadLeech on FreenodeI don't see why it wouldn't.
UndeadLeech on FreenodeBy which I mean I don't immediately see why the events_loop is in a refcell in the example.
heeen on Freenodeactually, no it does not work
heeen on Freenodeannot move out of
self.event_loopwhich is behind a shared reference
heeen on Freenodewithout the refcell
UndeadLeech on FreenodeThe method will never return anyways.
gentz> gentz, do you know how
with_hardware_acceleration(None)should behave on macOS? Under which circumstances would that accelerate?
Nonewould mean don't care, so I guess it might give no hardware acceleration? It should probably prefer to hardware accelerate, but like, I don't know anything about the MacOS backend, so /shrug
furiouzzstdweb features does already work on winit? https://github.com/rust-windowing/winit/issues/944#issuecomment-575991946
gentzbtw, I'd check if master builds, if so, the gamepad branch probably needs a rebase
furiouzzI made a pull request to the instant repos and the author accepted. But I saw that on the master branch, we removed the Hash Trait on Event in event.rs