Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 01 12:48
    codewiz opened #1349
  • Feb 13 00:48
    markfirmware commented #1348
  • Feb 11 20:38
    bertin0 commented #1188
  • Feb 11 20:37
    bertin0 commented #1188
  • Feb 11 19:35
    markfirmware opened #1348
  • Feb 10 19:33
    notdanilo commented #1347
  • Feb 09 23:40
    notdanilo opened #1347
  • Jan 31 04:18
    bschwind commented #1330
  • Jan 19 10:45
    LoganDark commented #1340
  • Jan 11 11:18
    13k commented #984
  • Jan 10 16:06
    chrisduerr commented #984
  • Jan 10 15:27
    13k commented #984
  • Jan 01 01:10
    michaelkirk opened #1346
  • Dec 28 2020 17:01

    murarth on master

    Fix broken link in documentatio… (compare)

  • Dec 28 2020 17:01
    murarth closed #1345
  • Dec 28 2020 04:14
    atsheehan opened #1345
  • Dec 10 2020 23:45

    kchibisov on v0.26.0

    (compare)

  • Dec 10 2020 23:44

    kchibisov on master

    Release version 0.26.0 (compare)

  • Dec 10 2020 23:44
    kchibisov closed #1344
  • Dec 10 2020 19:23
    chrisduerr review_requested #1344
matrixbot
@matrixbot
kchibisov on Freenode Just don't do it in WindowBuilder.
matrixbot
@matrixbot
kchibisov on Freenode Kai Mast: rust-windowing/winit#1744
kchibisov on Freenode UndeadLeech: are you reviewing Wayland PRs or not, since you've mentioned that you don't.
kchibisov on Freenode Just ensuring.
UndeadLeech on Freenode I'd rather not test it, but I probably can look at a bit of the code.
UndeadLeech on Freenode Especially if it's so trivial like the PR you've just sent.
kchibisov on Freenode I mean, I don't ask for testing :P
UndeadLeech on Freenode Well it should be tested.
kchibisov on Freenode Just source level.
kchibisov on Freenode I mean I always test it.
UndeadLeech on Freenode Yeah, but people make mistakes.
kchibisov on Freenode Yeah, I guess.
matrixbot
@matrixbot
kchibisov on Freenode But I mean, I don't have anything to send new functionality wise.
kchibisov on Freenode Since everything is kind of 'there'.
UndeadLeech on Freenode It's usually a good idea to double-check. Harder to slip things by two people too, the second person might test things a little differently covering things more thoroughly.
UndeadLeech on Freenode Of course I'm aware of the issue with lack of testers.
UndeadLeech on Freenode Generally I'd advice to ping Wayland testers and give them at least 24h. And if people regularly don't show up, remove them from the list of testers.
UndeadLeech on Freenode Not out of malice, just because it doesn't benefit anyone to have a list of testers where nobody is interested in testing.
kchibisov on Freenode Yeah, but the thing is that I don't have anything that I can impl in Wayland backend right now.
kchibisov on Freenode So the only things that can show up is purely source level bugs or something like that.
UndeadLeech on Freenode And bugs should be independently verified by two people.
kchibisov on Freenode Kai Mast: the fix for your bug got merged.
kchibisov on Freenode UndeadLeech: I guess,
UndeadLeech on Freenode Anything that changes the behavior of winit, should be tested by at least two people.
UndeadLeech on Freenode And if the capacity doesn't exist, it should be made transparent in the testers list.
matrixbot
@matrixbot
UndeadLeech on Freenode I mean if two people tested the original code, it might not have existed in the first place.
kchibisov on Freenode That's true, but the only way I can change the winit behavior is adding new things, which I can't, because I've added everything I possible can for Wayland backend.
UndeadLeech on Freenode Fixing bugs changes the behavior of winit.
kchibisov on Freenode UndeadLeech: the original code was tested by more than just me.
UndeadLeech on Freenode The only changes that do not impact the behavior of winit are style changes.
UndeadLeech on Freenode kchibisov: It's not a guarantee of course.
kchibisov on Freenode Yeah, this is one is a bit wierd, since you should min/max size in window builder.
UndeadLeech on Freenode I mean I'm not much of a winit maintainer, so I don't have much to say. But I would never allow any Alacritty PR that changes anything in the code without being tested by at least two people.
kchibisov on Freenode And this thing is pretty rare to happen, since there's
kchibisov on Freenode since there's no real value in setting those things unless you're writing some 'special' application.
kchibisov on Freenode Like you want to start your window in floating mode.
kchibisov on Freenode UndeadLeech: are you counting the original author or are you counting only testers?
UndeadLeech on Freenode At least one person besides the original author.
matrixbot
@matrixbot
kchibisov on Freenode Ah, how convinient.
UndeadLeech on Freenode The same way we do it in Alacritty.
kchibisov on Freenode It just happend that there's always two ppl to test every patch in alacritty.
UndeadLeech on Freenode Yeah and according to the list of testers in winit there should be more than two people capable of testing Wayland patches.
kchibisov on Freenode The thing with Wayland, that proper PRs testing is very hard, since you should check like 4 compositors.
kchibisov on Freenode And verify that something strange you're seeing is compositor bug.
kchibisov on Freenode Most of the time that's true for GNOME.
matrixbot
@matrixbot
kchibisov on Freenode But yeah, for something more complex than this one liner, I'd ping folks and wait for day or two.
UndeadLeech on Freenode Perfect is the enemy of good. Merging PRs without any second party verifying them because "testing correctly is difficult" is not exactly constructive.
UndeadLeech on Freenode Once you have people verify things on at least one compositor, you can think about having multiple tested.
kchibisov on Freenode I mean if they verify on GNOME it's hard to say anything.
UndeadLeech on Freenode Why?