murarth on master
Fix broken link in documentatio… (compare)
kchibisov on v0.26.0
kchibisov on master
Release version 0.26.0 (compare)
kchibisov on FreenodeUndeadLeech: are you reviewing Wayland PRs or not, since you've mentioned that you don't.
kchibisov on FreenodeJust ensuring.
UndeadLeech on FreenodeI'd rather not test it, but I probably can look at a bit of the code.
UndeadLeech on FreenodeEspecially if it's so trivial like the PR you've just sent.
kchibisov on FreenodeI mean, I don't ask for testing :P
UndeadLeech on FreenodeWell it should be tested.
kchibisov on FreenodeJust source level.
kchibisov on FreenodeI mean I always test it.
UndeadLeech on FreenodeYeah, but people make mistakes.
kchibisov on FreenodeYeah, I guess.
kchibisov on FreenodeSince everything is kind of 'there'.
UndeadLeech on FreenodeIt's usually a good idea to double-check. Harder to slip things by two people too, the second person might test things a little differently covering things more thoroughly.
UndeadLeech on FreenodeOf course I'm aware of the issue with lack of testers.
UndeadLeech on FreenodeGenerally I'd advice to ping Wayland testers and give them at least 24h. And if people regularly don't show up, remove them from the list of testers.
UndeadLeech on FreenodeNot out of malice, just because it doesn't benefit anyone to have a list of testers where nobody is interested in testing.
kchibisov on FreenodeYeah, but the thing is that I don't have anything that I can impl in Wayland backend right now.
kchibisov on FreenodeSo the only things that can show up is purely source level bugs or something like that.
UndeadLeech on FreenodeAnd bugs should be independently verified by two people.
kchibisov on FreenodeKai Mast: the fix for your bug got merged.
kchibisov on FreenodeUndeadLeech: I guess,
UndeadLeech on FreenodeAnything that changes the behavior of winit, should be tested by at least two people.
UndeadLeech on FreenodeAnd if the capacity doesn't exist, it should be made transparent in the testers list.
kchibisov on FreenodeThat's true, but the only way I can change the winit behavior is adding new things, which I can't, because I've added everything I possible can for Wayland backend.
UndeadLeech on FreenodeFixing bugs changes the behavior of winit.
kchibisov on FreenodeUndeadLeech: the original code was tested by more than just me.
UndeadLeech on FreenodeThe only changes that do not impact the behavior of winit are style changes.
UndeadLeech on Freenodekchibisov: It's not a guarantee of course.
kchibisov on FreenodeYeah, this is one is a bit wierd, since you should min/max size in window builder.
UndeadLeech on FreenodeI mean I'm not much of a winit maintainer, so I don't have much to say. But I would never allow any Alacritty PR that changes anything in the code without being tested by at least two people.
kchibisov on FreenodeAnd this thing is pretty rare to happen, since there's
kchibisov on Freenodesince there's no real value in setting those things unless you're writing some 'special' application.
kchibisov on FreenodeLike you want to start your window in floating mode.
kchibisov on FreenodeUndeadLeech: are you counting the original author or are you counting only testers?
UndeadLeech on FreenodeAt least one person besides the original author.
UndeadLeech on FreenodeThe same way we do it in Alacritty.
kchibisov on FreenodeIt just happend that there's always two ppl to test every patch in alacritty.
UndeadLeech on FreenodeYeah and according to the list of testers in winit there should be more than two people capable of testing Wayland patches.
kchibisov on FreenodeThe thing with Wayland, that proper PRs testing is very hard, since you should check like 4 compositors.
kchibisov on FreenodeAnd verify that something strange you're seeing is compositor bug.
kchibisov on FreenodeMost of the time that's true for GNOME.
UndeadLeech on FreenodePerfect is the enemy of good. Merging PRs without any second party verifying them because "testing correctly is difficult" is not exactly constructive.
UndeadLeech on FreenodeOnce you have people verify things on at least one compositor, you can think about having multiple tested.
kchibisov on FreenodeI mean if they verify on GNOME it's hard to say anything.
UndeadLeech on FreenodeWhy?