murarth on master
Fix broken link in documentatio… (compare)
kchibisov on v0.26.0
kchibisov on master
Release version 0.26.0 (compare)
kchibisov on FreenodeUndeadLeech: I guess,
UndeadLeech on FreenodeAnything that changes the behavior of winit, should be tested by at least two people.
UndeadLeech on FreenodeAnd if the capacity doesn't exist, it should be made transparent in the testers list.
UndeadLeech on FreenodeI mean if two people tested the original code, it might not have existed in the first place.
kchibisov on FreenodeThat's true, but the only way I can change the winit behavior is adding new things, which I can't, because I've added everything I possible can for Wayland backend.
UndeadLeech on FreenodeFixing bugs changes the behavior of winit.
kchibisov on FreenodeUndeadLeech: the original code was tested by more than just me.
UndeadLeech on FreenodeThe only changes that do not impact the behavior of winit are style changes.
UndeadLeech on Freenodekchibisov: It's not a guarantee of course.
kchibisov on FreenodeYeah, this is one is a bit wierd, since you should min/max size in window builder.
UndeadLeech on FreenodeI mean I'm not much of a winit maintainer, so I don't have much to say. But I would never allow any Alacritty PR that changes anything in the code without being tested by at least two people.
kchibisov on FreenodeAnd this thing is pretty rare to happen, since there's
kchibisov on Freenodesince there's no real value in setting those things unless you're writing some 'special' application.
kchibisov on FreenodeLike you want to start your window in floating mode.
UndeadLeech on FreenodeAt least one person besides the original author.
kchibisov on FreenodeAh, how convinient.
UndeadLeech on FreenodeThe same way we do it in Alacritty.
kchibisov on FreenodeIt just happend that there's always two ppl to test every patch in alacritty.
UndeadLeech on FreenodeYeah and according to the list of testers in winit there should be more than two people capable of testing Wayland patches.
kchibisov on FreenodeAnd verify that something strange you're seeing is compositor bug.
kchibisov on FreenodeMost of the time that's true for GNOME.
kchibisov on FreenodeBut yeah, for something more complex than this one liner, I'd ping folks and wait for day or two.
UndeadLeech on FreenodePerfect is the enemy of good. Merging PRs without any second party verifying them because "testing correctly is difficult" is not exactly constructive.
UndeadLeech on FreenodeOnce you have people verify things on at least one compositor, you can think about having multiple tested.
kchibisov on FreenodeI mean if they verify on GNOME it's hard to say anything.
UndeadLeech on FreenodeWhy?
kchibisov on FreenodeLike the amount of GNOME bugs I've seen is rediculuos.
UndeadLeech on FreenodeWe should be aware of how the application behaves. If something cannot be tested on GNOME then that should be stated ahead of time.
kchibisov on FreenodeAnd it's not that hard to trigger them.
UndeadLeech on FreenodeIf there is a GNOME bug, we should be aware of it.
kchibisov on FreenodeI mean, I report them to GNOME sometimes.
kchibisov on FreenodeLike HiDPI on GNOME is completely broken last time I've tried.
UndeadLeech on FreenodeSo?
kchibisov on Freenodenothing, I guess.
Kai MastJust tested the bugfix and it resolves the problem for me.
kchibisov on FreenodeKai Mast: yeah, just set min_inner_size if you really want it on a window and not in a builder.
UndeadLeech on FreenodeIf something applies only to certain compositors, that should be made clear from the start. If it should work on all compositors and it turns out during the testing process that it doesn't, that's exactly what testing is there for.
kchibisov on FreenodeLike it just reverts scale factor after certain actions or something like that.
kchibisov on FreenodeSo I can't just state in every PR, 'please don't test anything on GNOME with HiDPI or verify logs in WAYLAND_DEBUG=1'.
kchibisov on FreenodeI mean I agree that everything should be tested, I just don't want to test GNOME bugs.
Kai Mast(I think since 0.23 most issues have been resolved for me though)
kchibisov on FreenodeI mean, I test sway, gnome, weston, and sometimes KDE.
kchibisov on FreenodeBut if you really want to test things you can add yourself as a tester on Wayland.
kchibisov on FreenodeInto this table ^