Welcome to tomaka/glutin, the official gitter channel for Glutin and Winit! - Github: https://github.com/rust-windowing/glutin, https://github.com/rust-windowing/winit - Crates.io: https://crates.io/crates/glutin, https://crates.io/crates/winit - Docs: https://docs.rs/glutin/0.21.0/glutin, https://docs.rs/winit/0.20.0/winit/
UndeadLeech on Freenode And if the capacity doesn't exist, it should be made transparent in the testers list.
UndeadLeech on Freenode I mean if two people tested the original code, it might not have existed in the first place.
kchibisov on Freenode That's true, but the only way I can change the winit behavior is adding new things, which I can't, because I've added everything I possible can for Wayland backend.
UndeadLeech on Freenode Fixing bugs changes the behavior of winit.
kchibisov on Freenode UndeadLeech: the original code was tested by more than just me.
UndeadLeech on Freenode The only changes that do not impact the behavior of winit are style changes.
UndeadLeech on Freenode kchibisov: It's not a guarantee of course.
kchibisov on Freenode Yeah, this is one is a bit wierd, since you should min/max size in window builder.
UndeadLeech on Freenode I mean I'm not much of a winit maintainer, so I don't have much to say. But I would never allow any Alacritty PR that changes anything in the code without being tested by at least two people.
kchibisov on Freenode And this thing is pretty rare to happen, since there's
kchibisov on Freenode since there's no real value in setting those things unless you're writing some 'special' application.
kchibisov on Freenode Like you want to start your window in floating mode.
kchibisov on Freenode UndeadLeech: are you counting the original author or are you counting only testers?
kchibisov on Freenode Ah, how convinient.
UndeadLeech on Freenode The same way we do it in Alacritty.
kchibisov on Freenode It just happend that there's always two ppl to test every patch in alacritty.
UndeadLeech on Freenode Yeah and according to the list of testers in winit there should be more than two people capable of testing Wayland patches.
kchibisov on Freenode The thing with Wayland, that proper PRs testing is very hard, since you should check like 4 compositors.
kchibisov on Freenode And verify that something strange you're seeing is compositor bug.
kchibisov on Freenode Most of the time that's true for GNOME.
UndeadLeech on Freenode Perfect is the enemy of good. Merging PRs without any second party verifying them because "testing correctly is difficult" is not exactly constructive.
kchibisov on Freenode I mean if they verify on GNOME it's hard to say anything.
UndeadLeech on Freenode Why?
kchibisov on Freenode Like the amount of GNOME bugs I've seen is rediculuos.
UndeadLeech on Freenode We should be aware of how the application behaves. If something cannot be tested on GNOME then that should be stated ahead of time.
kchibisov on Freenode And it's not that hard to trigger them.
UndeadLeech on Freenode If there is a GNOME bug, we should be aware of it.
kchibisov on Freenode I mean, I report them to GNOME sometimes.
kchibisov on Freenode Like HiDPI on GNOME is completely broken last time I've tried.
UndeadLeech on Freenode So?
kchibisov on Freenode nothing, I guess.
Kai Mast Just tested the bugfix and it resolves the problem for me.
kchibisov on Freenode Kai Mast: yeah, just set min_inner_size if you really want it on a window and not in a builder.
UndeadLeech on Freenode If something applies only to certain compositors, that should be made clear from the start. If it should work on all compositors and it turns out during the testing process that it doesn't, that's exactly what testing is there for.
kchibisov on Freenode Like it just reverts scale factor after certain actions or something like that.
kchibisov on Freenode So I can't just state in every PR, 'please don't test anything on GNOME with HiDPI or verify logs in WAYLAND_DEBUG=1'.
kchibisov on Freenode I mean I agree that everything should be tested, I just don't want to test GNOME bugs.
Kai Mast (I think since 0.23 most issues have been resolved for me though)
kchibisov on Freenode I mean, I test sway, gnome, weston, and sometimes KDE.
kchibisov on Freenode But if you really want to test things you can add yourself as a tester on Wayland.
kchibisov on Freenode https://github.com/rust-windowing/winit/wiki/Testers-and-Contributors
kchibisov on Freenode Into this table ^