maroider on v0.27.0
maroider on master
Release version 0.27.0 (#1359) (compare)
maroider on master
Fix CI warnings (#1356) * Mode… (compare)
kchibisov on FreenodeThe thing with Wayland, that proper PRs testing is very hard, since you should check like 4 compositors.
kchibisov on FreenodeAnd verify that something strange you're seeing is compositor bug.
kchibisov on FreenodeMost of the time that's true for GNOME.
kchibisov on FreenodeBut yeah, for something more complex than this one liner, I'd ping folks and wait for day or two.
UndeadLeech on FreenodePerfect is the enemy of good. Merging PRs without any second party verifying them because "testing correctly is difficult" is not exactly constructive.
UndeadLeech on FreenodeOnce you have people verify things on at least one compositor, you can think about having multiple tested.
UndeadLeech on FreenodeWhy?
kchibisov on FreenodeLike the amount of GNOME bugs I've seen is rediculuos.
UndeadLeech on FreenodeWe should be aware of how the application behaves. If something cannot be tested on GNOME then that should be stated ahead of time.
kchibisov on FreenodeAnd it's not that hard to trigger them.
UndeadLeech on FreenodeIf there is a GNOME bug, we should be aware of it.
kchibisov on FreenodeI mean, I report them to GNOME sometimes.
kchibisov on FreenodeLike HiDPI on GNOME is completely broken last time I've tried.
UndeadLeech on FreenodeSo?
kchibisov on Freenodenothing, I guess.
Kai MastJust tested the bugfix and it resolves the problem for me.
kchibisov on FreenodeKai Mast: yeah, just set min_inner_size if you really want it on a window and not in a builder.
UndeadLeech on FreenodeIf something applies only to certain compositors, that should be made clear from the start. If it should work on all compositors and it turns out during the testing process that it doesn't, that's exactly what testing is there for.
kchibisov on FreenodeI mean the thing with GNOME that it can arbitrary downscale you.
kchibisov on FreenodeSo I can't just state in every PR, 'please don't test anything on GNOME with HiDPI or verify logs in WAYLAND_DEBUG=1'.
kchibisov on FreenodeI mean I agree that everything should be tested, I just don't want to test GNOME bugs.
Kai Mast(I think since 0.23 most issues have been resolved for me though)
kchibisov on FreenodeI mean, I test sway, gnome, weston, and sometimes KDE.
kchibisov on FreenodeBut if you really want to test things you can add yourself as a tester on Wayland.
kchibisov on FreenodeInto this table ^
fuzbuz on FreenodeI have a C++ library that creates a window and it would be neat if I could just dump that window into winit somehow rather than trying to shoehorn things in
UndeadLeech on FreenodeWhy are you creating a window with a different library?
fuzbuz on FreenodeIf I can somehow convert the raw handle into a winit window, then it fits into the ecosystem nicely. If not, I suppose I can work around it.
UndeadLeech on FreenodeWhich library gives you that window handle?
fuzbuz on FreenodeI'm 95% sure it's coming from Qt
UndeadLeech on FreenodeShouldn't you use Qt then?
fuzbuz on FreenodeNope. For multiple reasons: I really dislike Qt, I'd rather work in Rust, and the rendering library is already written in Rust and I don't feel any need to rewrite it just to satisfy a single use of the library.
UndeadLeech on FreenodeIf you really dislike Qt, why are you letting it create windows for you?
fuzbuz on FreenodeI'm not. Someone else is and then giving me the window handle.
UndeadLeech on FreenodeAre you being held hostage?
fuzbuz on FreenodeIn the literal sense, no. I do like keeping my boss happy, though.
UndeadLeech on FreenodeWhat exactly do you want winit to do for you?
fuzbuz on FreenodeAt some point the rendering code has to turn it back into a raw handle for OS reasons, I can just add a function that passes an already-raw-handle down to that level.
fuzbuz on FreenodeBut it would be nice if I didn't have to do that.
UndeadLeech on FreenodeIs that a crate, or did you write the rendering library yourself? Fundamentally taking just a winit window for rendering doesn't make a ton of sense.
UndeadLeech on FreenodeWinit's purpose is to manage your windows and window events. If you don't have winit manage your windows, there's little point in using it.