These are chat archives for tomauty/react-native-chart

13th
Jul 2016
Peter Bozsó
@uruk
Jul 13 2016 15:11
@tomauty line chart is still broken for Android, it still doesn't draw any lines
Tom Auty
@tomauty
Jul 13 2016 16:20
on 1.0.6-beta?
Peter Bozsó
@uruk
Jul 13 2016 16:21
yep, but i just noticed that i am not on react native 0.29, let me give it a go with that
Tom Auty
@tomauty
Jul 13 2016 16:22
hopefully thats not the issue but we’ll see
Peter Bozsó
@uruk
Jul 13 2016 18:46
@tomauty http://puu.sh/q0wwp/bf44614d12.png with react native 0.29, in an android emulator, on a completely new project
Tom Auty
@tomauty
Jul 13 2016 18:46
is that the readme code
Peter Bozsó
@uruk
Jul 13 2016 18:46
and of course with the example code provided in the readme
Tom Auty
@tomauty
Jul 13 2016 18:46
lol
im really...quite bad
Peter Bozsó
@uruk
Jul 13 2016 18:46
yes :(
Tom Auty
@tomauty
Jul 13 2016 18:46
:tongue:
Peter Bozsó
@uruk
Jul 13 2016 18:46
:D
Tom Auty
@tomauty
Jul 13 2016 18:47
ive been using it in a production app but havent actually fixed the readme example
Peter Bozsó
@uruk
Jul 13 2016 18:47
x.X
Tom Auty
@tomauty
Jul 13 2016 18:47
what happens if you do things like hiding the axis?
still nothing?
and remove verticalGridStep
still learning data-viz in general...
Tom Auty
@tomauty
Jul 13 2016 18:49
daaang
whats the chart style?
Peter Bozsó
@uruk
Jul 13 2016 18:50
so it most likely not the animation problem i pointed out before?
it's from the readme
Tom Auty
@tomauty
Jul 13 2016 18:50
kk
well, 1.0.6-beta should have fixed that animation thing
it only renders Animated.View on ios
Peter Bozsó
@uruk
Jul 13 2016 18:51
yep, i saw the commits, i am puzzled :/
Tom Auty
@tomauty
Jul 13 2016 18:51
can you try animated={false}?
regardless, it’s silly that the readme code doesnt work, lol
ill look into it today
thanks for having faith :pray:
Peter Bozsó
@uruk
Jul 13 2016 18:52
thanks for trying to help me :)
sad that i am a javascript newbie, otherwise i could actually help
Tom Auty
@tomauty
Jul 13 2016 18:53
i am definitely a charting newbie
i inherited the lib on accident and needed android charts asap for work :smile:
well, i asked to inherit it, but didnt realize it’d become popular
Peter Bozsó
@uruk
Jul 13 2016 18:54
:)
i tried it on a physical device, the problem persists
btw actually this lib is the only decent one, all others are either not working, not supported anymore or such
Tom Auty
@tomauty
Jul 13 2016 18:55
yeah, i picked this one a while back because it was kinda maintained
Peter Bozsó
@uruk
Jul 13 2016 18:55
i was struggling for a day to render a chart inside a webview, but that wasn't easy neither
Tom Auty
@tomauty
Jul 13 2016 18:55
i worked w/ the objective c for a bit but then decided to rewrite over doing it again in java :p
Peter Bozsó
@uruk
Jul 13 2016 18:55
:)
what project did you need this lib for? or it's not public? :)
Peter Bozsó
@uruk
Jul 13 2016 18:59
woah, cool :) it's a full react-native app?
Tom Auty
@tomauty
Jul 13 2016 18:59
ya
Peter Bozsó
@uruk
Jul 13 2016 18:59
niice
Tom Auty
@tomauty
Jul 13 2016 19:00
just hit the 40k LOC mark today
:’)
lol
Peter Bozsó
@uruk
Jul 13 2016 19:00
:D
Tom Auty
@tomauty
Jul 13 2016 19:00
its just me right now
hence my delays in updating this lib
not in the company, but doing the app
Peter Bozsó
@uruk
Jul 13 2016 19:00
pretty impressive. i am just starting to wet my feet with react native, but it's encouraging to see full blown apps written in it
Tom Auty
@tomauty
Jul 13 2016 19:01
oh yeah, totally doable
there is obviously a lot left to go to make the RN+redux combo work for apps this large
like, there are probably 150 async actions that might happen in here
and so there’s a lot of redux-saga boilerplate
some kind of high-level abstraction over redux-saga is sorely needed for big apps
granted each dev can do it themselves, but it becomes discouraging
anyway!
ill check out the readme stuff this week :)
Peter Bozsó
@uruk
Jul 13 2016 19:03
ok :)
it works nicely on android
btw to rn + redux, i agree. i like the concept very much, but it has to mature a lot
but it's a good path to follow imho
Tom Auty
@tomauty
Jul 13 2016 19:05
interesting that that gist does that
i wonder if it has to do with height setting
with a surface inside?
Peter Bozsó
@uruk
Jul 13 2016 19:05
good question, the full render() method of linechart looks like this now: http://puu.sh/q0xLG/3a721c791a.png
and now it work nicely
i don't know which part 'fixes' the problem though
Tom Auty
@tomauty
Jul 13 2016 19:08
it could be the overflow hidden piece
Peter Bozsó
@uruk
Jul 13 2016 19:08
ok, this srews it up: style={{ overflow: 'hidden' }}
Tom Auty
@tomauty
Jul 13 2016 19:08
yeah
Peter Bozsó
@uruk
Jul 13 2016 19:08
that's it
how could that cause this?
Tom Auty
@tomauty
Jul 13 2016 19:08
wanna do a PR?
looking at it now
i might have an idea
Peter Bozsó
@uruk
Jul 13 2016 19:09
i would, but i am not sure that simply removing that would be a real fix :) what does that stlye supposed to do?
Tom Auty
@tomauty
Jul 13 2016 19:09
well, it’s leftover from the animated implementation
on android
essentially the linechart would ‘rise up’
but i realized this should be done by the library user, not the library itself
and i think i just forgot to remove that
Peter Bozsó
@uruk
Jul 13 2016 19:09
ah, i see
Tom Auty
@tomauty
Jul 13 2016 19:10
and im pretty sure it might consider the surface/group to be ‘overflow’ in that sense
Peter Bozsó
@uruk
Jul 13 2016 19:10
and it's still not perfect
a sec
so removing that overflow thing makes the grid appear again, but not the data line itself
removing this piece , backgroundColor: 'transparent'
makes the line appear too
Tom Auty
@tomauty
Jul 13 2016 19:11
haha
dang
Peter Bozsó
@uruk
Jul 13 2016 19:11
but how that it's not screwed up in ios, only in android? :D
Tom Auty
@tomauty
Jul 13 2016 19:11
ive read a smattering of issues re: overflow setting on android in the RN repo
dont really remember the details though
maybe if the PR is open others will discuss possible causes?
ive gotten emails from others recounting the same problems
Peter Bozsó
@uruk
Jul 13 2016 19:14
hm-hm
what should we do? simply remove these styles?
Tom Auty
@tomauty
Jul 13 2016 19:16
if you could do a PR with them removed i’ll remember to investigate :)
Peter Bozsó
@uruk
Jul 13 2016 19:16
ok, doing so :)
tomauty/react-native-chart#104 done, hope i helped :)
Tom Auty
@tomauty
Jul 13 2016 19:21
awesome, cheers man
Peter Bozsó
@uruk
Jul 13 2016 19:22
my thanks :) just drop me a line at uruk@scummvm.org if i am not around and you somehow need me!