Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 01 2018 11:59
  • Mar 05 2018 14:53

    toshok on master

    drop the 'set -x' so we stop ge… (compare)

  • Mar 05 2018 04:38

    toshok on master

    rename ALIGN to EJS_ALIGN to qu… fix sym/str warnings (compare)

  • Mar 04 2018 17:55
    Travis toshok/echojs (master) passed (848)
  • Mar 04 2018 17:42

    toshok on master

    building/testing stage1 is enou… (compare)

  • Mar 04 2018 17:20
    Travis toshok/echojs (master) errored (847)
  • Mar 04 2018 17:07

    toshok on master

    if set is gone, we don't need t… bump default LLVM_SUFFIX to 3.8 (compare)

  • Mar 04 2018 17:04
    Travis toshok/echojs (master) errored (846)
  • Mar 04 2018 16:28
    Travis toshok/echojs (master) errored (846)
  • Mar 04 2018 16:16

    toshok on master

    get rid of our local Set polyfi… (compare)

  • Mar 04 2018 15:03
    Travis toshok/echojs (master) passed (845)
  • Mar 04 2018 14:49

    toshok on master

    bump nan dep to clean up warnin… llvm38 moved from homebrew/vers… (compare)

  • Mar 04 2018 14:37
    Travis toshok/echojs (master) errored (844)
  • Mar 04 2018 14:26

    toshok on master

    bump esprima dep (compare)

  • Mar 04 2018 14:22
    Travis toshok/echojs (master) errored (843)
  • Mar 04 2018 14:16

    toshok on master

    try moving these to inside the … (compare)

  • Mar 04 2018 07:07
    Travis toshok/echojs (master) errored (841)
  • Mar 04 2018 07:07
    Travis toshok/echojs (master) errored (842)
  • Mar 04 2018 07:03

    toshok on master

    bump to node8 and xcode9.2 (compare)

  • Mar 04 2018 07:00

    toshok on master

    re-enable exiting on error fix typo add yarn lock file and 8 more (compare)

Chris Toshok
@toshok
Yeah that looks right
Chris Toshok
@toshok
Current guess is the version of Babel you installed is different enough from what we have that it matters. I should really update readme with the version
What version did npm install for you?
Noah Lovelady-Allen
@nloveladyallen_twitter
6.5.2
Chris Toshok
@toshok
yeah that’s definitely newer than what I have, by a fair margin: 5.5.8 here
mind doing npm rm -g babel then npm install -g babel@5.5.8 and seeing if that fixes it?
(if you used -g to install before)
Noah Lovelady-Allen
@nloveladyallen_twitter
Now it seems to build correctly, but can’t find ejs-es6.js.exe.
mv: rename ejs-es6.js.exe to ejs.exe.stage1: No such file or directory
Chris Toshok
@toshok
hm, odd. any other output in the console?
Noah Lovelady-Allen
@nloveladyallen_twitter
Makefile:32: target `clean-double-conversion' doesn't match the target pattern
Is the only other thing resembling an error
Chris Toshok
@toshok
do you see LINK ejs-es6.js.exe?
Noah Lovelady-Allen
@nloveladyallen_twitter
No
Chris Toshok
@toshok
hm, try running just make stage1
sorry, stage1, not stage :)
Noah Lovelady-Allen
@nloveladyallen_twitter
Same mv error
Chris Toshok
@toshok
k, this will likely generating a crap-ton of spew, but:
$ ./ejs -d --moduledir `pwd`/node-compat --moduledir `pwd`/ejs-llvm --srcdir ejs-es6.js
Noah Lovelady-Allen
@nloveladyallen_twitter
No output
Chris Toshok
@toshok
that’s the command line make stage1 runs, along with a -d
that’s… odd
that should at least generate the same output as what you’ve seen already
have you seen it actually compiling things?
ala:
host: darwin-x86_64, target: darwin-x86_64
[1/51] COMPILE ejs-es6.js
Noah Lovelady-Allen
@nloveladyallen_twitter
Not now, because it skips the directories already compiled
But yes, it was
Chris Toshok
@toshok
it shouldn’t skip the .js files
this isn’t the babel translation from es6 to es5, this is the es5 version of ejs compiling itself
speaking of, it’s conceivable that using babel 6 caused other problems during that initial translation
blow away lib/generated/*.js and re-run make stage1
Noah Lovelady-Allen
@nloveladyallen_twitter
Should I make clean and start over
Chris Toshok
@toshok
not make clean, that’ll cause a lot of other stuff to be cleaned that’s expensive to rebuild
Noah Lovelady-Allen
@nloveladyallen_twitter
OK I have to go now, I’ll try again tomorrow
Chris Toshok
@toshok
okay
sorry this is so problematic. we internalize so much pain we forget how hard it is to set things up :)
Noah Lovelady-Allen
@nloveladyallen_twitter
Well, now I’m getting JavaScript errors.
/Users/noah/src/echojs/lib/generated/ejs-es6.js:148
    debug_passes: new _libSetEs62['default'](),
                  ^

TypeError: _libSetEs62.default is not a function
    at Object.<anonymous> (/Users/noah/src/echojs/lib/generated/ejs-es6.js:148:19)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at startup (node.js:146:18)
    at node.js:404:3
make: *** [ejs.exe.stage1] Error 1
Chris Toshok
@toshok
that’s more babel
did you blow away lib/generated/*.js?
err actually just blow away the entire lib/generated directory
since its structure mirrors that of lib/ (many subdirs)
Chris Toshok
@toshok
hm, actually I have that exact same line here:
debug_passes: new _libSetEs62['default'](),
Noah Lovelady-Allen
@nloveladyallen_twitter
The build succeeded once I deleted lib/generated/
Chris Toshok
@toshok
okay, great. so you have an ejs-es6.exe now?
Noah Lovelady-Allen
@nloveladyallen_twitter
No
I have ejs.exe, but no ejs-es6.exe
Should I have an ejs-es6.exe?
Chris Toshok
@toshok
sorry, you have an exe :) okay cool
you should have ejs.exe, and (depending on the build target you used) ejs.exe.stage1, .stage2, .stage3