Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 18 19:50
    coveralls commented #466
  • Sep 18 19:45
    coveralls commented #466
  • Sep 18 19:45
    kurnevsky synchronize #466
  • Sep 18 19:45

    kurnevsky on tox-node

    chore(node): use 2021 edition chore(deps): update tokio (compare)

  • Sep 18 19:40
    kurnevsky synchronize #466
  • Sep 18 19:40

    kurnevsky on tox-node

    chore(node): use 2021 edition chore(deps): update tokio (compare)

  • Sep 18 18:54
    coveralls commented #466
  • Sep 18 18:47
    kurnevsky synchronize #466
  • Sep 18 18:47

    kurnevsky on tox-node

    chore(deps): update tokio (compare)

  • Sep 10 07:51
    coveralls commented #466
  • Sep 10 07:50
    coveralls commented #466
  • Sep 10 07:46
    kurnevsky synchronize #466
  • Sep 10 07:46

    kurnevsky on tox-node

    chore(node): use 2021 edition (compare)

  • Sep 10 07:45
    kurnevsky synchronize #466
  • Sep 10 07:45

    kurnevsky on tox-node

    chore(node): use 2021 edition (compare)

  • Sep 05 21:58
    coveralls commented #466
  • Sep 05 21:52
    kpp synchronize #466
  • Sep 05 21:52

    kpp on tox-node

    fix(node): actually read config… (compare)

  • Sep 04 21:22
    coveralls commented #466
  • Sep 04 21:17
    kpp synchronize #466
Sergey Tolmachev
@Tolsi
I do not know how much such a client is in demand in principle. And how much time I am willing to devote to it. I love the ideas of decentralization and anonymity, but I spend a lot of time on development at work and I'm a little tired.
Roman
@kpp
@Tolsi take a look at https://github.com/tox-rs/tox/blob/friends/examples/echo.rs. Not that pretty but it works
We want to create both a simple API and a nice UI. Rust can be easily compiled into .wasm. So it's not an issue, just a matter of time

Do you do it all on enthusiasm? :)

No we didn't. But things changed.

Roman
@kpp
@kurnevsky pls update tox-node in AUR and put down some notes how to build it
@suhr same for nix
Сухарик
@suhr
Evgeny Kurnevsky
@kurnevsky
For aur there is no standard way to build packages. Usually they just add link to the package and wiki https://wiki.archlinux.org/index.php/Arch_User_Repository#Installing_packages
Roman
@kpp
Thanks
Evgeny Kurnevsky
@kurnevsky
It's fine - makepkg automatically updates this version to the latest commit when building the package.
pkgver() {
  cd "$pkgname"
  git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
}
Evgeny Kurnevsky
@kurnevsky
Though arch wiki doesn't say anything about when I should or should not update this version...
So updated.
Roman
@kpp
Thanks
Roman
@kpp
@NamsooCho please try to push our tox-node image to https://docs.docker.com/docker-hub/official_images/#creating-an-official-image
Cho
@NamsooCho
Ok
Cho
@NamsooCho
    pub fn spawn(self, dht_sk: SecretKey, dht_pk: PublicKey) -> impl Future<Item = (), Error = SpawnError> + Send { // TODO: send pings periodically
        future::lazy(move || {
            let relay_pk = self.pk;
            let self_c = self.clone();

            match *self.status.write() {
                ref mut status @ ClientStatus::Disconnected
                | ref mut status @ ClientStatus::Sleeping => *status = ClientStatus::Connecting,
                _ => return future::ok(()),
            }

            let future = TcpStream::connect(&self.addr)
                .and_then(move |socket| make_client_handshake(socket, &dht_pk, &dht_sk, &relay_pk)) // TODO: timeout
                .and_then(move |(socket, channel)| {
                    let stats = Stats::new();
                    let secure_socket = Framed::new(socket, Codec::new(channel, stats));
make_client_handshake(socket, &dht_pk, &dht_sk, &relay_pk) return with error type of std::io::Error.
I don’t want to change the return error type of make_client_handshake.
What is the most sound way to match these types.
spawn returns with error type of SpawnError.
Cho
@NamsooCho
I’d change it to e.context(Kind::enumKind).into().
Cho
@NamsooCho
But it fails to compile, so I will use imp From<IoError> for SpwanError.
Roman
@kpp

I don’t want to change the return error type of make_client_handshake.

why not?

Cho
@NamsooCho
Not changing is for temporary. Including it would be a big PR.
Evgeny Kurnevsky
@kurnevsky
@NamsooCho why do you need it at all?
You can first make a pr that changes this type and then do something else.
Cho
@NamsooCho
@kurnevsky I am adopting error_kind! macro to tcp client.
This issue is assigned to me.
Evgeny Kurnevsky
@kurnevsky

I will use imp From<IoError> for SpwanError.

Better convert it explicitly.

But it fails to compile

It should be fine. What is the error?

Cho
@NamsooCho
Ok the compile error i said was occurred because of other reason. I will use e.context.
Roman
@kpp

Including it would be a big PR.

You can do it by parts. We can use .compat() to convert new errors into io::Error, so it will help you to use new errors in old code

Cho
@NamsooCho
Ok thanks!
They don’t check it till now. The travis error is not avoidable now. They said they are working on this traivs error.
Roman
@kpp
Hi. Tomorrow (8 June, Saturday) we will have a meeting with Andrew at 2pm UTC
Andrew Dirksen
@bddap
Me?
Evgeny Kurnevsky
@kurnevsky
:)
Another Andrew :)
Roman
@kpp
)))
Сухарик
@suhr
@kpp Should I participate?
Roman
@kpp
Yes please
The link to zoom conf is in slack
Сухарик
@suhr
I hope it doesn't require audio/video.
Roman
@kpp
You may keep silence =)
However you need to install zoom