Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 18 19:50
    coveralls commented #466
  • Sep 18 19:45
    coveralls commented #466
  • Sep 18 19:45
    kurnevsky synchronize #466
  • Sep 18 19:45

    kurnevsky on tox-node

    chore(node): use 2021 edition chore(deps): update tokio (compare)

  • Sep 18 19:40
    kurnevsky synchronize #466
  • Sep 18 19:40

    kurnevsky on tox-node

    chore(node): use 2021 edition chore(deps): update tokio (compare)

  • Sep 18 18:54
    coveralls commented #466
  • Sep 18 18:47
    kurnevsky synchronize #466
  • Sep 18 18:47

    kurnevsky on tox-node

    chore(deps): update tokio (compare)

  • Sep 10 07:51
    coveralls commented #466
  • Sep 10 07:50
    coveralls commented #466
  • Sep 10 07:46
    kurnevsky synchronize #466
  • Sep 10 07:46

    kurnevsky on tox-node

    chore(node): use 2021 edition (compare)

  • Sep 10 07:45
    kurnevsky synchronize #466
  • Sep 10 07:45

    kurnevsky on tox-node

    chore(node): use 2021 edition (compare)

  • Sep 05 21:58
    coveralls commented #466
  • Sep 05 21:52
    kpp synchronize #466
  • Sep 05 21:52

    kpp on tox-node

    fix(node): actually read config… (compare)

  • Sep 04 21:22
    coveralls commented #466
  • Sep 04 21:17
    kpp synchronize #466
Evgeny Kurnevsky
@kurnevsky
Though arch wiki doesn't say anything about when I should or should not update this version...
So updated.
Roman
@kpp
Thanks
Roman
@kpp
@NamsooCho please try to push our tox-node image to https://docs.docker.com/docker-hub/official_images/#creating-an-official-image
Cho
@NamsooCho
Ok
Cho
@NamsooCho
    pub fn spawn(self, dht_sk: SecretKey, dht_pk: PublicKey) -> impl Future<Item = (), Error = SpawnError> + Send { // TODO: send pings periodically
        future::lazy(move || {
            let relay_pk = self.pk;
            let self_c = self.clone();

            match *self.status.write() {
                ref mut status @ ClientStatus::Disconnected
                | ref mut status @ ClientStatus::Sleeping => *status = ClientStatus::Connecting,
                _ => return future::ok(()),
            }

            let future = TcpStream::connect(&self.addr)
                .and_then(move |socket| make_client_handshake(socket, &dht_pk, &dht_sk, &relay_pk)) // TODO: timeout
                .and_then(move |(socket, channel)| {
                    let stats = Stats::new();
                    let secure_socket = Framed::new(socket, Codec::new(channel, stats));
make_client_handshake(socket, &dht_pk, &dht_sk, &relay_pk) return with error type of std::io::Error.
I don’t want to change the return error type of make_client_handshake.
What is the most sound way to match these types.
spawn returns with error type of SpawnError.
Cho
@NamsooCho
I’d change it to e.context(Kind::enumKind).into().
Cho
@NamsooCho
But it fails to compile, so I will use imp From<IoError> for SpwanError.
Roman
@kpp

I don’t want to change the return error type of make_client_handshake.

why not?

Cho
@NamsooCho
Not changing is for temporary. Including it would be a big PR.
Evgeny Kurnevsky
@kurnevsky
@NamsooCho why do you need it at all?
You can first make a pr that changes this type and then do something else.
Cho
@NamsooCho
@kurnevsky I am adopting error_kind! macro to tcp client.
This issue is assigned to me.
Evgeny Kurnevsky
@kurnevsky

I will use imp From<IoError> for SpwanError.

Better convert it explicitly.

But it fails to compile

It should be fine. What is the error?

Cho
@NamsooCho
Ok the compile error i said was occurred because of other reason. I will use e.context.
Roman
@kpp

Including it would be a big PR.

You can do it by parts. We can use .compat() to convert new errors into io::Error, so it will help you to use new errors in old code

Cho
@NamsooCho
Ok thanks!
They don’t check it till now. The travis error is not avoidable now. They said they are working on this traivs error.
Roman
@kpp
Hi. Tomorrow (8 June, Saturday) we will have a meeting with Andrew at 2pm UTC
Andrew Dirksen
@bddap
Me?
Evgeny Kurnevsky
@kurnevsky
:)
Another Andrew :)
Roman
@kpp
)))
Сухарик
@suhr
@kpp Should I participate?
Roman
@kpp
Yes please
The link to zoom conf is in slack
Сухарик
@suhr
I hope it doesn't require audio/video.
Roman
@kpp
You may keep silence =)
However you need to install zoom
inosms
@inosms
Hi there! I am currently trying to use tox in a rust project of mine and have been using the c bindings (thank you so much for these bindings!) for now - but I thought it might be good to switch over the the actively maintained rust implementation (also less dependencies). I have taken a look at the examples (especially echo.rs) and it seems that the library is usable already (?) however I can't currently find any documentation on how to "easily" use the library (I am thinking of something like the c library has in this library: https://github.com/TokTok/c-toxcore) Is something like this in the works? And if not is there something I can maybe help with?
Evgeny Kurnevsky
@kurnevsky
Hi. I'd say that echo.rs is not in the final state yet and likely will be changed. Also we can work with UDP only now (although TCP is almost implemented). Regarding public api like tox.h - we don't have it yet so not sure if you can easily use the library right now.
inosms
@inosms
Ok I see, is there something I can help with (as a newbie to this field)? Some easy tickets?
Evgeny Kurnevsky
@kurnevsky
You can check the issues list - there are some easy issues if you want to deep into tox-rs development.
inosms
@inosms
uh thanks!! I will do some development if I have the time :)
I hope above article to translate to Korean and post it Korean Devs community site with original’s link.
Can I?
Cho
@NamsooCho
Nom5.0 has a concept of unrecoverable error, it means that nom can’t continue parsing, so terminating process or thread is needed.
but this means that we must have a point for DoS attack.
How should we handle this unrecoverable error?
inosms
@inosms
The article is great, haven't seen this one!! Looking forward to the one about tox-rs!!
Roman
@kpp

Can I?

Yes!

Nom5.0 has a concept of unrecoverable error, it means that nom can’t continue parsing, so terminating process or thread is needed.

Why terminate process? We can clear our buffer and start parsing again when new data will come from the socket