tox/tox

Tox implementation from scratch in pure Rust

Cho

@NamsooCho

I don’t want to change the return error type of make_client_handshake.

What is the most sound way to match these types.

spawn returns with error type of SpawnError.

Cho

@NamsooCho

I’d change it to e.context(Kind::enumKind).into().

Cho

@NamsooCho

But it fails to compile, so I will use imp From<IoError> for SpwanError.

Roman

@kpp

I don’t want to change the return error type of make_client_handshake.

why not?

Cho

@NamsooCho

Not changing is for temporary. Including it would be a big PR.

Evgeny Kurnevsky

@kurnevsky

@NamsooCho why do you need it at all?

You can first make a pr that changes this type and then do something else.

Cho

@NamsooCho

@kurnevsky I am adopting error_kind! macro to tcp client.

This issue is assigned to me.

Evgeny Kurnevsky

@kurnevsky

I will use imp From<IoError> for SpwanError.

Better convert it explicitly.

But it fails to compile

It should be fine. What is the error?

Cho

@NamsooCho

Ok the compile error i said was occurred because of other reason. I will use e.context.

Roman

@kpp

Including it would be a big PR.

You can do it by parts. We can use .compat() to convert new errors into io::Error, so it will help you to use new errors in old code

Cho

@NamsooCho

Ok thanks!

Cho

@NamsooCho

docker-library/official-images#5968

They don’t check it till now. The travis error is not avoidable now. They said they are working on this traivs error.

Roman

@kpp

Hi. Tomorrow (8 June, Saturday) we will have a meeting with Andrew at 2pm UTC

Andrew Dirksen

@bddap

Me?

Evgeny Kurnevsky

@kurnevsky

Another Andrew :)

Roman

@kpp

)))

Сухарик

@suhr

@kpp Should I participate?

Roman

@kpp

Yes please

The link to zoom conf is in slack

Сухарик

@suhr

I hope it doesn't require audio/video.

Roman

@kpp

You may keep silence =)

However you need to install zoom

inosms

@inosms

Hi there! I am currently trying to use tox in a rust project of mine and have been using the c bindings (thank you so much for these bindings!) for now - but I thought it might be good to switch over the the actively maintained rust implementation (also less dependencies). I have taken a look at the examples (especially echo.rs) and it seems that the library is usable already (?) however I can't currently find any documentation on how to "easily" use the library (I am thinking of something like the c library has in this library: https://github.com/TokTok/c-toxcore) Is something like this in the works? And if not is there something I can maybe help with?

Evgeny Kurnevsky

@kurnevsky

Hi. I'd say that echo.rs is not in the final state yet and likely will be changed. Also we can work with UDP only now (although TCP is almost implemented). Regarding public api like tox.h - we don't have it yet so not sure if you can easily use the library right now.

inosms

@inosms

Ok I see, is there something I can help with (as a newbie to this field)? Some easy tickets?

Evgeny Kurnevsky

@kurnevsky

You can check the issues list - there are some easy issues if you want to deep into tox-rs development.

inosms

@inosms

uh thanks!! I will do some development if I have the time :)

Cho

@NamsooCho

https://habr.com/en/post/447994/

I hope above article to translate to Korean and post it Korean Devs community site with original’s link.

Can I?

Cho

@NamsooCho

Nom5.0 has a concept of unrecoverable error, it means that nom can’t continue parsing, so terminating process or thread is needed.

but this means that we must have a point for DoS attack.

How should we handle this unrecoverable error?

inosms

@inosms

The article is great, haven't seen this one!! Looking forward to the one about tox-rs!!

Roman

@kpp

Can I?

Yes!

Nom5.0 has a concept of unrecoverable error, it means that nom can’t continue parsing, so terminating process or thread is needed.

Why terminate process? We can clear our buffer and start parsing again when new data will come from the socket

inosms

@inosms

When I try to run the example I get this:

[2019-06-12T07:42:27Z ERROR tox::toxcore::dht::server_ext] Failed to handle packet: HandlePacketError { ctx: HandleDataResponseError { ctx: HandleDhtPkAnnounceError { ctx: stack backtrace:
...
toxcore/onion/client/mod.rs:515
...
Invalid no_reply }
Failed to handle DHT PublicKey announce }
Handling OnionClient packet failed }

Is this normal?

Roman

@kpp

yes

We should hide errors -> info, because they may make users nervous =)

inosms

@inosms

ok thank you!

inosms

@inosms

I am not sure why, but now I get

Processing ended with error: Custom { kind: Other, error: Compat { error: EncodeError { ctx: Os { code: 65, kind: Other, message: "No route to host" }

the only part in the stacktrace that hints to tox is:

  11: <tox::toxcore::dht::codec::EncodeError as core::convert::From<std::io::error::Error>>::from::h5f8353515d42ff73 (0x1053cdd2f)
             at /Users/inosms/Desktop/tox/src/toxcore/dht/codec.rs:104

any hints?

Evgeny Kurnevsky

@kurnevsky

It looks like it might happen because of network issues. Does it still happen?

inosms

@inosms

Yes, ok then it is a problem with my uni net... Will retry when at home!

Where communities thrive

People

Repo info

Activity