These are chat archives for translate/dev

4th
Apr 2016
Taras Semenenko
@ta2-1
Apr 04 2016 10:48
@/all it seems I changed nothing in translate/pootle#4616 but tests fail now... checking why...
this test test_view_projects_browse passes on stage but it fails in travis
Dwayne Bailey
@dwaynebailey
Apr 04 2016 10:59
@ta2-1 is master failing with the same?
Taras Semenenko
@ta2-1
Apr 04 2016 11:17
@dwaynebailey master is not failing
Dwayne Bailey
@dwaynebailey
Apr 04 2016 11:18
@ta2-1 so it would be your changes then? No?
Taras Semenenko
@ta2-1
Apr 04 2016 11:20
@dwaynebailey, I addressed @julen's comment re admin hardcoded only
so I'm trying to understand why this change is the culprit.
Taras Semenenko
@ta2-1
Apr 04 2016 12:44
@dwaynebailey I had to clean cache properly
@julen @unho could you look at translate/pootle#4616 ?
Leandro Regueiro
@unho
Apr 04 2016 12:45
@ta2-1 Perhaps later. Busy now.
Taras Semenenko
@ta2-1
Apr 04 2016 12:45
sure
Julen Ruiz Aizpuru
@julen
Apr 04 2016 12:46
same here
Taras Semenenko
@ta2-1
Apr 04 2016 15:03
@julen commented here that we can use cache.delete_patern(). I had to change default cache backend in /tests/settings.py because LocalMemoryCache doesn't work.
@/all are we ok with this change?
Leandro Regueiro
@unho
Apr 04 2016 15:05
@ta2-1 That link seems to be broken.
Dwayne Bailey
@dwaynebailey
Apr 04 2016 15:05
@unho you want '#!/usr/bin/env python'
Otherwise you’re not getting your venvs python
Leandro Regueiro
@unho
Apr 04 2016 15:05
Sure. Don't want it.
Dwayne Bailey
@dwaynebailey
Apr 04 2016 15:05
I wouldn’t be surprised if that’s the source of your issu
Leandro Regueiro
@unho
Apr 04 2016 15:06
I am recreating the virtualenv from scratch, so can't test right now.
Leandro Regueiro
@unho
Apr 04 2016 15:08
@ta2-1 Since Redis is already being used for other caches I guess that it is ok.
Dwayne Bailey
@dwaynebailey
Apr 04 2016 15:10
@unho where is the file with locations again, I shated it via pastbin with you right?
Julen Ruiz Aizpuru
@julen
Apr 04 2016 15:11
@ta2-1 unless you are testing the cache or one of its features, I don't believe it's necessary to enforce a Redis backend. You can monkeypatch within the test function/session or subclass the LocMemCache and add a no-op delete_pattern() method
Taras Semenenko
@ta2-1
Apr 04 2016 15:14
@julen we already had redis and stats caches as redis. So what can we enforce here?
@julen you probably misunderstood. I didn't get errors with "method is not implemented". I had failed tests that expected working cache.delete_pattern()
I think that it's not worth to create a fake (but working) implementation within monkeypatch.
Julen Ruiz Aizpuru
@julen
Apr 04 2016 15:32
well, that's all I could say without any background information
Taras Semenenko
@ta2-1
Apr 04 2016 18:19
@julen I've added new React component in this commit https://github.com/ta2-1/pootle/blob/issue/3745/pootle/static/js/shared/components/UploadTimeSince.js#L25. Can you tell me what you think?