These are chat archives for translate/dev

7th
Apr 2016
Leandro Regueiro
@unho
Apr 07 2016 09:10
@ta2-1 gtm on translate/pootle#4635
@julen Several of your last PRs were really simple changes. Perhaps you have good reason to PR those, but if not next time perhaps it is better if you directly land them to master. Not that I am against of reviewing changes that land on master, but better focus on the ones that do require actual peer review.
Julen Ruiz Aizpuru
@julen
Apr 07 2016 09:21
hi @unho, sure, that makes perfect sense to me and thanks for bringing that up. If you need any reasons, in these particular PRs I wanted to raise a heads-up on the test changes as they outline an existing problem, and in reports-related stuff just wanted to have the original coder's blessing
Taras Semenenko
@ta2-1
Apr 07 2016 09:38
@/all suggestion's stuff is our priority and we'd like to deliver important changes to our clients asap. We have discussed translate/pootle#4630 which is addressed in translate/pootle#4635. So I'm going to land it if there are no objections.
@unho why have you put feature/suggestions tag to translate/pootle#4622?
Leandro Regueiro
@unho
Apr 07 2016 09:47
@ta2-1 That label describes the category where translate/pootle#4622 falls in.
Taras Semenenko
@ta2-1
Apr 07 2016 09:47
I can't get how)
Dwayne Bailey
@dwaynebailey
Apr 07 2016 09:48
@unho How? I made feature/suggestion to track bugs related to suggestions, trying to not use suggestion indicating a suggested improvement
But clearly I confused you and you’ve, I assumed read it as “Feature or Suggestion"
If not, well then my Q is the same as @ta2-1
Leandro Regueiro
@unho
Apr 07 2016 09:50
@ta2-1 @dwaynebailey It seems I misread the label name, my apologies. Should I undo the labelling?
Taras Semenenko
@ta2-1
Apr 07 2016 09:51
@unho yes, undo please
I wonder if we need to have “Feature or Suggestion" tag?
I guess it is more than just enhancement
Dwayne Bailey
@dwaynebailey
Apr 07 2016 09:53
@ta2-1 until we actually need something, no
I think we have enhancement already
Leandro Regueiro
@unho
Apr 07 2016 09:53
@ta2-1 @dwaynebailey I used that label because I thought it meant "feature suggestions", as in "new feature proposals". Didn't stop to think that it meant "suggestions feature".
Taras Semenenko
@ta2-1
Apr 07 2016 09:53
It can be called "New feature"
Leandro Regueiro
@unho
Apr 07 2016 09:54
"enhancement" is not necessarily "new feature". But can work.
Julen Ruiz Aizpuru
@julen
Apr 07 2016 12:06
Interesting stuff: pytest & tox devs are gathering in a sprint in a couple of months (open to donations https://www.indiegogo.com/projects/python-testing-sprint-mid-2016/)
Julen Ruiz Aizpuru
@julen
Apr 07 2016 13:32
Oh, this is good to know: @ta2-1 do you recall how once we were resorting to itertools.product() to pass down to a test all possible combinations of two iterables as parametrized arguments?
it turns out using @pytest.mark.parametrize() multiple times on the same function has the same effect :)
Taras Semenenko
@ta2-1
Apr 07 2016 13:55
@julen, yeah it is interesting.
Julen Ruiz Aizpuru
@julen
Apr 07 2016 14:01
HTH
Taras Semenenko
@ta2-1
Apr 07 2016 14:56
@julen I've updated translate/pootle#4616 re your nits and tried to address fixme in translate/pootle#4639 but tests fail (I don't know why). I'd land 4616 as it is atm not to put it into backlog.