These are chat archives for translate/dev

8th
Apr 2016
Julen Ruiz Aizpuru
@julen
Apr 08 2016 08:22
thank you @ta2-1, I'll check
Taras Semenenko
@ta2-1
Apr 08 2016 08:27
hi @julen )
Dwayne Bailey
@dwaynebailey
Apr 08 2016 08:27
@ta2-1 My gut feel re @iafan’s rich suggestion mockup would be to get to the change and comment level and evaluate user interaction issues.
Taras Semenenko
@ta2-1
Apr 08 2016 08:28
blob
we are discussing @iafan's mockup he shared with me yesterday
@ta2-1 that last link is to a bigger rendition
Taras Semenenko
@ta2-1
Apr 08 2016 08:30
blob
Dwayne Bailey
@dwaynebailey
Apr 08 2016 08:32
@ta2-1 so what are your concerns ito implementation?
Taras Semenenko
@ta2-1
Apr 08 2016 08:33
tbh I can't say now if it is difficult to put (copy) editor to suggestion area.
Dwayne Bailey
@dwaynebailey
Apr 08 2016 08:35
@ta2-1 should we focus as follows:
  1. Get backend in place to support the storing of comments
  2. Implement the UI with only changing and commenting
  3. Evaluate if we need to bring more of the editor down at this stage
Taras Semenenko
@ta2-1
Apr 08 2016 08:37
also Igor mentioned that @julen had PR re special fonts in the editor. He was worried if there are a lot of changes that should be merged.
Dwayne Bailey
@dwaynebailey
Apr 08 2016 08:41
@ta2-1 that’s translate/pootle#4171 I think there are some serious RTL blockers on that one. But works really well from my tests for LTR. @julen best person to give us an idea of the state. Landing together would be a pain.
Taras Semenenko
@ta2-1
Apr 08 2016 09:17
@julen this mockup is related to this issue if you need more context https://github.com/translate/pootle/issues/2596#issuecomment-207028555
Julen Ruiz Aizpuru
@julen
Apr 08 2016 12:58
@ta2-1 re. translate/pootle#4616 I checked again and works great, well done on that!
As a nit, can I ask you to double-check the docstring indents I mentioned the other day? Not critical but would be great if you do
Taras Semenenko
@ta2-1
Apr 08 2016 13:00
@julen have you chance to look at 4639? I really couldn't understand what changed and why tests fail
and having to say that addressing FIXME led to some duplicates
Julen Ruiz Aizpuru
@julen
Apr 08 2016 13:01
I'll check, but to be fair with you @ta2-1 the entire test suite doesn't work well for me mostly due to translate/pootle#4448
could you perhaps elaborate on duplicates?
some code that is added to cached_dict() is already present in for_user().
but it is not critical as I can see now
Julen Ruiz Aizpuru
@julen
Apr 08 2016 13:22
With the proposed change there seems to be a circular dependency, which is leading to such duplication
Currently: cached_dict => for_user => accessible_by_user
If we add accessible_by_user => cached_dict, you see how that becomes a loop
Taras Semenenko
@ta2-1
Apr 08 2016 13:25
yeah, that's why Project.get_codes_accessible_by_user() is added.
Julen Ruiz Aizpuru
@julen
Apr 08 2016 14:27
@ta2-1 from what I can tell, the tests retrieve the list of user-accessible projects from the cache, so it's likely the cache is somehow poisoned
Julen Ruiz Aizpuru
@julen
Apr 08 2016 14:35
if you can confirm that's the real cause, I'd lean more towards using the DummyCache as a default cache for testing, and individual tests needing a real cache would need to override that (although I admit last time I checked that wasn't trivial)

tbh I can't say now if it is difficult to put (copy) editor to suggestion area.

at the current shape, difficult, with the changes available in translate/pootle#4171 relatively easy (it becomes a reusable component after all)

Julen Ruiz Aizpuru
@julen
Apr 08 2016 14:43

@ta2-1 that’s translate/pootle#4171 I think there are some serious RTL blockers on that one. But works really well from my tests for LTR. @julen best person to give us an idea of the state. Landing together would be a pain.

I'm resuming work on that quite soon (once I'm done finishing off some stuff for our invoicing code). It has a few minor known bugs and some polishing is needed, as well as rebasing, but it was pretty much working fine. We are also willing to hear more from Khaled (will ping him on that when getting into it)

and speaking of invoices, we'd love to hear more feedback on translate/pootle#4619