These are chat archives for translate/dev

25th
May 2016
Dwayne Bailey
@dwaynebailey
May 25 2016 08:00
@julen seems eslint has some new linting rules, https://travis-ci.org/translate/pootle/jobs/132670915#L3847 are you able to fix?
Julen Ruiz Aizpuru
@julen
May 25 2016 08:11
these are not new, will fix now
Dwayne Bailey
@dwaynebailey
May 25 2016 08:20
@julen cool, ah I forget that I didn’t just land a doc fix :/
Taras Semenenko
@ta2-1
May 25 2016 10:29
@julen I've addressed your comments re translate/pootle#4605 but I'm not sure re https://github.com/translate/pootle/pull/4605#discussion_r64536218
Julen Ruiz Aizpuru
@julen
May 25 2016 12:33
hi ta2-1, checking now
Julen Ruiz Aizpuru
@julen
May 25 2016 12:56
ta2-1: I still see the warning for key, and I'm almost confident it originates in the string formatting code
if I do something like this (quick & dirty), it goes away https://dpaste.de/kuMa
Julen Ruiz Aizpuru
@julen
May 25 2016 13:15
ta2-1: I believe this one will work better https://dpaste.de/0veC
since we're modifying the React element being passed to add the key, it needs to be cloned
re. unmounting, a good candidate to place this is when a transition happens in the router (history)
Julen Ruiz Aizpuru
@julen
May 25 2016 13:20
If you recall it, I'm using a ReactRenderer helper in the raw font branch, so that it keeps track of the mounted nodes, and allows to unmount them all at once
Julen Ruiz Aizpuru
@julen
May 25 2016 13:30
ta2-1: I've gotta run, I'll be online in the evening
btw folks, I'd love to see something like this for Pootle https://github.com/reactjs/core-notes
cheers
Dwayne Bailey
@dwaynebailey
May 25 2016 13:32
@julen good idea, run with it