These are chat archives for translate/dev

14th
Sep 2016
Julen Ruiz Aizpuru
@julen
Sep 14 2016 07:42
good morning
phlax
@phlax
Sep 14 2016 07:45
morning
Leandro Regueiro
@unho
Sep 14 2016 07:45
Hi
Leandro Regueiro
@unho
Sep 14 2016 07:51
@julen Can you please do a quick review of translate/pootle#5212 ?
Julen Ruiz Aizpuru
@julen
Sep 14 2016 07:53
unho: yeah, just busy with #5202 at the moment...
Leandro Regueiro
@unho
Sep 14 2016 07:53
TIA
Taras Semenenko
@ta2-1
Sep 14 2016 07:58
Hi @julen, thanks. I'm afk today morning.
Dwayne Bailey
@dwaynebailey
Sep 14 2016 08:11
morning
phlax
@phlax
Sep 14 2016 08:12
morning
Taras Semenenko
@ta2-1
Sep 14 2016 10:30

@/all just to clarify:
yesterday night I addressed translate/pootle#5220 again because when I created a test I realised that there were two possible option to fix the issue:

self.instance.target.strings != value

vs.

self.instance.target != multistring(value or [u''])

and I've chosen the second one because it is clearer.

I feared when I saw output like this:

(Pdb) changed.target.strings
[multistring([u'%d dag gelede', u'%d dae gelede']), multistring([u'%d dae gelede'])]

the first element is shown already as multistring...

Taras Semenenko
@ta2-1
Sep 14 2016 10:38
@/all I forgot to mention that I got 5 licences (I'm using one of them) for https://www.jetbrains.com/pycharm/ Let me know if you want to check it.
phlax
@phlax
Sep 14 2016 10:45
an editor that needs a license?
Leandro Regueiro
@unho
Sep 14 2016 10:47
@ta2-1 Thanks, but I will stick to my current editor.
Taras Semenenko
@ta2-1
Sep 14 2016 10:47
@phlax as I understand you were trying not to put more than one ???? in the end.
I got free licences for the open source project if it makes a difference.
just in case posted it here.
however I wouldn't call it "an editor")
Julen Ruiz Aizpuru
@julen
Sep 14 2016 10:53
ta2-1: thanks for clarifying and sounds good. It also passes the grep test
Taras Semenenko
@ta2-1
Sep 14 2016 11:43
@julen re "store_path issue" from translate/pootle#5202:
it removed here https://github.com/translate/pootle/pull/5202/commits/165190ea53306d28f9cc5884b2598f6cb0f22e63 and I just kept commit history.
Julen Ruiz Aizpuru
@julen
Sep 14 2016 11:52
ta2-1: thanks for the heads-up, didn't notice that besides Leandro's comment
Julen Ruiz Aizpuru
@julen
Sep 14 2016 12:00
whoever can get it: room link please?
@ta2-1 @phlax Triage meeting now!
@ta2-1 @phlax We are starting without you.
Leandro Regueiro
@unho
Sep 14 2016 12:07
@phlax Are you coming?
phlax
@phlax
Sep 14 2016 12:15
hi apologies
just realised the time
Taras Semenenko
@ta2-1
Sep 14 2016 14:22
@julen it'd be great if you could give some feedback on translate/pootle#5240 please.
Julen Ruiz Aizpuru
@julen
Sep 14 2016 14:23
ta2-1: sure, I'm aware of it
Taras Semenenko
@ta2-1
Sep 14 2016 14:23
thanks so much
@/all I'm afk for ~20 min
Julen Ruiz Aizpuru
@julen
Sep 14 2016 14:24
I'm off too, bye!
Leandro Regueiro
@unho
Sep 14 2016 14:27
Bye
Dwayne Bailey
@dwaynebailey
Sep 14 2016 14:44
@phlax seems there are some issues on the ttk .lang fix
For py3
phlax
@phlax
Sep 14 2016 14:48
thanks, should be fixed...
Dwayne Bailey
@dwaynebailey
Sep 14 2016 14:49
@phlax still broke me thinks
phlax
@phlax
Sep 14 2016 14:49
yep - i havent pushed yet
i havent pushed because i was considering fixing the u local vars issue
phlax
@phlax
Sep 14 2016 14:56
@dwaynebailey @unho would you give that PR another quick look - i added a cleanup commit for the parse method
before you say - i forgot to include fix for bytes...
Dwayne Bailey
@dwaynebailey
Sep 14 2016 14:59
@phlax looks ok
phlax
@phlax
Sep 14 2016 15:00
cool, ill land when tests pass
Leandro Regueiro
@unho
Sep 14 2016 15:04
@phlax Looks ok. BTW, I am seeing "This branch has conflicts that must be resolved" at the bottom of the PR.
phlax
@phlax
Sep 14 2016 15:06
yep - wierd
not sure how that happened
rebasing now
Dwayne Bailey
@dwaynebailey
Sep 14 2016 15:06
@ta2-1 is the format loader still not landed?
Taras Semenenko
@ta2-1
Sep 14 2016 15:08
@dwaynebailey plural fix, unit_source were landed today. I'm addressing comments re format_loader.
Dwayne Bailey
@dwaynebailey
Sep 14 2016 15:08
cool, I thought it was a simple post unit_source landing
Jerome Leclanche
@jleclanche
Sep 14 2016 18:57
@dwaynebailey Hey, I was going over my organizations' security settings and I noticed translate doesn't have third party restrictions enabled. I would recommend you enable them. https://github.com/organizations/translate/settings/oauth_application_policy
Dwayne Bailey
@dwaynebailey
Sep 14 2016 19:02
@jleclanche ta
Jerome Leclanche
@jleclanche
Sep 14 2016 19:02
@dwaynebailey you might have to approve gitter btw
not sure
Dwayne Bailey
@dwaynebailey
Sep 14 2016 19:06
@jleclanche just did, @/all if any are missing please let me know