These are chat archives for translate/dev

29th
Sep 2016
Dwayne Bailey
@dwaynebailey
Sep 29 2016 08:15
Morning
Leandro Regueiro
@unho
Sep 29 2016 08:15
Hi
Julen Ruiz Aizpuru
@julen
Sep 29 2016 08:55
hi there
Julen Ruiz Aizpuru
@julen
Sep 29 2016 09:10
dwaynebailey: sorry if it wasn't clear enough removing the [WIP] tag and updating the description, I understand that doesn't necessarily trigger notifications
but yeah, it's fully ready
the end result is much more robust and efficient, and removes some ugly hacks
Dwayne Bailey
@dwaynebailey
Sep 29 2016 09:17
@julen ping here if you want humans to review, its not clear at all what you’d like our actions to be
We chatted this am to see what we needed to do to review
Do you have a staging server up somewhere, saves us having to deploy one
Julen Ruiz Aizpuru
@julen
Sep 29 2016 09:18
I'm afraid not wit this specific branch
Dwayne Bailey
@dwaynebailey
Sep 29 2016 09:43
@julen how would I turn this static/js/auth/components/SocialVerification.js:81
into a string with reorderable placeables
?
so you don't need interpolate() and gettext() at all, t() takes care of all of that
Dwayne Bailey
@dwaynebailey
Sep 29 2016 09:57
@julen tx, like this? translate/pootle#5296
Julen Ruiz Aizpuru
@julen
Sep 29 2016 10:02
dwaynebailey: exactly
Taras Semenenko
@ta2-1
Sep 29 2016 11:25
@julen does end (Cmd+<right arrow>)button work properly in new rawfonttext component?
it looks like if you put cursor after <LF> cursor will be moved to the next line automatically
Julen Ruiz Aizpuru
@julen
Sep 29 2016 11:45
ta2-1: I thought option+down was the equivalent of going to the end, but I see what you mean
Taras Semenenko
@ta2-1
Sep 29 2016 11:53
option+down works the same as cmd+right here
but they work differently in new raw font area
Julen Ruiz Aizpuru
@julen
Sep 29 2016 12:01
ta2-1: thanks for confirming, it should work fine now
when positioning the cursor between [LF] and \n, it was moving the key to the next character instead of to the previous one
Dwayne Bailey
@dwaynebailey
Sep 29 2016 13:43
@julen look good after my review. I picked up one new issue translate/pootle#5297
Julen Ruiz Aizpuru
@julen
Sep 29 2016 13:54
Cool, thanks for checking it out. Shall I merge?
Dwayne Bailey
@dwaynebailey
Sep 29 2016 14:00
@julen I’ll gtm on the issue
Taras Semenenko
@ta2-1
Sep 29 2016 14:25

@julen with translate/pootle#5281 I need to re think how I have to interact with outside world L20nEditor.
as you mentioned:

values is not part of state anymore; it was causing a lot of trouble because in the end the textarea is uncontrolled, so that state is managed by the DOM. now it is much more robust and works reliably

I'm not sure for 100% re l20neditor. but as I will need to think about that. because I confirm that it looks clearer and more reliable now.

Julen Ruiz Aizpuru
@julen
Sep 29 2016 14:26
ta2-1: at the moment we used some helper methods in ReactEditor that modify the DOM with the raw font utilities
Taras Semenenko
@ta2-1
Sep 29 2016 14:27
@/all when I worked on l20nsource I adjusted UnitSource component a bit. I'd like to land that separately translate/pootle#5294
any thoughts?
Julen Ruiz Aizpuru
@julen
Sep 29 2016 14:28
It works fine, although it feels very much ad-hoc. Some other data flow solution (e.g. redux) can help here, as we are trying to communicate with a component from a level which is far away from it
Leandro Regueiro
@unho
Sep 29 2016 14:30
I will rely on @julen input re translate/pootle#5294
Sorry if that sounds unhelpful, but I am quite unfamiliar with that code.
Taras Semenenko
@ta2-1
Sep 29 2016 14:35
@julen thanks I'll check how I can use redux later.
Julen Ruiz Aizpuru
@julen
Sep 29 2016 14:36
ta2-1: I don't think that's important at the moment, but rather a potential improvement. Calling methods/functions directly still works fine
Leandro Regueiro
@unho
Sep 29 2016 15:07
@julen Found another issue while testing your changes: translate/pootle#5298 But other than that lgtm.
Julen Ruiz Aizpuru
@julen
Sep 29 2016 15:08
thank you unho
Leandro Regueiro
@unho
Sep 29 2016 15:08
Thank you. Very nice work.
Julen Ruiz Aizpuru
@julen
Sep 29 2016 15:09
I think your report is basically the same as dwaynebailey's
alright, time to leave, cheers all
Leandro Regueiro
@unho
Sep 29 2016 15:09
Bye.
Dwayne Bailey
@dwaynebailey
Sep 29 2016 15:17
Yip @unho that’s same report as mine