These are chat archives for translate/dev

6th
Oct 2016
Dwayne Bailey
@dwaynebailey
Oct 06 2016 08:30
Morning
Leandro Regueiro
@unho
Oct 06 2016 08:32
Hi
Dwayne Bailey
@dwaynebailey
Oct 06 2016 12:57
This message was deleted
phlax
@phlax
Oct 06 2016 14:56
@/all @unho let me introduce @nootanghimire he is a localizer/moz contributor, with some pretty cool hacking skills
who is maybe willing to contribute some code to pootle
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:06
Hi guys..
Leandro Regueiro
@unho
Oct 06 2016 15:06
Hi
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:06
I'd like ro
phlax
@phlax
Oct 06 2016 15:06
hey
ro?
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:07
Gitter + android + autocorrect :/
Leandro Regueiro
@unho
Oct 06 2016 15:07
That happens.
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:07
Let me boot my laptop.. Just a min
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:08
@nootanghimire hi, nice of you to join us
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:09
Thanks @dwaynebailey , how are you, BTW?
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:10
Hey I’m good. I believe you where all looking after @phlax :)
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:11
We did a terrible job though, he ended up hurting his forehead.
phlax
@phlax
Oct 06 2016 15:11
i think that was part of the journey
Leandro Regueiro
@unho
Oct 06 2016 15:12
I think that needs more detailed explanation :)
phlax
@phlax
Oct 06 2016 15:12
i walked into a momo stall late at night
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:12
:) . So anyways, I'd like to contribute to the newer bits @phlax and me did a sprint on.
phlax
@phlax
Oct 06 2016 15:12
it might have been badly lit, or i might not have been looking
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:13
@phlax or too tall for an Englishman
phlax
@phlax
Oct 06 2016 15:13
its hard to tell when you walk into it
yep 8/
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:13
@nootanghimire @phlax do you have a branch with that code?
phlax
@phlax
Oct 06 2016 15:13
i have a branch (or two)
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:14
I suppose I start with cloning the master ?
yep clone master first
and make sure you have all the deps required for dev
one mo ill try andfind...
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:16
Thx. Cloning
phlax
@phlax
Oct 06 2016 15:17
there is some docs about frontend requirements
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:17
@nootanghimire what I do is fork on github and then clone that. I add the main repo as another remote in git called upstream. That way I can easily work on my fork and then PR to the main repo. If that makes no sense to you then just ignore me for now :)
phlax
@phlax
Oct 06 2016 15:17
its pretty important but i cant find 8/
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:19
@dwaynebailey It makes complete sense :)
phlax
@phlax
Oct 06 2016 15:19
thanks
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:21
But I'm not sure how do I change the remote for team_pages branch which is local to phlax, I guess.
phlax
@phlax
Oct 06 2016 15:21
you can (probs want) multiple upstream
for me:
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:22
ok
phlax
@phlax
Oct 06 2016 15:22
  • upstream -> translate/pootle
  • unho -> unho/pootle
  • origin -> phlax/pootle
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:23
@phlax I clearly wasn’t watching, did you just start pootle_fs_web :)
phlax
@phlax
Oct 06 2016 15:23
i did 8/
Leandro Regueiro
@unho
Oct 06 2016 15:23
translate/pootle#5314
phlax
@phlax
Oct 06 2016 15:23
just the beginnings
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:24
guys, do you put virtualenv folder outside the repo?
phlax
@phlax
Oct 06 2016 15:24
not normally
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:24
I use virtualenvwrappers
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:25
was expecting env or similar folder in .gitignore
phlax
@phlax
Oct 06 2016 15:25
normally something like - (yep virtualenvwrappers)
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:25
maybe will just use virtualenv in ../pootle_virtulenv
phlax
@phlax
Oct 06 2016 15:26
# mkvirtualenv mypootle
(mypootle)# cd .virtualenv/mypootle
(mypootle)# pip install -e git@github.com:phlax/pootle
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:26
@nootanghimire you won’t regret https://virtualenvwrapper.readthedocs.io/en/latest/
No @phlax I wouldn’t do that
pip install -e .
phlax
@phlax
Oct 06 2016 15:27
something like that
phlax @phlax starts flamewar on best dev install (and hides)
phlax
@phlax
Oct 06 2016 15:29
best listen to @dwaynebailey and the docs ^^
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:31
Ppl all over the home, Internet is too f*ing slow :'(
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:31
@nootanghimire sorry for that :(
I shouldn’t be flaming you
Leandro Regueiro
@unho
Oct 06 2016 15:32
Images surely won't help with slow internet.
phlax @phlax hides more with minimal text
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:32
Normal browsing is fine... It's slow while cloning
phlax
@phlax
Oct 06 2016 15:36
@unho if you can get travis to agree i would land this translate/pootle#5313 asap
Leandro Regueiro
@unho
Oct 06 2016 15:37
Working on that.
phlax
@phlax
Oct 06 2016 15:37
only question is about creating the project folder for working space
and, where the best place to put working dir is
Leandro Regueiro
@unho
Oct 06 2016 15:37
I created a new directory for pootle_fs and referenced it on new setting's default
Let me update PR in a bit, and you will see.
phlax
@phlax
Oct 06 2016 15:38
k
i meant more...
pootle_fs_working_path/$project_name
maybe its not an issue
or responsibility of plugin etc
Leandro Regueiro
@unho
Oct 06 2016 15:38
We require projects to have unique codes, which means unique dir names in translations dir.
I guess the same will be used in pootle_fs dir.
phlax
@phlax
Oct 06 2016 15:39
hmm - or just making sure it exists
a check maybe?
afk for a mo, brb
Leandro Regueiro
@unho
Oct 06 2016 15:39
k
Nootan Ghimire
@nootanghimire
Oct 06 2016 15:40

We require projects to have unique codes, which means unique dir names in translations dir.

Maybe I don't know much... But isn't it a universal requirement to have unique dir names in any dir in any os.

phlax
@phlax
Oct 06 2016 15:41
yep, it is
we just need to make sure that the path that we set exists i think
Leandro Regueiro
@unho
Oct 06 2016 15:42
@phlax If you mean POOTLE_FS_WORKING_PATH then it will exist.
But I guess you mean the dir inside for the project.
phlax
@phlax
Oct 06 2016 15:42
yep, we need to make sure
but i also mean that
Leandro Regueiro
@unho
Oct 06 2016 15:42
My gut feeling re that is that that should be handled when creating project, or by pootle_fs directly.
phlax
@phlax
Oct 06 2016 15:42
altho maybe that is the responsibility of the plugin or whatever does the sync and not the config - not sure
maybe we should do it heree
go for it @unho
it would be one less thing to worry about
Leandro Regueiro
@unho
Oct 06 2016 15:43
I would say do it when creating project, so any subsequent plugin or whatever can blindly rely on it being there.
phlax
@phlax
Oct 06 2016 15:43
we might still want the check tho
in case the dir goes awasy
Leandro Regueiro
@unho
Oct 06 2016 15:44
mmm, not sure what are you talking about.
phlax
@phlax
Oct 06 2016 15:44
pootle is configured with POOTLE_FS_PATH=/tmp/foo
Leandro Regueiro
@unho
Oct 06 2016 15:44
We don't have any check for POOTLE_TRANSLATION_DIRECTORY, for example.
phlax
@phlax
Oct 06 2016 15:44
computer is restarted
/tmp/foo disappears
check says - POOTLE_FS_PATH set to non-existent directory, you fail
Leandro Regueiro
@unho
Oct 06 2016 15:45
Yep, I am not using /tmp/
phlax
@phlax
Oct 06 2016 15:45
lets think outside of just /tmp/
Leandro Regueiro
@unho
Oct 06 2016 15:48
@phlax Updated translate/pootle#5313
phlax
@phlax
Oct 06 2016 15:53
@dwaynebailey any thoughts on
+``POOTLE_FS_WORKING_PATH``
+  Default: ``working_path('pootle_fs')``
lgtm, with the caveat that anything on that path ends up in some egg lib on a production install
Leandro Regueiro
@unho
Oct 06 2016 15:54
Right, might need to adjust to exclude its contents.
The manifest I mean.
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:54
+1 WORKING -1 _PATH (I thnk we rationalised to _DIRECTORY, but that gets long)
phlax
@phlax
Oct 06 2016 15:54
@unho i lgtm, not sure what tests/coverage are tho
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:55
@phlax not too concerned, feel like we can get something better than pootle_fs, not 100% sure what
Leandro Regueiro
@unho
Oct 06 2016 15:55
Can be changed to directory if that is a preference.
phlax
@phlax
Oct 06 2016 15:55
its probs worth landing that PR and moving on, we probs want to make more adjustments
yep, its a temp dir
but just in an obscure place
for, now lgtm
Dwayne Bailey
@dwaynebailey
Oct 06 2016 15:56
@phlax agreed
Leandro Regueiro
@unho
Oct 06 2016 15:57
k
phlax
@phlax
Oct 06 2016 15:57
@unho in that case we need to ensure that pootle_fs is robust enough to always create if necessary
not sure if that is case atm
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:01
@phlax / @unho / @dwaynebailey : do we use py2 or py3 ?
Dwayne Bailey
@dwaynebailey
Oct 06 2016 16:06
@nootanghimire py2
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:06
thx.
Dwayne Bailey
@dwaynebailey
Oct 06 2016 16:06
We haven’t ported Pootle to py3
Leandro Regueiro
@unho
Oct 06 2016 16:06
@phlax Added commit to ensure the directory is created in pootle_fs directory.
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:06
someone in translate/pootle mentioned about py3 and translate, IIRC. but I do not know the context of that conversation properly
Leandro Regueiro
@unho
Oct 06 2016 16:07
Translate Toolkit is able to work on py3
Dwayne Bailey
@dwaynebailey
Oct 06 2016 16:07
@nootanghimire our dependencies are now almost all py3 compatible https://requires.io/github/translate/pootle/requirements/ so it would be possible to begin looking at porting now
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:16
@phlax mentioned pootle uses MySQL, but the inital config seems to be for sqlite. Should I change that to mysql?
because there are errors when I migrate.
Leandro Regueiro
@unho
Oct 06 2016 16:17
Well, let it as is. I don't want to start another flame war.
Which errors?
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:17
/home/charles/codes/translatehouse/pootle/pootle/apps/pootle_store/fields.py:84: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.
  class MultiStringField(models.Field):

2016-10-06 16:15:33,961 WARNING /home/charles/codes/translatehouse/pootle/pootle/apps/pootle_store/fields.py:84: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.
  class MultiStringField(models.Field):
oh, maybe these are only warnings...
but there is a traceback afterwards which reads
Traceback (most recent call last):
  File "manage.py", line 22, in <module>
    execute_from_command_line()
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 353, in execute_from_command_line
    utility.execute()
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 345, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/base.py", line 348, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/base.py", line 398, in execute
    self.check()
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/base.py", line 426, in check
    include_deployment_checks=include_deployment_checks,
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/checks/registry.py", line 75, in run_checks
    new_errors = check(app_configs=app_configs)
  File "/home/charles/codes/translatehouse/pootle/pootle/checks.py", line 437, in check_revision
    revision = Revision.get()
  File "/home/charles/codes/translatehouse/pootle/pootle/core/models/revision.py", line 45, in get
    return cache.get(cls.CACHE_KEY)
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django_redis/cache.py", line 39, in _decorator
    raise e.parent
redis.exceptions.ConnectionError: Error 111 connecting to 127.0.0.1:6379. Connection refused.
Leandro Regueiro
@unho
Oct 06 2016 16:20
The first warnings are because of deprecated code.
phlax
@phlax
Oct 06 2016 16:20
you need to install and run redis
Leandro Regueiro
@unho
Oct 06 2016 16:21
Redis missing should be picked by checks.
@nootanghimire can you confirm that between these two there is a warning or error asking for Redis?
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:22
I can confirm I did not miss anything betweeen these two snippets
(pootle-dev)  ~/codes/translatehouse/pootle   master  python manage.py migrate  

/home/charles/codes/translatehouse/pootle/pootle/apps/pootle_store/fields.py:84: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.
  class MultiStringField(models.Field):

2016-10-06 16:15:33,961 WARNING /home/charles/codes/translatehouse/pootle/pootle/apps/pootle_store/fields.py:84: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.
  class MultiStringField(models.Field):

Traceback (most recent call last):
  File "manage.py", line 22, in <module>
    execute_from_command_line()
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 353, in execute_from_command_line
    utility.execute()
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 345, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/base.py", line 348, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/base.py", line 398, in execute
    self.check()
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/management/base.py", line 426, in check
    include_deployment_checks=include_deployment_checks,
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django/core/checks/registry.py", line 75, in run_checks
    new_errors = check(app_configs=app_configs)
  File "/home/charles/codes/translatehouse/pootle/pootle/checks.py", line 437, in check_revision
    revision = Revision.get()
  File "/home/charles/codes/translatehouse/pootle/pootle/core/models/revision.py", line 45, in get
    return cache.get(cls.CACHE_KEY)
  File "/home/charles/.virtualenvwrapper/envs/pootle-dev/local/lib/python2.7/site-packages/django_redis/cache.py", line 39, in _decorator
    raise e.parent
redis.exceptions.ConnectionError: Error 111 connecting to 127.0.0.1:6379. Connection refused.
Command-with-output
Leandro Regueiro
@unho
Oct 06 2016 16:23
Oh, the traceback comes from checks.
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:23
But I do think I do not have redis installed
Leandro Regueiro
@unho
Oct 06 2016 16:23
Yes, Redis is a hard dependency
phlax
@phlax
Oct 06 2016 16:26
@unho seems like we need to add a condition to only add iff required https://travis-ci.org/translate/pootle/jobs/165578762
and probs also remove whatever created the dir
Leandro Regueiro
@unho
Oct 06 2016 16:27
Yep
Leandro Regueiro
@unho
Oct 06 2016 16:35
@phlax Added a condition to only add if missing. Not sure if that is what you meant.
phlax
@phlax
Oct 06 2016 16:36
probably
Leandro Regueiro
@unho
Oct 06 2016 16:37
Yep
And probably some other too.
phlax
@phlax
Oct 06 2016 16:38
yep
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:48
managed to run the server but some weird errors while trying to access web interface
Leandro Regueiro
@unho
Oct 06 2016 16:48
Which errors?
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:48
NoReverseMatch
Leandro Regueiro
@unho
Oct 06 2016 16:49
Is there any traceback?
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:49
yeah, lots of
wait
but first, @unho : localhost:8000/admin must exist, right?
Leandro Regueiro
@unho
Oct 06 2016 16:50
Not sure.
phlax
@phlax
Oct 06 2016 16:50
for dev use
Leandro Regueiro
@unho
Oct 06 2016 16:50
localhost:8000/admin/ should exist.
Note trailing /
phlax
@phlax
Oct 06 2016 16:51
pootle runserver 0.0.0.0:8000
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:51
yes.
phlax
@phlax
Oct 06 2016 16:51
from your venv
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:52
@phlax , I believe I can replace pootle with ./manage.py
Leandro Regueiro
@unho
Oct 06 2016 16:52
Yes, that is ok.
Using manage.py instead.
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:52
Brace yourselves.. Huge traceback coming..
couldn't paste all here..
phlax
@phlax
Oct 06 2016 16:54
might not be the problem
but im wondering about assets
if you didnt install from production tarball
you need to install nodejs/npm
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:55
I am running ./manage.py webpack --dev from another tab
phlax
@phlax
Oct 06 2016 16:55
and ideally run
k - ignore me
if you post link to tb we can look
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:56
also, #TIL : installing nodejs does not install npm on debian :/
Leandro Regueiro
@unho
Oct 06 2016 16:56
Never saw a traceback like this.
Might be missing dependencies?
Do you have installed all dev requirements?
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:57
yes
pip install -r requirements/dev.txt
@phlax define tb?
Leandro Regueiro
@unho
Oct 06 2016 16:59
tb is short for traceback
Nootan Ghimire
@nootanghimire
Oct 06 2016 16:59
oh
Dwayne Bailey
@dwaynebailey
Oct 06 2016 16:59
@nootanghimire quick google shows issues like this jazzband/django-debug-toolbar#529
Any chance its wrong Django version? Or debug toolbar version?
phlax
@phlax
Oct 06 2016 17:02
@unho you probs want to use os.makedirs here https://travis-ci.org/translate/pootle/jobs/165589456#L3325
Leandro Regueiro
@unho
Oct 06 2016 17:03
Thanks
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:12
Had to change urls.py
phlax
@phlax
Oct 06 2016 17:12
what was the problem ?
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:13
Thanks to @dwaynebailey , jazzband/django-debug-toolbar#529 was the exact same issue
phlax
@phlax
Oct 06 2016 17:13
ah - ok
im not that keen on it tbh
we have a really handy debugging tool pootle.core.debug_sql but that is for another day i reckon
are you familiar with rebasing @nootanghimire ?
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:14
@phlax , not much.
Done it sometimes, but never really looked into it
phlax
@phlax
Oct 06 2016 17:14
its pretty essential, because master is changing all the time , so you will need to regularly rebase against master
basically i tend to do this...
git fetch upstream
git checkout master
git rebase upstream/master
git checkout mybranch
git rebase master
quite a lot
but if there are conflicts you will need to resolve
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:16
Okay. Just skimmed a git-scm article quickly
phlax
@phlax
Oct 06 2016 17:20
adjusted above
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:20
:) was guessing the first fetch was while in master
phlax
@phlax
Oct 06 2016 17:20
you dont need to do so many steps, but the ocd in me likes to keep my local master up to date with upstream
fetch you can do anywhere, ill update to reflect....
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:21
btw, need git help. What will happen if I checkout to another branch with uncommitted/untracked changes
I think I don't want to commit changes to urls.py
phlax
@phlax
Oct 06 2016 17:21
well, you can do one of 3 things
  • commit
  • stash
  • reset
you can also do this..
git checkout path/to/changes/i/dont/want
but ymmv dep on circumstance
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:24
I did some changes to pootle/urls.py for it to work.
phlax
@phlax
Oct 06 2016 17:24
re committing - branches are cheap
but if you create too many it gets messy
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:24
since it is working on other's machine, I do not want to commit that change
phlax
@phlax
Oct 06 2016 17:24
what is the change?
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:24
Addition of:
from django.conf.urls import include, url, patterns
and
if settings.DEBUG:
    import debug_toolbar
    urlpatterns += patterns('',
        url(r'^__debug__/', include(debug_toolbar.urls)),
    )
phlax
@phlax
Oct 06 2016 17:26
hmm
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:26

from django.conf.urls import include, url, patterns

In this, I just added , patterns

phlax
@phlax
Oct 06 2016 17:26
im wondering whether we should remove debug_toolbar from default dev setup
was it something you wanted @nootanghimire ?
any thoughts @unho ?
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:27

was it something you wanted @nootanghimire ?

@phlax wanted the debug_toolbar ?

phlax
@phlax
Oct 06 2016 17:28
yep, my question was basically - was it something you had to mess around with to get running
or something you actually wanted
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:28
yes
the former
phlax
@phlax
Oct 06 2016 17:28
ah, yep
@unho lets remove that!
@nootanghimire you could PR to remove
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:29
should I ?
phlax
@phlax
Oct 06 2016 17:29
i think so
but expect review 8/
i think remove it altogether tbh
i dont know any devs that use it
and any that do, can easily install it
i had similar issues getting started iirc
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:32
I am rather worried about comments on the PR.
like I have no base for removing that . :P
phlax
@phlax
Oct 06 2016 17:33
you should be 8/
but it works
this can probs go
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:35
was about to write the same
:)
phlax
@phlax
Oct 06 2016 17:35
@dwaynebailey any thoughts on rming djdebug_toolbar ?
noone uses that i know of
@nootanghimire if we PR and let it lurk for a day or 2 we can get any feedback on the PR
but i really doubt anyone will object
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:36
working on removing and testing
just did pip uninstall
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:48
@phlax just did a PR
phlax
@phlax
Oct 06 2016 17:48
nice one, thanks @nootanghimire
Nootan Ghimire
@nootanghimire
Oct 06 2016 17:49
btw, 3 more PRs to go for digitalocean's hacktoberfest ;)
Leandro Regueiro
@unho
Oct 06 2016 18:12
Catching up
@/all Re Django debug toolbar I don't know if anyone is actively using it. Perhaps @julen is.
Nootan Ghimire
@nootanghimire
Oct 06 2016 18:45
Hey @phlax , are you working on pootle_language app in team_pages ?
Dwayne Bailey
@dwaynebailey
Oct 06 2016 21:15
@phlax I’m fine to remove, was just looking at requirements myself trying to bump things up to fixed pins in the test/dev/lint environment as well as set minimums that cover our Django version and py3
Leandro Regueiro
@unho
Oct 06 2016 21:26
@phlax I am having trouble to set up the pootle_fs config for a project. Any hint?