These are chat archives for translate/dev

18th
Sep 2017
Johannes Marbach
@Johennes
Sep 18 2017 12:09

I've been following the development environment setup guide but it seems that even though I created a super user, I cannot login on the running instance. Tapping the login button doesn't seem to do anything.

I also can't seem to display any of the messages. The project overview looks ok but once I navigate down (e.g. to http://localhost:8000/af/tutorial/translate/#filter=all), I always end up in a blank page.

Any idea what might be off here?

phlax
@phlax
Sep 18 2017 12:11
yep, most likely you need to verify the user
in the dev server it doesnt give very good indication of that
normally verify is an email verification, but we added a tool to do it on the cli
pootle verify_user $username
Johannes Marbach
@Johennes
Sep 18 2017 12:12
Yes, I actually did that
phlax
@phlax
Sep 18 2017 12:12
and did it fix the login issue ?
Johannes Marbach
@Johennes
Sep 18 2017 12:13
Sadly not :(
phlax
@phlax
Sep 18 2017 12:13
hmm - so in that case it seems like there is some kinda assets problem i guess
can you f12 and look for any error messages on the console
Johannes Marbach
@Johennes
Sep 18 2017 12:14
Oh, yeah there's a few
Loading failed for the <script> with source “http://localhost:8000/assets/translations/en/djangojs.js”.
phlax
@phlax
Sep 18 2017 12:16
i think maybe you need to compile the js l10n
lmc for the command...
Johannes Marbach
@Johennes
Sep 18 2017 12:17
I'm actually noticing this line in my output, too
$ pootle webpack --dev
Cannot find module .../lib/python2.7/site-packages/django_extensions/static/js/manifest.json'
phlax
@phlax
Sep 18 2017 12:18
do you have django-extensions installed ?
Johannes Marbach
@Johennes
Sep 18 2017 12:19
Yeah looks like it
$ pip install django-extensions
Requirement already satisfied: django-extensions in .../lib/python2.7/site-packages
phlax
@phlax
Sep 18 2017 12:20
not sure on that one
can you try...
pootle compilejsi18n
and see if that resolves the first issue
re the django_extensions issue - i get that too in my dev env - so i figure its harmless
Johannes Marbach
@Johennes
Sep 18 2017 12:22
Ah, that did it!
Thank you :)
phlax
@phlax
Sep 18 2017 12:22
np - PRs welcome to improve the dev docs 8)
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:04
@phlax pinngggg
phlax
@phlax
Sep 18 2017 13:04
pong
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:06
@phlax how are you doing? Busy?
phlax
@phlax
Sep 18 2017 13:06
available
shall we continue now ?
iirc we were just about to add fs-url and fs-type
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:09
sure
i have like 1 hour
before going out
is that ok
or you prefer tomorrow
phlax
@phlax
Sep 18 2017 13:09
cool - did you have any changes already - can you push them if you do
i can do an hour just now
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:11
great, let's do it
let me check what I had
yes it seems I have something
i will push
@phlax ok I've pushed
can you check it out
phlax
@phlax
Sep 18 2017 13:14
yep, on it
cool - there are a couple of changes needed
im gonna edit the command file, add a test and push back...
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:16
great
phlax
@phlax
Sep 18 2017 13:28
k @jjmcarrascosa pushed back
i made a few changes to the command and added 2 tests
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:29
ok let me check
Ok I've seen the changes in the tests and in the command as well
I've rebased
phlax
@phlax
Sep 18 2017 13:32
great
so im thinking about final steps
one thing i think we should do is to make project code a positional argument, ie
pootle create_project foo0
rather than
pootle create_project --code=foo0
what do you think @jjmcarrascosa ?
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:35
seems more logic
yes
phlax
@phlax
Sep 18 2017 13:37
do you want to do it ?
the tests will need to be altered too
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:37
sure I will do the changes in the command
you can prepare the tests
phlax
@phlax
Sep 18 2017 13:45
ping when you have pushed back
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:50
@phlax ping
phlax
@phlax
Sep 18 2017 13:50
pong
cool, tests pass, pushed back
just checking travis @jjmcarrascosa - seems like there is an issue with docstrings https://travis-ci.org/translate/pootle/jobs/276851579#L5354
there is also another slightly annoying error https://travis-ci.org/translate/pootle/jobs/276851576#L3948
basically - i dont think any other commands use database access in getting there help menu
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:55
ok I will rebase and check
I forgot to do the flake8 revision
phlax
@phlax
Sep 18 2017 13:55
not sure if flake8 would have picked up that one
we use pylint too - i think that was a pylint thing
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:56
yes flake8 doesn't say anytyhing
let me check pylint
phlax
@phlax
Sep 18 2017 13:56
try
make lint-python
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 13:57
doesn't seem to be working, hundreds of "undefined name" for lots of files
but not that error
travis gives
phlax
@phlax
Sep 18 2017 13:58
well - its an easy fix
dammit - i forgot to commit my test changes...
k, pushed back again with updated tests, and a fix for the --help fail
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 14:02
ok
rebasing
phlax
@phlax
Sep 18 2017 14:02
cool
only thing left once the docstring fail is fixed is some code review - @unho would you mind reviewing translate/pootle#6633
im gonna do a quick review too...
hmm, just remmed there are couple of commented out tests - i need to follow those up too
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 14:05
Ok i have rebased
I will go out already in some minutes
take your time to review and write me here or ping tomorrow
ok?
phlax
@phlax
Sep 18 2017 14:06
yep, cool
Jose J. Martinez
@jjmcarrascosa
Sep 18 2017 14:12
ok have a great day!
phlax
@phlax
Sep 18 2017 14:12
laters
Leandro Regueiro
@unho
Sep 18 2017 14:13
Sure, I can review
Leandro Regueiro
@unho
Sep 18 2017 15:15
@jjmcarrascosa @phlax Done with my review of translate/pootle#6633 Ping me again for another review once the raised concerns are addressed.
phlax
@phlax
Sep 18 2017 15:15
@unho you have marked quite a few fields as required - where they have sane defaults already
so not required
Leandro Regueiro
@unho
Sep 18 2017 15:16
I know when a default is present the required might be superfluous. But was trying to make it clear that those fields are actually required.
Maybe I overthought the possibility that someone in the future removed the default without thinking of the consequences.
phlax
@phlax
Sep 18 2017 15:20
that would break the defaults test
Leandro Regueiro
@unho
Sep 18 2017 15:20
k
phlax
@phlax
Sep 18 2017 15:20
and regardless we dont want to make those fields rquired
it would make users type a lot unnecessarily