Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 2019 22:59
  • Jan 31 2019 21:20

    prusnak on new_mem_layout

    make bootloader smaller by cha… (compare)

  • Jan 31 2019 20:52

    prusnak on new_mem_layout

    introduce new memory layout fi… (compare)

  • Jan 31 2019 20:23

    prusnak on master

    format: black uppercase of hex … (compare)

  • Jan 31 2019 20:20

    prusnak on master

    firmware: process tx.branch_id … (compare)

  • Jan 31 2019 20:08

    prusnak on master

    tests: pass branch_id in zcash … (compare)

  • Jan 31 2019 19:53

    prusnak on master

    protob: add branch_id to SignTx… (compare)

  • Jan 31 2019 19:47

    prusnak on master

    defs: fix permissions on png fi… (compare)

  • Jan 31 2019 18:20

    prusnak on master

    signing: use the new hasher_Ini… (compare)

  • Jan 31 2019 18:18

    prusnak on master

    hasher: add param_size to hashe… (compare)

  • Jan 31 2019 18:06

    prusnak on master

    hasher: don't hardcore zcash st… (compare)

  • Jan 31 2019 17:35
  • Jan 31 2019 15:53
    matejcik commented #357
  • Jan 31 2019 14:44

    matejcik on master

    debuglink: add null debuglink, … flake8: add typing imports wher… (compare)

  • Jan 31 2019 05:31
  • Jan 31 2019 02:53
  • Jan 31 2019 02:24
    webees closed #72
  • Jan 31 2019 02:23
    webees edited #72
  • Jan 31 2019 02:23
    webees edited #72
  • Jan 30 2019 19:46
matejcik
@matejcik
@zebpay-peswani how did you get the sighash?
zebpay-peswani
@zebpay-peswani
zebpay-peswani
@zebpay-peswani
but it's for btc and it used to make a get request to bitcoin api. I am looking for bitcoin gold
matejcik
@matejcik
yeah, well, you can't use the tx hash. sighash calculation is rather involved, i suggest you find some sort of library or API call to do it for you
zebpay-peswani
@zebpay-peswani
do you know such library or api? i am finding it but not getting much success.
zebpay-peswani
@zebpay-peswani

@matejcik can you please help. I signed the 2of3 multisig from 2 trezors . Here is hex

0100000001f479528049ee4b235548a7116f5ca31c607728af3d4ac8f102c5be13e93dcca900000000fdfe000048304402201b83bd2209bc101736f60eeec3bcc1f79d45019d1829af97f5bd3210e8d8d786022020954c15372268d299b5463e1335595221e16222aee0291509a2098a0eb7fe804141483045022100d9211fd7074d9c24186722e1e9e0aed81ce12ce2b05892be2eaae3e891ef9aa702203e44d66836eb3d3b5f20736e4b98869f6e8f5f7f70327faf7c009ff2fb6930c9414c69522103556117b3f9a92f2997529af415c2c07185b872ddf1439995eca7f3acb65c58822103917f2527fc394ae2da48ce0148d29e5b756c4d9d180a6762bbe7abe215b29a562103f03364c624889c99059902524bcd8e2b24fb09cceb2e0f895d6475ef4913676553aeffffffff02a08601000000000017a914fd80725877f902f4491a6dc733fe788c376aeff8875033f4050000000017a9149aba36d2c19b08781230a4301f364610a163fc2d8700000000

I can verify this here https://h4x3rotab.github.io/coinbin/#verify

But I am not able to broadcast it

this is the error I am getting -26: mandatory-script-verify-flag-failed (Non-canonical DER signature) (code 16)
zebpay-peswani
@zebpay-peswani
or I tried with
0100000001f479528049ee4b235548a7116f5ca31c607728af3d4ac8f102c5be13e93dcca900000000fdfd000047304402201b83bd2209bc101736f60eeec3bcc1f79d45019d1829af97f5bd3210e8d8d786022020954c15372268d299b5463e1335595221e16222aee0291509a2098a0eb7fe8041483045022100d9211fd7074d9c24186722e1e9e0aed81ce12ce2b05892be2eaae3e891ef9aa702203e44d66836eb3d3b5f20736e4b98869f6e8f5f7f70327faf7c009ff2fb6930c9414c69522103556117b3f9a92f2997529af415c2c07185b872ddf1439995eca7f3acb65c58822103917f2527fc394ae2da48ce0148d29e5b756c4d9d180a6762bbe7abe215b29a562103f03364c624889c99059902524bcd8e2b24fb09cceb2e0f895d6475ef4913676553aeffffffff02a08601000000000017a914fd80725877f902f4491a6dc733fe788c376aeff8875033f4050000000017a9149aba36d2c19b08781230a4301f364610a163fc2d8700000000
Hey Sorry to disturb I got it broadcasted. the sig input should be without 41 at the end of it.
micah
@micah
Can this room have gitlab login enabled? Its only github :o
matejcik
@matejcik
@micah done, let's see what happens
zebpay-peswani
@zebpay-peswani
@matejcik is there any any limit on number of signatures for inputs in trezor. suppose I want to send thousands of btg from trezor will there be any issue on signing that big transaction on trezor.?
Andelf
@andelf
Will legacy firmware(Trezor One) accept new Coins? (not a forked coin, totally a new chain)
matejcik
@matejcik
@andelf we're in the middle of porting the core codebase to T1. so no new features into the legacy codebase will be accepted, but eventually the same implementation may end up on the T1 (modulo RAM and storage constraints)
zebpay-peswani
@zebpay-peswani
I am suddenly getting trezorlib.exceptions.TrezorFailure: DataError: Encountered invalid prevhash any reason for this
matejcik
@matejcik
@zebpay-peswani you're providing bad previous transaction data
zebpay-peswani
@zebpay-peswani
zebpay-peswani
@zebpay-peswani
utxo['txnId'] is 9ba8efa26d4828c07f61950ba245b98a34e0eec192c25cf3c2098d4ab0abc20b
zebpay-peswani
@zebpay-peswani
the code was working fine until yesterday.
Andelf
@andelf
@matejcik Thanks for your information. When will the porting task finish?
matejcik
@matejcik
@andelf no eta 🤷‍♀️
@zebpay-peswani probably you suddenly started providing bad transaction data
Andelf
@andelf
@matejcik 😃OK. Will new features accepted for core codebase?
matejcik
@matejcik
@andelf in general yes, but of course this is a per feature decision
zebpay-peswani
@zebpay-peswani

@matejcik I am always getting fresh tx data in cache

```

    def save_decoded_transaction_in_cache(tx_hash):
        print(tx_hash)
        # if Path(__file__).parent.parent.joinpath(Path('txcache/bgold/' + tx_hash + ".json")).exists():
        #     return
        req = requests.get('https://explorer.bitcoingold.org/insight-api/tx/' + tx_hash)
        j = req.json()
        vins = j['vin']
        vouts = j['vout']

        inputs = []

        bin_outputs = []
        for ins in vins:
            data = {'prev_hash': ins['txid'], 'prev_index': ins['vout'], 'script_sig': ins['scriptSig']['hex'],
                    'sequence': ins['sequence']}
            inputs.append(data)
        for vout in vouts:
            data = {'amount': int(float(vout['value']) * (10 ** 8)), 'script_pubkey': vout['scriptPubKey']['hex']}

            bin_outputs.append(data)

        # print(inputs)
        # print(bin_outputs)
        tx = {"bin_outputs": bin_outputs, "inputs": inputs, 'lock_time': j['locktime'], 'version': j['version']}

        Path(__file__).parent.parent.joinpath(Path("txcache/bgold/" + tx_hash + ".json")).open(mode='w').write(
            tx.__str__().replace("'", "\""))
matejcik
@matejcik
@zebpay-peswani int(float(vout['value']) * (10 ** 8)) this is incorrect
you're gonna get rounding errors
zebpay-peswani
@zebpay-peswani
what should I use?
matejcik
@matejcik
i'd tell you to use trezorlib.btc.from_json, but i believe the same bug is there right now
lessee
this is the right code: amount=int(Decimal(vout["value"]) * (10 ** 8))
zebpay-peswani
@zebpay-peswani
okay
but error is wrong prevhash
matejcik
@matejcik
yes, well, you're sending a transaction from cache whose data does not match the prevhash that you claim
so either the prevhash is bad or the transaction is bad, Trezor can't tell which
zebpay-peswani
@zebpay-peswani
Thanks a lot!! you are right.
now i can sign
Starsakary
@Starsakary
@matejcik Hi there, I've seen you had a porting process currently, will you accept new coins in the future?
matejcik
@matejcik
@Starsakary we are still accepting coins. but we only consider a coin for acceptance if it's in Top 30 by market cap.
also we're considering tighter integration of Suite and the firmware, and possibly in the future we might only accept contributions that also add Suite support for the coin in question.
this is not the official stance yet though
Starsakary
@Starsakary
Well, we'd like to add Tron(TRX) and it's now 16th on Coinmarketcap. We've done over 50% of the coding work.
As I haven't got feedback in my issue, should we stop developing?
matejcik
@matejcik
@Starsakary I mean, yeah, probably you should stop for now. Your issue is waiting on a product decision, which has not been made yet. Feel free to ping the issue, but I'm not saying you will get an answer that way. Basically by building the code now you're taking a risk that the company will reject it in the end, or impose additional limitations that will not be acceptable for you.
Starsakary
@Starsakary
Sure thanks. We'll stop it for now. Would you please give us a confirmation or rejection when your decision is made?
matejcik
@matejcik
And furthermore this is not a channel to get the answers you're looking for. I understand that this is frustrating, believe me, i'd hate it if i were in your place. But also I can't do anything for you, I'm not a SatoshiLabs representative in any way, I'm just a very knowledgeable dev.
@Starsakary you'll get the response in the issue you created
Starsakary
@Starsakary
alright thank you so much