Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 16 2018 05:07
    DanVanAtta commented #90
  • Jan 16 2018 03:12
    DanVanAtta commented #93
  • Jan 16 2018 01:39
    ssoloff commented #90
  • Jan 16 2018 00:18
    DanVanAtta closed #16
  • Jan 16 2018 00:18
    DanVanAtta commented #16
  • Jan 15 2018 22:32
    DanVanAtta closed #87
  • Jan 15 2018 22:32
    DanVanAtta commented #87
  • Jan 15 2018 22:31
    DanVanAtta closed #88
  • Jan 15 2018 02:38
    beelee1 closed #92
  • Jan 14 2018 21:17
    beelee1 commented #92
  • Jan 14 2018 21:17
    ron-murhammer commented #92
  • Jan 14 2018 21:13
    ron-murhammer commented #92
  • Jan 14 2018 21:12
    ron-murhammer commented #92
  • Jan 14 2018 21:10
    beelee1 commented #92
  • Jan 14 2018 04:34
    ssoloff commented #90
  • Jan 14 2018 04:33
    ssoloff commented #90
  • Jan 13 2018 18:32
    ssoloff commented #90
  • Jan 13 2018 18:22
    ssoloff commented #90
  • Jan 13 2018 12:14
    beelee1 commented #92
  • Jan 13 2018 12:12
    beelee1 commented #92
Dan Van Atta
@DanVanAtta
This message was deleted
Dan Van Atta
@DanVanAtta
some documentation on how to update triplea_maps.yaml: https://github.com/triplea-maps/Project/wiki/Update-Triplea_maps.yaml
Dan Van Atta
@DanVanAtta
some more documentation updated, the readme is updated: https://github.com/triplea-maps/Project/blob/master/README.md
or you can view it here in non-blob form: https://github.com/triplea-maps/Project
KaiMAD
@KaiMAD
Should I perhaps begin changing "attatch" to "attach" in each of the maps included with TripleA? Or should I do something else? (I am still a little unclear on my priority chain/agenda as Abandoned Map Updater...)
Dan Van Atta
@DanVanAtta
Sorry, I'm not even clear on that myself. I think there is a good chance...
@KaiMAD triplea-game/triplea#558 It's looking like the answer is yes.
Dan Van Atta
@DanVanAtta
Okay @KaiMAD , we're proceeding with the rename of "attatch" to "attach". The game engine was just updated, so any version after 1.8.0.10.1252 will want maps that have the correct spelling. All maps in triple-maps have been updated (though note to self: will need to double check invasion_usa which was added recently)
Dan Van Atta
@DanVanAtta
@/all some new documentation on checking map versions that are registered with the game: https://github.com/triplea-game/triplea/wiki/Checking-Map-Versions, checks if any can be updated in triplea_maps.yml to a newer version
KaiMAD
@KaiMAD
I have all occurrences of 'attatch' replaced with 'attach' in all of the maps currently included with TripleA. Where should I post/upload these versions?
KaiMAD
@KaiMAD
Ah. I found the list of maps, and I see where the 'attatches' are being replaced with 'attach.' Never mind. I am still getting used the GitHub system.
Dan Van Atta
@DanVanAtta
@williamdekryger http://tripleadev.1671093.n2.nabble.com/maps-missing-from-triplea-maps-yaml-tp7591765p7591973.html The topic of how to store info wiht maps has come up.
We were talking about this for the website. The desire was there to have a standard location for the thumbnail images, etc..
If we can hijack the README.md of each map repo, I think that would be easy/slick. Otherwise config file might be it. I'm curious if anyone can think of alternative ways of attaching metadata to maps, such as the game notes, whcih can then be used again by the website and map download description text. And we need standard images for each map as well, which is sometimes missing or included in relatively random locations.
Dan Van Atta
@DanVanAtta
updated: https://github.com/triplea-game/triplea/wiki/Code-Guidelines, has a new name, when before it was called 'Code Standards'. The page documents some good baseline java best practices. The idea is to avoid surprises and redundancy in code reviews by spelling out some of the common baseline best practices.
KaiMAD
@KaiMAD
Hello, I'm trying to modify a map, but I keep getting a NullPointer java error. I forgot what this means, but I get it every time I try to edit or create a new map. Could someone please give me the basics of what it means in terms of TripleA maps, or direct me to someone/somewhere who/which will explain this? Thank you, I realize this isn't quite a help forum.
FrostionAAA
@FrostionAAA
@KaiMAD Could it be something to do with a unit not having a price tag in the productionRule section. I know this can trigger a "null"-something error.
Dan Van Atta
@DanVanAtta
@KaiMAD need the full error message , null pointers can happen in a number of places unfortunately.
FrostionAAA
@FrostionAAA
I just have a question. Where do one comment on and give feedback regarding the pre-release version of TripleA?
I have not played 1.9.0.0.1974, but the 1950 version does not play most of the sounds that maps have, not only my maps but I think all maps in general. It is the basic sounds like combat moves and combat sounds that are not being played.
Dan Van Atta
@DanVanAtta

If you think it might be a game engine problem: https://github.com/triplea-game/triplea/issues/new
If it's a problem with map configurations: https://github.com/triplea-maps/Project/issues/new

Are the files not being played wav files, or mp3?

FrostionAAA
@FrostionAAA
I think all the maps under 1.9.0.0.1950 tries to play mp3. The first map I started was the tutorial as it is the only map that comes with the download. It only plays some sort of intro music. When I do any combat moves there is no sound. Then I downloaded, via the in-game download, World War II Classic map. The only sound in that map seems to be the intro sound. I assume that this map gets it sound from TripleA\1.9.0.01950\assets\sounds\ww2. There is no soundfiles in the downloadedMaps world_war_ii_classic.zip. As I said, I also downloaded my own maps, and they now come with mp3s. But they also only play into music. And yes, I also looked at the ingame "sound options" settings to see what sounds are set to play ;) I will look at the two links you posted.
Dan Van Atta
@DanVanAtta
Might be a miss in the sound.properties files, some of them may still have *wav file paths instead of *.mp3
FrostionAAA
@FrostionAAA

I got two questions:
What is the estimated ETA on the v1.9 release of TriplA? Is it like 1 month? Three months? Or not answerable?

Also, when editing the triplea_maps.yaml, can a map be named ”mapName: Star Trek: Dilithium War” with a colon? Or should I remove the colon?

There seems to be many variations of map naming in the working triplea_maps.yamls file. Like: “MiniMap” (with no spaces), “The Pact of Steel” (with space), ” Total_World_War” (with underscores) and “1914-COW-Empires” with hyphen). Are all these variations just remnants of a time where spaces made trouble for some computers? A sourceforge issue that is no longer relevant after v1.9? I assume everyone can download “The Pact of Steel” map in v1.9, right?

Dan Van Atta
@DanVanAtta
I would say at this point about 6 weeks for v1.9
it does depend on how quickly we can get the current PR queue reviewed. We are bottlenecked at development review.
That update should be fine @FrostionAAA - though you can test it locally to be sure.
In game_engine.propeties, look for:
#Map_List_File = triplea_maps.yaml

Map_List_File = http://raw.githubusercontent.com/triplea-maps/Project/master/production_config/triplea_maps.yaml?raw=true

Change that to:


Map_List_File = triplea_maps.yaml

#Map_List_File = http://raw.githubusercontent.com/triplea-maps/Project/master/production_config/triplea_maps.yaml?raw=true

And then make sure you have a copy of triplea_maps.yaml in your triplea folder

At that point you should be able to modify the file, and see updates locally
FrostionAAA
@FrostionAAA

OK, so by moving that # in the game_engine.propeties I can make TripleA to look in the TripleA directory for the yaml file (that I can edit locally and test out)? And I should download current yaml file from https://github.com/triplea-maps/Project/tree/master/production_config and place it in my the TripleA dir? Then edit that file, and when it all seems to work I can drag and drop it onto the old triplea_maps.yaml file on Github? And that would be a pull request?

If this is the case I should probably withdraw the “Adding Age of Tribes v1” pull request and come with just one new pull request that has the edits for all my maps at once.

FrostionAAA
@FrostionAAA
Just something else, why has the builderbot made some “drafts” of some of my maps? Like here https://github.com/triplea-maps/star_wars_galactic_war/releases There are not builderbot “drafts” present in all of my maps at Github, only in the Star Wars Galactic and Tatooine War maps.
I guess the download link in the yaml files must be the latest releases and have the version designations in the XML correspond with the one stated in the yaml file, right?
Dan Van Atta
@DanVanAtta

"If this is the case I should probably withdraw the “Adding Age of Tribes v1” pull request and come with just one new pull request that has the edits for all my maps at ot once"

I actually disagree with this a bit. PRs are best when they are as small as possible and independent. That way one problem in one part will not impact the rest of hte work. Git should be able to auto-merge the modifications so long as they happen to different parts of the files. But, really whatever you find to be easiest.

"Just something else, why has the builderbot made some “drafts” of some of my maps?"

That is Travis failing to push artifacts to Github. You should be able to re-kick the build in travis. Find your map repo in travis: https://travis-ci.org/, then look for the circle icon below "More Options" to restart the build. Any draft releases you get, click through on edit, and simply delete them to get rid of them.

"I guess the download link in the yaml files must be the latest releases and have the version designations in the XML correspond with the one stated in the yaml file, right?"

Yes to the first question, the download link URL should be the latest download URL available. On PRs I check that the link specified resolves to a file. It is also possible to check what has changed as well, so there is still some admin control to make sure that not just whatever can be added to a map and then downloaded to the end users.

The version number does not have to correspond to anything right now.. The version numbering for maps is a bit confused, IIRC there used to a version number in the old triplea_maps.xml. I think a future direction will be to remove version numbers and just get the version number from the download URL.

FrostionAAA
@FrostionAAA

I think it is a good idea if the yaml file did not have to state a version number. But right now it seems that if I remove a yaml line like “version: 1.4.1” it results in the TripleA map download windows to state “vnull” where the version number was before. So right now I will edit the yaml file with my six map listings and include all version numbers. I guess you developers will just remove all version lines in the yaml file if you want them gone.

I have written this elsewhere, but I will just say it again; I think it would be nice and map-maker-user-friendly if the TripleA download maps window had a map list link now, but the right side of the window (where the map descriptions are) got its description information from a file located in every single map’s own directory at github. I think the current yaml file is huge and the list of maps will probably grow by time, making it more confusing to edit. Maybe the developers could just administrate the “list” in the left side of the download screen, and the mapmaker had the responsibility to put the right info in his own map specific yaml-file located in his github map dir. Parallel to my maps’ “map” main dir, I now have a “description” dir containing only the 400px prewiev picture. Such a dir could also countain other files I guess?

But I am only guessing, you are the one with knowledge about what is smart and possible with the game engine. ;)

FrostionAAA
@FrostionAAA
FrostionAAA
@FrostionAAA

I think I have edited the yaml file correctly now and added downloads and descriptions to my maps (Age of Tribes, Caribbean Trade War, Dragon War, Star Trek and the two Star Wars maps).

But when I run one of the maps after download I get an error that is similar to this here: “INFO: Found too many files for… (then the names of some maps, not limited to the one that is being played)”. Do you know the reason for this error? On the forums I can only see the error briefly mentioned here by aaalafayette:
http://tripleadev.1671093.n2.nabble.com/Next-release-1-8-0-11-testers-wanted-td7590912i20.html#a7591727

Can I just drag and drop this new yaml on the old one at Github? Or is this error message an issue?

Dan Van Atta
@DanVanAtta
game engine would be picking up multiple copies of the map
on a clean install, i do not think it will be a problem (multiple maps found error). But we should verify that as best as possible.
Cernelius
@Cernelius
Please, can anyone tell me what is the last TripleA 1.9 version that actually allows joining the lobby? Also, I think not being able to join the lobby is lame.
Dan Van Atta
@DanVanAtta
agree @Cernelius . Blame old-school java circa ~2002 for the problem.. For which version, it has been some time. I would look about 500 builds ago.
an updated lobby should be up and running at some point soon'ish though.
also FYI, there are a couple of gitter channels, this one is for the game engine proper: https://gitter.im/triplea-game/social
Cernelius
@Cernelius
Thanks
theredbaronaaa
@theredbaronaaa
Does anyone know why all of the maps in triplea_maps.yaml are listed as being at version 1? @DanVanAtta any ideas?
Dan Van Atta
@DanVanAtta
version =1 in the maps.yaml refers to the download versoin. We had a mixture of values, they were reset since they are all effectively 2.0
there is also no strict relationship between the version in XML, and the version in the maps.yaml file. Mandating they stay the same is silly, we should just use one in that case. As is, they are used for different purposes.
theredbaronaaa
@theredbaronaaa
True, but I'd like to have the version in the XML somewhere in the YAML, so that I can have it in the maps listing.
Cernelius
@Cernelius
Just keep in mind that maps can have multiple XML, with different versions, and mapskins have no XML,
thus no version. I believe having the map version equal to the version of an XML inside was a bad practice, for reasons I would discuss inside an open issue.