Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 31 2019 15:58
    truckingsim commented #152
  • Jan 31 2019 15:16
    RomanRabirokh commented #152
  • Jan 31 2019 15:05
    jcrawford commented #152
  • Jan 31 2019 15:05
    jcrawford reopened #152
  • Jan 31 2019 15:05
    jcrawford commented #152
  • Jan 31 2019 14:48
    RomanRabirokh commented #152
  • Jan 31 2019 14:42
    jcrawford commented #152
  • Jan 31 2019 14:42
    jcrawford closed #152
  • Jan 31 2019 14:42
    jcrawford commented #152
  • Jan 31 2019 14:40
    RomanRabirokh commented #152
  • Jan 26 2019 07:36
    masteriii commented #163
  • Jan 24 2019 17:43
    truckingsim commented #163
  • Jan 24 2019 11:43
    masteriii edited #163
  • Jan 24 2019 11:40
    masteriii opened #163
  • Jan 20 2019 18:47
    Itay4 opened #162
  • Nov 28 2018 09:33
    agil-NUBBA closed #150
  • Nov 28 2018 09:33
    agil-NUBBA commented #150
  • Nov 28 2018 09:08
    reloxx13 commented #83
  • Nov 28 2018 08:46
    reloxx13 commented #83
  • Nov 28 2018 08:24
    reloxx13 commented #150
Adam Heim
@truckingsim
its so hard to read
my eyes are terrible I have zoom everything
Mark Carver
@markcarver
:(
Adam Heim
@truckingsim
and 2 just makes everything so damn close
Mark Carver
@markcarver
are you using a monospaced font :-p
Adam Heim
@truckingsim
yeah
Mark Carver
@markcarver
bleh
markcarver @markcarver grumbles and accepts, again
Mark Carver
@markcarver
:-p
Adam Heim
@truckingsim
lol sorry :p if my eyesight weren't so damn terrible I would be down.
Mark Carver
@markcarver
@truckingsim thoughts?
Adam Heim
@truckingsim
@markcarver left a comment on the PR
didn't see the mention on here first.
also we should really update our node version for travis...its trying to run on 0.10
screw that
Mark Carver
@markcarver
ugh
why is it failing on installing commitizen???
@truckingsim i'm running node 7
and npm 4.2
any reason why we can't bump travis' node.js version to 7?
Mark Carver
@markcarver
@truckingsim ok, travis passes now
Adam Heim
@truckingsim
can you just do 6, 6 is the lts
sorry for not specifying
even's are LTS's, odd versions are current
I'm thinking specifically for the engine thing in package.json, less worried about travis's version(s)
Mark Carver
@markcarver
@truckingsim done
went ahead and added testing for both
Adam Heim
@truckingsim
Perfect :+1:
Approved for merging
Mark Carver
@markcarver
@truckingsim I'm going to merge this into master too
so we can at least get the markdown files in the master branch
Adam Heim
@truckingsim
what uses that pull request template? Just realized that's on root, github has a way to make it auto prefill the text area
It has the right file name, but I thought it had to be in a .github folder.
Mark Carver
@markcarver
that's optional
according to GH's docs
it can be in the root folder or a .github folder
Adam Heim
@truckingsim
huh TIL
@markcarver I added eslint to #114 since I can build that into webpack actually so errors show in the compiled output
Mark Carver
@markcarver
yeah, I'm doing eslint now
Adam Heim
@truckingsim
if you do it just check it off in 114
Mark Carver
@markcarver
granted... via grunt :-/
yep
question
Adam Heim
@truckingsim
I wouldn't worry about shoving it into grunt for now
Mark Carver
@markcarver
if we're going to do webpack, will we need grunt?
Adam Heim
@truckingsim
I'm going to do everyting in my power to not need grunt
Mark Carver
@markcarver
well, the reason I'm doing it via grunt now is because that's how it's currently setup
it runs everything through grunt
Adam Heim
@truckingsim
yeah I nknow
I've been at work since 7:30 this morning, I have no intentions of staying late. I'm hoping I can get home and with it still being light out not tired and trying to work on revamping the build stuff.