truckingsim/Ajax-Bootstrap-Select

This uses the bootstrap-select plugin and extends it so that you can use a remote source to search.

Mark Carver

@markcarver

ugh

why is it failing on installing commitizen???

@truckingsim i'm running node 7

and npm 4.2

any reason why we can't bump travis' node.js version to 7?

Mark Carver

@markcarver

@truckingsim ok, travis passes now

Adam Heim

@truckingsim

can you just do 6, 6 is the lts

sorry for not specifying

even's are LTS's, odd versions are current

I'm thinking specifically for the engine thing in package.json, less worried about travis's version(s)

Mark Carver

@markcarver

@truckingsim done

went ahead and added testing for both

Adam Heim

@truckingsim

Perfect :+1:

Approved for merging

Mark Carver

@markcarver

@truckingsim I'm going to merge this into master too

so we can at least get the markdown files in the master branch

Adam Heim

@truckingsim

what uses that pull request template? Just realized that's on root, github has a way to make it auto prefill the text area

It has the right file name, but I thought it had to be in a .github folder.

Mark Carver

@markcarver

that's optional

according to GH's docs

it can be in the root folder or a .github folder

Adam Heim

@truckingsim

huh TIL

@markcarver I added eslint to #114 since I can build that into webpack actually so errors show in the compiled output

Mark Carver

@markcarver

yeah, I'm doing eslint now

Adam Heim

@truckingsim

if you do it just check it off in 114

Mark Carver

@markcarver

granted... via grunt :-/

yep

question

Adam Heim

@truckingsim

I wouldn't worry about shoving it into grunt for now

Mark Carver

@markcarver

if we're going to do webpack, will we need grunt?

Adam Heim

@truckingsim

I'm going to do everyting in my power to not need grunt

Mark Carver

@markcarver

well, the reason I'm doing it via grunt now is because that's how it's currently setup

it runs everything through grunt

Adam Heim

@truckingsim

yeah I nknow

I've been at work since 7:30 this morning, I have no intentions of staying late. I'm hoping I can get home and with it still being light out not tired and trying to work on revamping the build stuff.

Al Grant

@bigalnz

You there Adam?

Adam Heim

@truckingsim

@markcarver you around?

what do you think about how to deal with the old code before we've got everything done. We probably want to use the src/js/ folder for the new stuff.

Mark Carver

@markcarver

@truckingsim honestly, because we're not using LESS or SASS, we can just move the JS files to src

we don't need an extra "js" level

so we can leave the old stuff in JS until it's converted to es6 and placed directly in src

Adam Heim

@truckingsim

I can live with that

Al Grant

@bigalnz

Adam. you here?

Adam Heim

@truckingsim

@markcarver you around?

Al Grant

@bigalnz

Hey Adam - are you about for a question about the select?

@truckingsim ping

Adam Heim

@truckingsim

I am no guarantees on an answer though

Al Grant

@bigalnz

I had this code

// CODE FOR SELECT PICKER CODE DROP DOWN
function updatecodepicker() {
$('.stats:last .selectpicker').not('.stats-code-picker').selectpicker();
$('.stats-code-picker').selectpicker().ajaxSelectPicker({
ajax: {
url: '/offences',
dataType: 'json',
type: 'GET'
},
log: 4,

        preprocessData: function (data) {
            var offences = [];
            data.forEach(function (item) {
                offences.push({
                    value: item.code,
                    text: item.chargeText
                });
            });
            return offences;
        },
    })
}

ugh- lemme paste again

Where communities thrive

People

Repo info

Activity