These are chat archives for truetandem/fedramp-dashboard

29th
Jun 2016
Bryan Allred
@bmallred
Jun 29 2016 12:08
@vzvenyach looks like it there was a deployment error at line 834 in the TravisCI logs.
Jessie
@jposi
Jun 29 2016 13:01
added a video call to the meeting invite - sorry for the delay
Jessie
@jposi
Jun 29 2016 14:41
where is the planning poker link?
Jessie
@jposi
Jun 29 2016 14:41
found it
ok
John Flores
@floresj
Jun 29 2016 15:11
WHOOHOOO!
All of the nerdy things
V David Zvenyach
@vzvenyach
Jun 29 2016 15:15
truetandem/fedramp-dashboard#7 << So, this should work for everyone
Bryan Allred
@bmallred
Jun 29 2016 15:20
awesome :) we'll merge it in a few
John Flores
@floresj
Jun 29 2016 15:20
@lauraGgit Would you suggest forcing a fail if jshint comes back with an error? Or just letting it continue?
Bryan Allred
@bmallred
Jun 29 2016 15:21
@floresj on that note i did add a .jshintrc file to account for es6
John Flores
@floresj
Jun 29 2016 15:22
@bmallred yessssir I saw that. Gracias
Laura Gehardt
@lauraGgit
Jun 29 2016 15:43
@Jay-Neighbours-I72 here is the line in the USWDS that notes the screen widths: https://github.com/18F/web-design-standards/blob/staging/src/stylesheets/core/_variables.scss#L76
@floresj I think that is a matter of preference
Bryan Allred
@bmallred
Jun 29 2016 15:45
@vzvenyach Skipping a deployment with the s3 provider because this repo's name does not match one specified in .travis.yml's deploy.on.repo: 18F/fedramp-dashboard
should the repo name be truetandem/fedramp-dashboard?
V David Zvenyach
@vzvenyach
Jun 29 2016 16:47
so. @bmallred, right now, i have it set up for deploy to s3 on merge to master on 18F/fedramp-dashboard. we could set it for truetandem/fedramp-dashboard. :shrug:
let's leave it as is, and I'll chat with the team about their preference.
Bryan Allred
@bmallred
Jun 29 2016 16:48
good to go
Jay Neighbours
@Jay-Neighbours-I72
Jun 29 2016 16:56
got it, thanks @lauraGgit
John Flores
@floresj
Jun 29 2016 17:01
@lauraGgit @vzvenyach @bmallred I'll start out with a passive approach and not kill the build if any lint errors are found. If we find that it starts to be a problem, we can add it in. I'll comment out the line that enables it to fail if we want to turn it on again later. Bryan and I both point to the same .jshintrc for our emacs/vim config so you can blame us if the build fails :smile: