Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Manuel Bojato
    @KingDarBoja
    typescript-eslint/tslint-to-eslint-config#724 I mean this
    Josh Goldberg
    @JoshuaKGoldberg
    Yeah I found that one to be tricky too...
    Josh Goldberg
    @JoshuaKGoldberg
    was kinda glad you were interested in tackling it :P
    Josh Goldberg
    @JoshuaKGoldberg
    image.png
    Manuel Bojato
    @KingDarBoja
    LMAO
    Too bad I am lacking some free time, been contributing to some stuff and now I am slighty lazy because work is boring and I just take the night to relax with my girlfriend D:
    I will tackle it again this weekend D:
    Josh Goldberg
    @JoshuaKGoldberg
    <3
    Manuel Bojato
    @KingDarBoja
    :v
    Josh Goldberg
    @JoshuaKGoldberg
    Oh wow @KingDarBoja you've been busy the last couple weeks! :smile:
    Very nice. I'll go through the stuff now and push out a new beta release with the rxjs rules so far...
    Do you have an opinion on typescript-eslint/tslint-to-eslint-config#732 (Node API)? I can merge it now, or wait for you to review if you'd prefer!
    Manuel Bojato
    @KingDarBoja
    I am okay with that being merged, really haven't tested it at all but changes looks pretty good
    Btw, wtf is going on with renovate :D
    I think cson-parser next release will fix the engine check that is causing such artifact problem
    groupon/cson-parser#87
    Josh Goldberg
    @JoshuaKGoldberg
    Yeah idk, 15 > 8 last time I checked ?!
    They're all going away on rerun / merge from main 🤷‍♂️
    Manuel Bojato
    @KingDarBoja
    lol
    Josh Goldberg
    @JoshuaKGoldberg
    Actually maybe they had a release where they forgot to use numeric comparisons in the version check, then rolled it back... amusing
    Manuel Bojato
    @KingDarBoja
    Heh
    Checking rxjs converters, good thing all those converters are 1:1
    Btw join Angular discord mate!
    https://discord.gg/AMbCxYs8
    There has been some talk about the library :D
    Josh Goldberg
    @JoshuaKGoldberg
    👀👀👀
    Manuel Bojato
    @KingDarBoja
    Yeah, mostly about community wanting ESLint at Angular
    And some request of using it for the schematics, which I think James Henry is doing that with such API request
    https://github.com/typescript-eslint/tslint-to-eslint-config/pull/732#issuecomment-723611956 btw, merge conflicts lol
    Josh Goldberg
    @JoshuaKGoldberg
    love to see it
    Oh man I missed the summons, ah well
    Manuel Bojato
    @KingDarBoja
    hahahaha
    Josh Goldberg
    @JoshuaKGoldberg
    😂
    Manuel Bojato
    @KingDarBoja
    :D
    Manuel Bojato
    @KingDarBoja
    Ooops tests broke on latest PR merge
    Josh Goldberg
    @JoshuaKGoldberg
    hmm, works for me
    oh ha here we go.. no-implicit-any-catch.test..ts :P
    Josh Goldberg
    @JoshuaKGoldberg
    Fixed 👍
    @KingDarBoja similar question for you on typescript-eslint/tslint-to-eslint-config#821 -- do you want to review?
    Manuel Bojato
    @KingDarBoja
    Sure, let me take a look this week, this weekend I will be out :D
    Josh Goldberg
    @JoshuaKGoldberg
    super, thanks!
    Manuel Bojato
    @KingDarBoja
    Meh, ran out of time, I asked on the angular discord for some help for testing it as I will be out this weekend until Wednesday x.x
    Josh Goldberg
    @JoshuaKGoldberg
    Works for me! I'll merge it in for now and publish a full 2.0 stable release. 🚀
    Manuel Bojato
    @KingDarBoja
    Ha, tried to use the schematic from angular-eslint on a nx workspace (Angular 10)
    Got an error:
    $ ng add @angular-eslint/schematics

>  NX   WARNING  The Angular CLI was invoked instead of the Nx CLI. Use "npx ng [command]" or "nx [command]" instead.

Your global Angular CLI version (11.0.2) is greater than your local version (10.2.0). The local Angular CLI version is used.

To disable this warning use "ng config -g cli.warnings.versionMismatch false".
Installing packages for tooling via yarn.
Installed packages for tooling via yarn.

Error: Angular CLI v10.1.0 and later (and no `tsconfig.base.json`) is required in order to run this schematic. Please update your workspace and try again.
    My Angular CLI at the package.json is "@angular/cli": "~10.2.0"
    Manuel Bojato
    @KingDarBoja
    Already submitted a ticket at angular-eslint repo
    angular-eslint/angular-eslint#191
    Josh Goldberg
    @JoshuaKGoldberg
    fun
    Manuel Bojato
    @KingDarBoja
    :P