Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Christopher Coco
@cacoco
also, would love a Jhipster for Finatra. We had lightbend activator templates, but alas.
sinanspd
@sinanspd
I can try to look into that as well. I am just the most familiar with Finatra since I did some work on it back when I was with DES but happy to lend a hand where ever
I will 100% get that done in the coming months, ready to go with Angular 8, generated email, auth, notification streams etc. I built so many full stack services with similar structure past year with many more to come that I personally could use it :)
Christopher Coco
@cacoco
:thumbsup:
Alessandro Vermeulen
@spockz
Something else. We are receiving reports from some of users that TLS renegotiation doesn’t work when using netty-tcnative-boring-static and if they switch to netty-tcnative (with openssl) it works. Do you have any reports or ideas on this?
Alessandro Vermeulen
@spockz
How important is "-Yno-adapted-args” for scrooge?
Christopher Coco
@cacoco
@spockz not sure anymore. We patched something in this area sometime ago. cc @yufangong
Alessandro Vermeulen
@spockz
Hmm, is it expected that bijection is last updated 2 years ago?
@cacoco ok. Are you using boringssl in produciton or still openssl?
Christopher Coco
@cacoco
production is openssl. don’t recall what the boringssl is for outside of testing. cc @mosesn
Alessandro Vermeulen
@spockz
Ok. Interesting choice then to make boringssl the native packaged ssl implementation :)
Alessandro Vermeulen
@spockz
Right… I read that the other way around. Boringssl was made the default (inferred by me because used by twitter) but a mechanism was created to be able to revert to some other implementation
Btw. I have an issue cross building scrooge/bijection-core because it appears as if the scala-collection-compat lib isn’t there for 2.10
Yufan Gong
@yufangong
@spockz not sure anymore. We patched something in this area sometime ago. cc @yufangong
I found this issue ask for "-Yno-adapted-args"
twitter/scrooge#277
Alessandro Vermeulen
@spockz
@yufangong so that flag went away in 2.13
Yufan Gong
@yufangong
I think we can either find other ways to avoid that warning or tolerant it if we want to move to 2.13 (which i think we do)
Alessandro Vermeulen
@spockz
I agree :)
Alessandro Vermeulen
@spockz
@martijnhoekstra How far along are you? I have bijection-core compiling with 2.13 now, there are quite some things to 'fix' in finagle :)
Many uses of Buffer/ArrayBuffer which are used as a Seq but in 2.13 are not a Seq anymore
Martijn Hoekstra
@martijnhoekstra
@spockz -> twitter/finagle#788
the pattern I used before for the Buffer/ArrayBuffer thing is to turn them into a Builder (ListBuilder of VectorBuilder, whichever seemed most appropriate) and return its .result
Alessandro Vermeulen
@spockz
Interesting. I used toSeq in making Scrooge 2.13 compatible: https://github.com/twitter/scrooge/compare/develop...spockz:upgrade-to-213?expand=1
So I also had to reference to Breakout and such
I'm not seeing them in your MR. Did you do those as well and just not push or are there other avenues?
Martijn Hoekstra
@martijnhoekstra
looks mostly the same, actually
I don't see the breakout
Alessandro Vermeulen
@spockz
I mean in your MR of finagle, I don't see removing of breakOut or Ordering.Double.TotalOrdering.compare(x.fraction, y.fraction)
I'm basing my work of 5c0586395a549eef22812502de44ce63fc7eaab6.
Martijn Hoekstra
@martijnhoekstra
I'm counting 6 breakouts removed
Alessandro Vermeulen
@spockz
Oof indeed. Okay. Going to stop now, apparently it is late. :)
Martijn Hoekstra
@martijnhoekstra
haha
yeah
Alessandro Vermeulen
@spockz
The Ordering one is really not there though
Martijn Hoekstra
@martijnhoekstra
what happened to that ordering, I don't know, but I know I did something with a Double ordering somewhere
maybe in a file I didn't check in (e.g. not in finagle-core)?
Alessandro Vermeulen
@spockz
finagle-toggle/src/main/scala/com/twitter/finagle/toggle/ToggleMap.scala
I'm not sure if there is a nice way to make that compile in pre 2.12 and 2.13
Are we going to introduce helper methods in objects that have different implementations in scala-2.12 and 2.13 source directories?
Martijn Hoekstra
@martijnhoekstra
I did private[this] val MetadataOrdering: Ordering[Toggle.Metadata] = Ordering.by((md: Toggle.Metadata) => (md.id, md.fraction))
that picks up the deprecated Double ordering on 2.13, but that seems minor in the grand scheme of things
Alessandro Vermeulen
@spockz
Makes sense indeed
It appears you are well underway. What do you need help with?
Martijn Hoekstra
@martijnhoekstra
there is a test failing on finagle-core, I don't know why
well, basically the comments I made on the PR for core
For tomorrow, I suppose
Federico Cocco
@fredc0088
@here hello. is there a way to avoid the whole stacktrace to be logged in with exceptions when calling an http endpoint? I'm using LoggingMDCFilter and `CommonFilters'. cheers
Alessandro Vermeulen
@spockz
You could replace the default monitor to print just the message
Or suppress it through logback: https://stackoverflow.com/a/29851754
Neal Huang
@buxingzhe
Hi guys, is there any way to make finagle-thrift and finagle-thriftmux client&server to be compatible with each other?