@jdcohen220 I’m pretty sure there’s a bijection for this in https://github.com/twitter/bijection (yep, see: https://github.com/twitter/bijection/blob/develop/bijection-util/src/main/scala/com/twitter/bijection/twitter_util/JavaFutureConverter.scala)
case class RequestOne(@RouteParam id: UUID, ...)
case class RequestTwo(@RouteParam id: UUID, ...)
case class SuperRequest(requestOne: RequestOne, requestTwo: RequestTwo)
I get this validation error:
Unable to inject field 'id' with Key[type=scala.Option<java.util.UUID>, annotation=[none]] into class class RequestOne
case class RequestOne(@RouteParam id: Option[UUID] = None, ...)
Use of those annotations requires the object mapper to be configured with the MessageInjectableValues as documented. You cannot use them automatically. From your error it looks like your mapper is not configured properly. This is done in the DefaultMesageBodyReader in Finatra/http
you’d need to call
injector.instance[DefaultMessageBodyReader].parse[RequestOne](request)
but fail with that error when using the
SuperRequest i.e. post("/path") { rq: SuperRequest => ???? }
but this seems to be what I'm looking for: https://github.com/twitter/finatra/blob/develop/doc/src/sphinx/user-guide/json/index.rst#mix-in-annotations
i believe by we set “application/octet-stream” by default if a returned response has a body by doesn’t specify a content type
Can anyone point me to the recommended way of adding shutdown hooks in finatra?
@aakashsabharwal have you taken a look at the documentation? The User Guide (https://twitter.github.io/finatra/user-guide/) goes into great detail about the application lifecycle (https://twitter.github.io/finatra/user-guide/getting-started/lifecycle.html) and how to close/shutdown resources.
.filter(new Cors.HttpFilter(CorsController.policy))
.exceptionMapper[ThrowableExceptionMapper]
the
ResponseBuilder in the ExceptionMapper does not have the headers set by the filter higher up the stack?
How would you go about maintaining the headers?
@martinffx I’m not sure I understand the question. For exception mapping to work, you need to have the ExceptionMappingFilter installed, https://twitter.github.io/finatra/user-guide/http/exceptions.html#exceptionmappingfilter
But I’m not sure what is meant by maintaining the "CORS headers in an exception mapper response”.
Can you explain?
I see the
CommonFilters includes the ExceptionMappingFilter which catches the exception, this means that all filters after it are not run after the exception has been thrown and the ExceptionMappingFilter handles the exception.
"CORS headers in an exception mapper response”
sorry that is better explained as the CORSFilter not being applied to responses generated by the exception mapper.
I have also see it installed with
beforeRouting = true (https://twitter.github.io/finatra/user-guide/http/filters.html#global-filters) which necessarily makes it apply on the “outside” of all the other filters.
But yes, I think you want the CORSFilter “above” the ExceptionMappingFilter. Also you can always specify the filters in CommonFilters yourself manually, or even create your own “common filters” using the MergeFilter as I think you likely want the CORSFilter in between the HttpRresponseFilter and the ExceptionMappingFilter, technically.
Or maybe in between the AccessLoggingFilter and the HttpResponseFilter, hmm.