twitter/finatra

Fast, testable Scala services: https://twitter.github.io/finatra

sherzod

@sherzodv

Hi guys, is there a centralized way to change (add) base path to all registered controller in finatra?

4 replies

Christopher Coco

@cacoco

In a controller itself you just use prefix

Eg in MyController you’d scope the routes under prefix(“/api”)

But if you wanted something to apply for all controllers you add to the router...that is not there

Andy

@andy1xx8

@cacoco thanks Christopher. I got it

Marwan Rabbâa

@waghanza

Hi @cacoco,
I noticed a little typo
https://github.com/the-benchmarker/web-frameworks/pull/4146#issuecomment-814612219

Christopher Coco

@cacoco

@waghanza fixed here: twitter/finatra@660dcb0. Thanks!

Jason Cohen

@jdcohen220

Where can I find the jars for inject-server / EmbeddedTwitterServer for scala 2.12? I am attempting to set up feature tests for HttpServer

Ian Bennett

@enbnt

@jdcohen220 https://search.maven.org/artifact/com.twitter/inject-server_2.12/21.3.0/jar (example project build deps as reference: https://github.com/twitter/finatra/blob/develop/build.sbt#L1421-L1436)

Jason Cohen

@jdcohen220

@enbnt thank you!

Jason Cohen

@jdcohen220

Is it possible to conditionally or lazily instantiate/inject modules? Let's say I want my server to either use a MongoDB or Postgres module for the datastore depending on some configuration or flag. I cannot simply inject both since one would fail to start if the instance doesn't exist in that environment.

9 replies

Jason Cohen

@jdcohen220

Any recommendations for in-memory caching libraries that play well with twitter futures?

Christopher Coco

@cacoco

Have you seen Twitter/util/util-cache? https://github.com/twitter/util/tree/develop/util-cache

Vladimir Ivanovskiy

@vi-p4f

Hi! Are there any known obstacles for using Finatra 21.2.0 in Scala 3 built projects?

3 replies

jyanJing

@jyanJing

freshly baked Finatra summer update 😃 : https://finagle.github.io/blog/2021/08/03/summer-review/

jyanJing

@jyanJing

August release is here! https://finagle.github.io/blog/2021/08/13/release-notes/

Moses Nakamura

@mosesn

hey folks, I’m starting the process for the 22.2.0 release today!

Bo Zhao

@BoZhaoUT

Hey all, I'm new to Finatra. Could you help me finding a minimalist Finatra boilerplate repo? The example one is deeply nested in the Finatra repo and I don't know how to write a sbt file for it. https://github.com/twitter/finatra/tree/develop/examples/http-server

1 reply

Zach Michaelov

@zmichaelov

Hi all,

According to the docs, the integrated ScalaValidator should check constraints on fields marked optional.
However, when I try to deserialize and validate using the ScalaObjectMapper, I get an error:

No validator could be found for constraint 'interface jakarta.validation.constraints.Min' validating type 'scala.Option'. Check configuration for 'Car.towing_capacity'
jakarta.validation.UnexpectedTypeException: No validator could be found for constraint 'interface jakarta.validation.constraints.Min' validating type 'scala.Option'. Check configuration for 'Car.towing_capacity'
    at com.twitter.util.validation.ScalaValidator.isValid(ScalaValidator.scala:1333)
    at com.twitter.util.validation.ScalaValidator.isValidOption(ScalaValidator.scala:1373)
    at com.twitter.util.validation.ScalaValidator.isValid(ScalaValidator.scala:1295)
    at com.twitter.util.validation.ScalaValidator.isValid(ScalaValidator.scala:1276)
    at com.twitter.util.validation.ScalaValidator.validateField(ScalaValidator.scala:1007)
    at com.twitter.util.validation.ScalaValidator.validateExecutableParameters(ScalaValidator.scala:899)
    at com.twitter.util.validation.ScalaValidator.validateExecutableParameters(ScalaValidator.scala:694)
    at com.twitter.util.jackson.caseclass.CaseClassDeserializer$.executeFieldValidations(CaseClassDeserializer.scala:92)

If I call the Scala Validator directly, it works. Is this a known bug or do I have something misconfigured? I'm on Finatra 21.11.0

Example code to reproduce

import com.twitter.util.jackson.ScalaObjectMapper
import com.twitter.util.validation.ScalaValidator
import jakarta.validation.constraints.Min
import org.scalatest.funsuite.AnyFunSuite

case class Car(@Min(1000) towingCapacity: Option[Int] = None)

class ValidationTest extends AnyFunSuite {

  private val mapper = ScalaObjectMapper.builder.objectMapper
  private val validator = ScalaValidator()

  test("check constraints") {
    // This works
    val car = Car(Some(100))
    validator.validate(car)

    // This throws an error
    val json = """{ "towing_capacity": 100 }"""
    val result = mapper.parse[Car](json)
  }
}

Mike Cripps

@macripps

did you ever work this out, @zmichaelov ?

Mike Cripps

@macripps

Looks like it might have been addressed by twitter/util@3b94d2e

1 reply

Zhenhao Li

@Zhen-hao

hi all, I notice that questions here are rarely answered.
If your question is for work and your company has a budget for paid consulting, I invite you to create a pairing request on https://pairtime.com. If I can't help myself, I will do my best to find the right people to help you.

Khal!l

@redkhalil

Newbie question: How do I use a configuration (from application.conf) in HttpServer subclass? I'm able to inject configuration elsewhere, but not really sure about the HttpServer.

Mike Cripps

@macripps

Something like this may help? https://groups.google.com/g/finatra-users/c/kkZgI5dG9CY/m/lzDPAmUxAwAJ

soz

@iamsoz:matrix.org

[m]

CharlieQW

@CharlieQW

Hey any plans to get finatra working with scala 3? Are any of the devs at twitter still around to work on this ? :D I realise this is open source btw so don't want to come across as demanding - just curious to know what the plans are. I want to write in scala 3 and use finatra!

Khal!l

@redkhalil

Hi, I need to implement circuit breaker at the server, that is if there are multiple requests that are failing, I want to return something like a 503 to the caller. When googling for circuit breaker all info seem to point to circuit breaking at the http client level. Is there anything at the server level?

Christopher Coco

@cacoco

@CharlieQW there were plans but it required all the upstream projects to get to Scala 3 (util, finagle, scrooge & twitter-server). Util was mostly there but some things (like util-jackson) needed more in-depth changes to get it Scala 3 compatible.

@redkhalil you likely want server-side response classification: https://twitter.github.io/finatra/user-guide/http/server.html#id3

or possibly just regular exception mapping: https://twitter.github.io/finatra/user-guide/http/exceptions.html. depends on what you're trying to do.

Where communities thrive

People

Repo info

Activity