Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Luka Jacobowitz
    @LukaJCB
    He didn’t really have time to maintain it for a long time unfortunately
    Nicolas A Perez
    @anicolaspp
    i see
    between him and myself wrote most of the original code
    I would like to get back to it
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    @anicolaspp I can add you as a contributor if you'd like
    Nicolas A Perez
    @anicolaspp
    please, do
    Kai(luo) Wang
    @kailuowang
    :tada: :clap:
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    @anicolaspp Done!
    Welcome back
    We've been trying to get the ball rolling again, see also typelevel/cats-collections#105
    Nicolas A Perez
    @anicolaspp
    I have some old PRs that were never merged
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    The more help, the merrier
    yeah, we cleared out the queue
    Nicolas A Perez
    @anicolaspp
    I will resubmit some of them soon
    most of them around Diet
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    But not for technical reasons, just because nobody had the capacity to bring them into shape
    Nicolas A Perez
    @anicolaspp
    that was very hard work on my side
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    Yeah, I think Diet has some rough edges, especially the tests
    Nicolas A Perez
    @anicolaspp
    yeah
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    The diet map thing also looked gut
    Nicolas A Perez
    @anicolaspp
    I wrote the original test suit
    and then we started to migrate it
    dont know about the current state
    I will look at that too
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    So far I haven't touched that file. I've added only a few tests at some places
    and moved the Scalacheck generators into a separate module
    I'd say that's about the extent of my changes there
    Nicolas A Perez
    @anicolaspp
    I think I have a balanced diet somewhere
    @larsrh I will try to get to this soon
    thanks for keeping this alive
    for the record, I learned Scala writing some of these structures, that is why some of them don't follow standard patterns. I didn't know much back then. I had a bag full of F# crap with me
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    That's alright :slight_smile:
    I understand almost nothing about the actual data structures
    so far I've just been more of a janitor
    Pablo Francisco Pérez Hidalgo
    @pfcoperez
    👋 I wrote DisjointSets, if you need information about them, just let me know. Also, I am more than happy to help when I can squeeze time 🙂
    Narek Asadorian
    @nasadorian
    Hi folks.. I wrote up a basic implementation of a pure functional set for cats. Would love to hear feedback on what I can do to improve it and make it lawful
    ^ Anyone know why this is true? I'd assume because lambdas are boxed, and composing a bunch of boxes then unraveling them takes stack space?
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    In Scala, the answer is usually trivial: because there's only limited TCO
    but there are tricks, e.g. cats.Eval (see my follow-up comment)
    Long Cao
    @longcao

    I saw this on my twitter feed if anyone might be interested: https://github.com/lacuna/bifurcan

    This library provides high-quality Java implementations of mutable and immutable data structures

    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    I'm not entirely sure, but I think diet is broken
    I've been trying to add some tests and they are failing
    also the existing tests are failing, I think
    Christopher Davenport
    @ChristopherDavenport
    Worrisome. Since starting help out I've been trying to find reasons to experiment with them. Never needed Diet yet.
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    I've opened some issues; Diet is definitely broken
    I've fixed #147 locally already but don't know what's wrong in #149
    Ghost
    @ghost~529c6cf4ed5ab0b3bf04da61
    @anicolaspp Would you mind taking a look at #150?