Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 25 08:28
    typelevel-steward[bot] opened #4354
  • Nov 25 08:28

    typelevel-steward[bot] on scalaz-core-7.3.7

    Update scalaz-core to 7.3.7 (compare)

  • Nov 24 18:48

    github-actions[bot] on gh-pages

    deploy: 310e333746b73cdd4d4f79f… (compare)

  • Nov 24 18:35

    armanbilge on main

    Update nscplugin, sbt-scala-nat… Merge pull request #4353 from t… (compare)

  • Nov 24 18:35

    armanbilge on nscplugin-0.4.9

    (compare)

  • Nov 24 18:35
    armanbilge closed #4353
  • Nov 24 12:46

    typelevel-steward[bot] on nscplugin-0.4.8

    (compare)

  • Nov 24 12:46
    typelevel-steward[bot] closed #4338
  • Nov 24 12:46

    typelevel-steward[bot] on nscplugin-0.4.9

    Update nscplugin, sbt-scala-nat… (compare)

  • Nov 24 12:46
    typelevel-steward[bot] commented #4338
  • Nov 24 12:46
    typelevel-steward[bot] opened #4353
  • Nov 23 18:44
    kubukoz commented #4242
  • Nov 22 22:35
    isomarcte synchronize #4349
  • Nov 22 15:11
    isomarcte synchronize #4349
  • Nov 20 10:50
    jpassaro synchronize #4352
  • Nov 20 10:31
    jpassaro synchronize #4352
  • Nov 20 09:54
    jpassaro synchronize #4352
  • Nov 20 09:30
    jpassaro synchronize #4352
  • Nov 20 09:23
    jpassaro commented #4352
  • Nov 20 09:11
    jpassaro edited #4352
Daniel Spiewak
@djspiewak
yeah, Eq for Function1 on javascript is flaky
I think it was @kailuowang who found that (at least, that's what my vague memory thinks)
Yilin Wei
@yilinwei
How come, don't they both essentially pump Arb[A] into the function and compare the results?
Daniel Spiewak
@djspiewak
they do
I don't remember the exact details of why it's flaky, but it comes down to the fact that generating arbitrary values is really slow on JS
so it can only pump a few values on javascript
(I think it's like, 5?)
Yilin Wei
@yilinwei
The failure wasn't that it was hanging though; the assertion was incorrect.
Daniel Spiewak
@djspiewak
hmm
Yilin Wei
@yilinwei
It should boil down to None == None after the function has been invoked.
Edmund Noble
@edmundnoble
Eq for function1 is flaky on all platforms.
JS just happens to have few testing samples.
Function1's Eq gives you false positives. And then when your test negates the result, you get a false negative.
Kai(luo) Wang
@kailuowang
we should probably bump up the numbers of samples in js now that we have matrix build and js is no longer the bottle neck
Yilin Wei
@yilinwei
Ah, I understand.
Kai(luo) Wang
@kailuowang
crap, I click the wrong button and commited typelevel/cats@80d56e6 to master without PR
I am going to revert it back.
Kai(luo) Wang
@kailuowang
just submitted a PR #1705 to revert it, but if you thumbs up the original change , we might not need to merge the revert PR.
I apologize. Looks like that less sleep is taking a toll on me.
Edmund Noble
@edmundnoble
No worries. Where's the original change?
Kai(luo) Wang
@kailuowang
typelevel/cats@80d56e6
Edmund Noble
@edmundnoble
For the record, :+1: from me.
Kai(luo) Wang
@kailuowang
would you post it to the PR and indicate if the thumb is for the original change or the revert. Thanks!
Edmund Noble
@edmundnoble
Kk I'll put it there
Yilin Wei
@yilinwei
I think #1659 looks fine; codecov is down, though not really sure how to read it because I've tested all the new code and it was pretty much moving the code from one place to another.
Yilin Wei
@yilinwei
#1332 can be closed?
Kai(luo) Wang
@kailuowang
@yilinwei I will get back to you on those two issues later if no one else beats me to it.
Yilin Wei
@yilinwei
Apologies; since I don't follow all the discussion all the time, the issues are the only way I really know what's going on and pick up new issues.
Kai(luo) Wang
@kailuowang
No problem. I had a hard time following discussions as well, mostly because Edmund couldn't stop talking. :smile: . Thankfully cats-dev seems a lot easier to follow
Edmund Noble
@edmundnoble
<3
Kai(luo) Wang
@kailuowang
any maintainer has 5 minutes to spare? #1709 should be a quick review.
Daniel Spiewak
@djspiewak
@kailuowang done
Kai(luo) Wang
@kailuowang
that’s quick. Thanks!
also Traverse1 needs a better name in #1611.
Kai(luo) Wang
@kailuowang
other than @ceedubs and @peterneyens is there any other people interested in weigh in typelevel/cats#1567 ?
Daniel Spiewak
@djspiewak
how exactly do we make releases? does the CI do it for us (based on a tag?) or do we cut releases locally?
Daniel Spiewak
@djspiewak
judging by the fact that @adelbertc's personal GPG signature is on 0.9.0, I'm guessing that we do local releases?
Daniel Spiewak
@djspiewak
release process seems to be sbt clean +test release
also we aren't signing tags, which we should fix
(typelevel/cats#1717)
Kai(luo) Wang
@kailuowang
we do local release
Adelbert Chang
@adelbertc
@djspiewak woa how did you know that
Why you creepin'
Daniel Spiewak
@djspiewak
LOL
sbt checkPgpSignatures
More people should use that command
Adelbert Chang
@adelbertc
a likely story
Kai(luo) Wang
@kailuowang
@/all can we get more opinions on the name for Traverse1 in typelevel/cats#1611
Andy Scott
@andyscott
Do you want non-maintainers to weigh in?