Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 15:57

    github-actions[bot] on gh-pages

    deploy: 024dd3d13ac9725ea663a4f… (compare)

  • 15:53

    armanbilge on main

    links for no script Merge pull request #4397 from R… (compare)

  • 15:52
    armanbilge closed #4397
  • 15:52
    armanbilge closed #4395
  • 15:21
    RawToast opened #4397
  • Feb 07 17:46
    satorg synchronize #4299
  • Feb 07 05:28

    github-actions[bot] on gh-pages

    deploy: a266f535fae575fb6f59978… (compare)

  • Feb 07 05:24

    armanbilge on sbt-scalajs-1.13.0

    (compare)

  • Feb 07 05:24

    armanbilge on main

    Update sbt-scalajs, scalajs-com… Merge pull request #4396 from t… (compare)

  • Feb 07 05:24
    armanbilge closed #4396
  • Feb 07 03:12
    typelevel-steward[bot] opened #4396
  • Feb 07 03:11

    typelevel-steward[bot] on sbt-scalajs-1.13.0

    Update sbt-scalajs, scalajs-com… (compare)

  • Feb 07 02:32

    github-actions[bot] on gh-pages

    deploy: 3c38fa99fb1db4ccaedd310… (compare)

  • Feb 07 02:30
    satorg synchronize #4299
  • Feb 07 02:28

    armanbilge on main

    `cats.implicits._` -> `cats.syn… Fixing Revert to `cats.implicits` for … and 1 more (compare)

  • Feb 07 02:28
    armanbilge closed #4394
  • Feb 07 01:19
    armanbilge review_requested #4394
  • Feb 07 01:18
    armanbilge synchronize #4394
  • Feb 06 21:46
    armanbilge synchronize #4394
  • Feb 06 21:41
    johnynek commented #4395
Edmund Noble
@edmundnoble
JS just happens to have few testing samples.
Function1's Eq gives you false positives. And then when your test negates the result, you get a false negative.
Kai(luo) Wang
@kailuowang
we should probably bump up the numbers of samples in js now that we have matrix build and js is no longer the bottle neck
Yilin Wei
@yilinwei
Ah, I understand.
Kai(luo) Wang
@kailuowang
here https://github.com/typelevel/cats/blob/master/laws/src/main/scala/cats/laws/discipline/Eq.scala#L16
Kai(luo) Wang
@kailuowang
crap, I click the wrong button and commited typelevel/cats@80d56e6 to master without PR
I am going to revert it back.
Kai(luo) Wang
@kailuowang
just submitted a PR #1705 to revert it, but if you thumbs up the original change , we might not need to merge the revert PR.
I apologize. Looks like that less sleep is taking a toll on me.
Edmund Noble
@edmundnoble
No worries. Where's the original change?
Kai(luo) Wang
@kailuowang
typelevel/cats@80d56e6
Edmund Noble
@edmundnoble
For the record, :+1: from me.
Kai(luo) Wang
@kailuowang
would you post it to the PR and indicate if the thumb is for the original change or the revert. Thanks!
Edmund Noble
@edmundnoble
Kk I'll put it there
Yilin Wei
@yilinwei
I think #1659 looks fine; codecov is down, though not really sure how to read it because I've tested all the new code and it was pretty much moving the code from one place to another.
Yilin Wei
@yilinwei
#1332 can be closed?
Kai(luo) Wang
@kailuowang
@yilinwei I will get back to you on those two issues later if no one else beats me to it.
Yilin Wei
@yilinwei
Apologies; since I don't follow all the discussion all the time, the issues are the only way I really know what's going on and pick up new issues.
Kai(luo) Wang
@kailuowang
No problem. I had a hard time following discussions as well, mostly because Edmund couldn't stop talking. :smile: . Thankfully cats-dev seems a lot easier to follow
Edmund Noble
@edmundnoble
<3
Kai(luo) Wang
@kailuowang
any maintainer has 5 minutes to spare? #1709 should be a quick review.
Daniel Spiewak
@djspiewak
@kailuowang done
Kai(luo) Wang
@kailuowang
that’s quick. Thanks!
also Traverse1 needs a better name in #1611.
Kai(luo) Wang
@kailuowang
other than @ceedubs and @peterneyens is there any other people interested in weigh in typelevel/cats#1567 ?
Daniel Spiewak
@djspiewak
how exactly do we make releases? does the CI do it for us (based on a tag?) or do we cut releases locally?
Daniel Spiewak
@djspiewak
judging by the fact that @adelbertc's personal GPG signature is on 0.9.0, I'm guessing that we do local releases?
Daniel Spiewak
@djspiewak
release process seems to be sbt clean +test release
also we aren't signing tags, which we should fix
(typelevel/cats#1717)
Kai(luo) Wang
@kailuowang
we do local release
Adelbert Chang
@adelbertc
@djspiewak woa how did you know that
Why you creepin'
Daniel Spiewak
@djspiewak
LOL
sbt checkPgpSignatures
More people should use that command
Adelbert Chang
@adelbertc
a likely story
Kai(luo) Wang
@kailuowang
@/all can we get more opinions on the name for Traverse1 in typelevel/cats#1611
Andy Scott
@andyscott
Do you want non-maintainers to weigh in?
Commented regardless 😉
Kai(luo) Wang
@kailuowang
@andyscott of course. thanks very much!
Andy Scott
@andyscott
Consistent naming is my favorite, even if it means a longer name ☺️
Kai(luo) Wang
@kailuowang
Same here. I don’t mind that much longer name as long as they are as short as possible to convey the meaning. .
Adelbert Chang
@adelbertc
@edmundnoble fight me
Edmund Noble
@edmundnoble
LOL
Yes, I responded to that; ApplicativeError has laws which relate raiseError with handleError.
Adelbert Chang
@adelbertc
oh independent of Applicative itself?
i thought it relied on pure or something
Edmund Noble
@edmundnoble
Well also there's errorLeftZero and errorRightZero, which state that map2(fa, raiseError(e)) and map2(raiseError(e), fa) equal raiseError(e) as well
I think @djspiewak was referring to removing Applicative from ApplicativeError?