Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 15 05:26

    larsrh on master

    Update sbt to 1.3.3 Merge pull request #120 from sc… (compare)

  • Oct 15 05:26
    larsrh closed #120
  • Oct 15 02:00
    scala-steward opened #120
  • Oct 03 14:34
    lolgab commented #116
  • Oct 03 10:26
    larsrh commented #57
  • Oct 03 10:26
    larsrh commented #116
  • Oct 03 10:24

    larsrh on v1.0.1

    (compare)

  • Oct 03 10:17

    larsrh on master

    fixed release process Setting version to 1.0.1 Setting version to 1.0.2-SNAPSH… (compare)

  • Sep 30 07:18
    larsrh closed #57
  • Sep 30 07:18
    larsrh commented #57
  • Sep 29 13:51

    larsrh on master

    Update sbt-sonatype to 3.8 Update sbt-sonatype to 3.8 (#11… (compare)

  • Sep 29 13:51
    larsrh closed #119
  • Sep 29 13:01
    scala-steward opened #119
  • Sep 27 19:22

    larsrh on master

    adapt release process (compare)

  • Sep 26 13:33

    larsrh on master

    Update scalacheck to 1.14.2 Merge pull request #118 from sc… (compare)

  • Sep 26 13:33
    larsrh closed #118
  • Sep 26 12:45
    scala-steward opened #118
  • Sep 22 07:38

    larsrh on master

    Update sbt-sonatype to 3.7 Update sbt-sonatype to 3.7 (#11… (compare)

  • Sep 22 07:38
    larsrh closed #117
  • Sep 21 22:54
    scala-steward opened #117
BennyHill
@BennyHill
Hi!!
BennyHill
@BennyHill
The latest discipline on master gets rid of support for scala 2.10.x, because of specs2. The good news of course is that specs2 now supports scala.js
Is it worth changing the build to add 2.10.x support for an older version of specs2?
BennyHill
@BennyHill
I concede that this would complicate build.sbt, but it is a relatively small file to start with. So I guess the real question might be "Is it worth it to...?"
Lars Hupel
@larsrh
Happy to accept a PR
But I'm confused, what would it be required for?
BennyHill
@BennyHill
Required for? For any project that uses discipline that still wants to provide support for 2
1
...2.10. I believe cats still falls into that category
BennyHill
@BennyHill
so the question here really is about longer term support for 2.10 and who wants to be the fall guy for dropping support for it. My vote goes to "not me" :stuck_out_tongue:
N.b. looks to me that discipline is the first project to drop 2.10 that cats uses, so will be the project that forces cats to drop 2.10 support.
Lars Hupel
@larsrh
Right, understood
I was under the impression that dropping 2.10 for cats was a done deal
But I'm happy to revise that & accept a PR
BennyHill
@BennyHill
Ok. Will do... tomorrow :stuck_out_tongue:
BennyHill
@BennyHill
Hi @larsrh sorry, my time schedule is shot here, so looking like I won't have time to PR that change. Can I pass it back to you please?
Lars Hupel
@larsrh
@BennyHill I'll allocate a few hours this weekend for discipline maintenance
Should I put out a new release too?
BennyHill
@BennyHill
Hi @larsrh That would be great, thanks! A new release would be needed as well, please :+1:
BennyHill
@BennyHill
Hi @larsrh Not sure if you have looked at this already, but I think I've got something working here that I can push
BennyHill
@BennyHill
There you go ... typelevel/discipline#48
Lars Hupel
@larsrh
ah, very nice
BennyHill
@BennyHill
Dog walking/bed time now, if there are any issues, I can look tomorrow, bfn :wave:
Lars Hupel
@larsrh
I'll merge it today
Build is green
BennyHill
@BennyHill
looking at review now, is it possible to turn on info on right here -------->>>>>>>>>
ie activity?
Lars Hupel
@larsrh
Done.
discipline 0.9 just released
BennyHill
@BennyHill
thx :+1:
I'll try out release now with sbt-catalysts/catalysts/cats. Many thanks
BennyHill
@BennyHill
cool, looks like it's working fine :+1:
Luciano
@lJoublanc
Is there any way to get discipline to be more verbose about failed equality in tests? e.g. like scalatest does ("x did not equal y")?
Lars Hupel
@larsrh
That's probably a bug/feature of libraries using discipline
discipline doesn't really care how Props are formed
Ross A. Baker
@rossabaker
Did 0.12.0-M1 publish? I'm not able to resolve it.
Lars Hupel
@larsrh
https://repo1.maven.org/maven2/org/typelevel/discipline-core_2.13.0-RC2/
It's renamed now to -core
Ross A. Baker
@rossabaker
Oh, right. I even reviewed that and still forgot.
Ross A. Baker
@rossabaker
discipline-core-1.0.0 and discipline-scalatest-1.0.0-M1 are here, discipline-specs2-1.0.0 is coming soon: tweet
Artsiom Miklushou
@mikla
Hi,
Could you please tell where is Discipline trait for ScalaCheck now?