These are chat archives for typelevel/scala

18th
Nov 2017
Miles Sabin
@milessabin
Nov 18 2017 09:50
@soronpo just looking at that PR ... I have to say it looks surprisingly complicated ... is all that really necessary?
Oron Port
@soronpo
Nov 18 2017 10:18
I created the data structure to implement it as immutable code. If you look at the expression precedence implementation they do it with mutable code and one can barely understand what is going on. That being said, if you have any suggestions how to implement this better, I will gladly revise my code.
Oron Port
@soronpo
Nov 18 2017 10:33
@milessabin can you please trigger a community-build check for this PR?
Miles Sabin
@milessabin
Nov 18 2017 10:59
Discuss with @adriaanm, but I think you'll increase your chances of the code being merged if you make it as consistent as possible with what's already there. Ideally sharing the term logic with the type logic.
If you can share type and term logic with a pure implementation and not degrade performance then that would stand a good chance. The performance hurdle might be a tough one unless you're very very careful.
Oron Port
@soronpo
Nov 18 2017 17:14
@milessabin FYI shapeless compiled fine, but kind-projector failed.
debugging the compiler with a compiler-plugin :worried: My brain is going to melt.