These are chat archives for u3games/L2J_EventEngine

18th
Oct 2015
fissban
@fissban
Oct 18 2015 00:53
@luksdlt92 echale una mirada
u3games/L2J_EventEngine@41a0d3a
u3games/L2J_EventEngine@17ef986
Lucas
@luksdlt92
Oct 18 2015 04:44
@fissban listo los dos
chequea los comentarios
fissban
@fissban
Oct 18 2015 05:49
@luksdlt92 el branch de los scheduledEvents lo borre y lo volvi a subir...no se porq xD
todo esto porque queria hacer para poder configurar si quiero un scheduled se haga una sola ves o se repita
fissban
@fissban
Oct 18 2015 07:09
@luksdlt92 ya hice revise tu tra bajo...bastante bonito pero revisa mis comentarios
fissban
@fissban
Oct 18 2015 09:05
@u3games proba este antiAfk q yo no lo hice xD
U3Games
@u3games
Oct 18 2015 10:06
This message was deleted
mmm... ya lo miro luego, thx fiss
Lucas
@luksdlt92
Oct 18 2015 15:48
ya contesté todo
Lucas
@luksdlt92
Oct 18 2015 16:24
@fissban mergié el pr del bug de registro, metí un nuevo issue que encontré
fissban
@fissban
Oct 18 2015 17:20
no sirve, borrala nomas
Zoey76
@Zoey76
Oct 18 2015 18:26
Now jars in libs folder are added to class path by Gradle
  • EventEngineManager.getInstance().listenerOnLogin(activeChar);
this can be done with listeners :smile:
wtf is +import net.sf.eventengine
  • // L2J EventEngine
  • if ((killer != null) && killer.isPlayable())
  • {
  • EventEngineManager.getInstance().listenerOnKill((L2Playable) killer, this);
  • }
that can use listeners too...
you can make this with almost not touching code
from core
Lucas
@luksdlt92
Oct 18 2015 18:42
@Zoey76 who knows why the packages are called so
por qué se llama net.sf.eventengine los package? @fissban
about listeners, yes, i'll check which stuffs can use l2j listeners :D
Zoey76
@Zoey76
Oct 18 2015 18:44
I can make a PR against the repo
also, why don't you go against master only?
stable is just a mirror
Lucas
@luksdlt92
Oct 18 2015 18:45
you mean?
we use pr to do code review and test before merging master
to know if the features are working well
Zoey76
@Zoey76
Oct 18 2015 18:46
I'm talking about L2J's master
Lucas
@luksdlt92
Oct 18 2015 18:46
oh, ok
Zoey76
@Zoey76
Oct 18 2015 18:46
you are still using pre-gradle code
Lucas
@luksdlt92
Oct 18 2015 18:47
in fact, i don't know >.<
Zoey76
@Zoey76
Oct 18 2015 18:48
btw there is an issue in L2j about dual box
I assigned it to you :D
Lucas
@luksdlt92
Oct 18 2015 18:48
yeap, i know, i was working on that in the past :D
there is a gist in forum
the only issue i found is in olys battle
i told you
Lucas
@luksdlt92
Oct 18 2015 22:14
@fissban @u3games Actualizado u3games/L2J_EventEngine#66