These are chat archives for u3games/L2J_EventEngine

19th
Nov 2015
Lucas
@luksdlt92
Nov 19 2015 01:42
oh, i noticed that some days ago
i'm going to create an issue for that
also, you can create an issue in github if you find a bug or something :)
AntoineKouma
@AntoineKouma
Nov 19 2015 02:12
im new here so give me some time to learn about it :)
btw ur job is awesome i appreciate your help.
Lucas
@luksdlt92
Nov 19 2015 02:27
haha, dont worry
i'll take a look later ;) probably is something with the listener
AntoineKouma
@AntoineKouma
Nov 19 2015 02:35
If you can also add in confing settings enable/ True, False event Engine (if i remember doesnt exist) it would be helpful to enable or disable whole event no each one. :)
Lucas
@luksdlt92
Nov 19 2015 02:35
you can simply remove the script from scripts.cfg
AntoineKouma
@AntoineKouma
Nov 19 2015 02:36
you mean #custom.events etc?
Lucas
@luksdlt92
Nov 19 2015 02:36
i think the enabled/disabled flag doesn't have sense
yeap
AntoineKouma
@AntoineKouma
Nov 19 2015 02:37
i mean the whole event engine enable disable like button on/off
if we can copy the java code of tvt who already include in pack and just insert in the event engine do you believe Didn't Work?
Lucas
@luksdlt92
Nov 19 2015 02:40
why we should do that?
it's not simple
AntoineKouma
@AntoineKouma
Nov 19 2015 02:42
event engine have 5 diferent events and each one has diferent enable/disable. if we can add enable disable in event engine for whole event it wouldnt be more helpful? maybe im wrong and just sharing my opinion!
Lucas
@luksdlt92
Nov 19 2015 02:43
for me, it doesn't make sense have a 'button' when you just can remove the line from scripts
but yes, we can add that
AntoineKouma
@AntoineKouma
Nov 19 2015 02:45
remove and write again in scrips takes more time from Enable /True,False :P btw EventEngine is awesome for any server (and i believe that other npc bugg will be fixed) :)
Lucas
@luksdlt92
Nov 19 2015 02:51
yeah, when i have free time xD
also, we want to provide a simple interface to let the server admins create their own events
by easy and simple way
AntoineKouma
@AntoineKouma
Nov 19 2015 02:54
This one would be nice, but you need time and time is lost money at this time!
Lucas
@luksdlt92
Nov 19 2015 02:55
i don't want money, i have a job for that
i want a modern software for all the servers
free and open-source
AntoineKouma
@AntoineKouma
Nov 19 2015 02:56
A open Event Engine? with core edit?
Lucas
@luksdlt92
Nov 19 2015 02:56
yes, you can see the source code in github
you are free for fork it
AntoineKouma
@AntoineKouma
Nov 19 2015 02:57
Give me the link cause im in work right now and i have my pc open in github pages etc!
sorry for spanish comments
some members of the project don't know english
at least a bit :P
AntoineKouma
@AntoineKouma
Nov 19 2015 02:59
hahaha im from greece and i try translate your comments etc, is more dificult from compiling.
Lucas
@luksdlt92
Nov 19 2015 02:59
if you want to implement something or fix a bug, do a pull request
i will checkout your changes, if i agree, i will merge it
AntoineKouma
@AntoineKouma
Nov 19 2015 03:01
I make a new issue for npc bug, im gonna read your project when i go home and i will try help you add more things etc :)
Lucas
@luksdlt92
Nov 19 2015 03:02
thank you, that's the idea :D
it's still under beta state, but i think that goes for good way
AntoineKouma
@AntoineKouma
Nov 19 2015 03:04
Do you have tried Nexus Engine? I have see some videos in youtube like this one https://www.youtube.com/watch?v=14tcg5SahKc
Lucas
@luksdlt92
Nov 19 2015 03:05
yeah, i have the jar
in the past, i bought itt
AntoineKouma
@AntoineKouma
Nov 19 2015 03:05
This one is a open source event engine?
Lucas
@luksdlt92
Nov 19 2015 03:06
no
it was expensive and works fine
but i'm not sure if it has good code
AntoineKouma
@AntoineKouma
Nov 19 2015 03:06
You dont have the code or files to try read them?
Lucas
@luksdlt92
Nov 19 2015 03:07
right now, not
AntoineKouma
@AntoineKouma
Nov 19 2015 03:07
Nevermind i dont like it. You and we can make a better Engine i suppose!
Lucas
@luksdlt92
Nov 19 2015 03:08
the team is formed by @fissban and @u3games too
anyone are welcome
AntoineKouma
@AntoineKouma
Nov 19 2015 03:10
You are a open source man and u are welcome everyone to help this project work for anyone free, god gonna help you! :)
Lucas
@luksdlt92
Nov 19 2015 03:11
well, i'm also l2j developer xD
but actually i'm spending my time in the engine
AntoineKouma
@AntoineKouma
Nov 19 2015 03:12
O, can you tell me what is going on with erheia project? I cant find pack to test them!
Lucas
@luksdlt92
Nov 19 2015 03:13
the ertheia project was stopped, @Zoey76 wants finish HF and all the bug reports before
i agree
some developers, like unafraid, swd, nosbit, etc; makes their own project
developing for ertheia
AntoineKouma
@AntoineKouma
Nov 19 2015 03:14
Too bad for us...
Lucas
@luksdlt92
Nov 19 2015 03:15
i don't know, the time will say
the other project uses l2j base
nowdays works much better
(l2j main project)
AntoineKouma
@AntoineKouma
Nov 19 2015 03:19
Zealer keep working?
Lucas
@luksdlt92
Nov 19 2015 03:20
yes
he is the most active developer
AntoineKouma
@AntoineKouma
Nov 19 2015 03:22
Can ask something newbie? Im trying read compile etc but here in greece with crisis we dont have time only for work.
Lucas
@luksdlt92
Nov 19 2015 03:23
so?
AntoineKouma
@AntoineKouma
Nov 19 2015 03:25
Everytime i read what is new, from l2j site and im write the code! After this i compile the project and make again new server copy buffers gm shop etc!
I can apply the patch by url us team patch etc?
Lucas
@luksdlt92
Nov 19 2015 03:26
i don't understand
AntoineKouma
@AntoineKouma
Nov 19 2015 03:27
Hmmmm, when Zealer update a new fix there is another way to apply the fix without write the code?
Lucas
@luksdlt92
Nov 19 2015 03:28
depends the code
i think is not really neccesary do changes inside core
AntoineKouma
@AntoineKouma
Nov 19 2015 03:29
What i mean, imagine a way who can connect github with your eclipse and every time someone apply a new fix you can take it auto!
Lucas
@luksdlt92
Nov 19 2015 03:29
well, that exists
if you have the repository in github, you can create your on branch with your changes
and the develop branch from l2j
so, you do a git pull origin master to update your local develop repository
then, you can do a git merge to your custom branch
or do a commit with your custom changes and use git cherry-pick
or
you can do your own fork and do a fetch
AntoineKouma
@AntoineKouma
Nov 19 2015 03:33
In this way you must get repository every time if you wanna take the updates
Lucas
@luksdlt92
Nov 19 2015 03:33
not really, simply use git pull
AntoineKouma
@AntoineKouma
Nov 19 2015 03:34
Ofc i passed this way
I dont have words to thank you and this team for this years.
Thanks for everything, dont forget to look about event engine bug :P I have 2.30 hours more at work and then im gonna go home to read and look about new fixes, etc for event engine! Btw keep coding :D
Lucas
@luksdlt92
Nov 19 2015 03:38
haha, thank you
see you later
Lucas
@luksdlt92
Nov 19 2015 04:20
@AntoineKouma i did a pr to fix the npcs issue :)
u3games/L2J_EventEngine#107
@fissban te agradecería que puedas ver el pr cuando tengas un ratito
fissban
@fissban
Nov 19 2015 14:40
voy a tener q revisarlo bien, porque ahora el listenerOnInteract ya no es mas necesario q sea boolean, asiq no necesitamos retornar mas un valor
a lo mejor el problema sin mirarlo mucho puede estar alli
Lucas
@luksdlt92
Nov 19 2015 14:54
no, no está allí
es verdad que hay que modificar los returns
pero el problema está en que overrideas todas las ventanas defaults de los npcs
en l2j hay algo como
if (tiene listener)
mandá al listener
else
mandá ventana default
en el caso del interact únicamente
fissban
@fissban
Nov 19 2015 22:42
entonces esta perfecto lo q has echo